-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idempotent methods: hide exceptions on retries if there is evidence the original operation succeeded #924
Comments
Consider this scenario as an example of the problem: Though in this case an exception will be thrown with or without a retry, a retry mask the original failure In this particular case if we want to fix this issue we need to capture the "already-exists" error and do an extra RPC call to get the zone information. If the zone information matches the request we should return without an error otherwise we should propagate the "already-exists". |
I'm going to reclassify this as an enhancement. The error returned from a retry isn't technically "wrong", it's just maybe not really what the user would want. |
This has been added to our feature backlog: https://github.com/GoogleCloudPlatform/google-cloud-java/wiki/Feature-backlog . This issue will be closed but is linked in the backlog and can continue to be used for comment and discussion. |
…cies to v2.13.0 (#924) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-dependencies](https://togithub.com/googleapis/java-shared-dependencies) | `2.12.0` -> `2.13.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.13.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.13.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.13.0/compatibility-slim/2.12.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.13.0/confidence-slim/2.12.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-dependencies</summary> ### [`v2.13.0`](https://togithub.com/googleapis/java-shared-dependencies/blob/HEAD/CHANGELOG.md#​2130-httpsgithubcomgoogleapisjava-shared-dependenciescomparev2120v2130-2022-06-22) [Compare Source](https://togithub.com/googleapis/java-shared-dependencies/compare/v2.12.0...v2.13.0) ##### Dependencies - update dependency com.google.api-client:google-api-client-bom to v1.35.0 ([#​709](https://togithub.com/googleapis/java-shared-dependencies/issues/709)) ([239f8c3](https://togithub.com/googleapis/java-shared-dependencies/commit/239f8c33a11e233e6af79aee8c7e68cd156a0554)) - update dependency com.google.api-client:google-api-client-bom to v1.35.1 ([#​713](https://togithub.com/googleapis/java-shared-dependencies/issues/713)) ([6559b45](https://togithub.com/googleapis/java-shared-dependencies/commit/6559b45b027dba783a9525d35e32183d78773cbe)) - update dependency com.google.api:api-common to v2.2.1 ([#​710](https://togithub.com/googleapis/java-shared-dependencies/issues/710)) ([650d4c5](https://togithub.com/googleapis/java-shared-dependencies/commit/650d4c5f8c3cfce711257d47280ad773cd2e2414)) - update dependency com.google.errorprone:error_prone_annotations to v2.14.0 ([#​701](https://togithub.com/googleapis/java-shared-dependencies/issues/701)) ([d24730f](https://togithub.com/googleapis/java-shared-dependencies/commit/d24730f78669f80b109e590b903446e5552e3e36)) - update dependency com.google.http-client:google-http-client-bom to v1.42.0 ([#​711](https://togithub.com/googleapis/java-shared-dependencies/issues/711)) ([5168a18](https://togithub.com/googleapis/java-shared-dependencies/commit/5168a181722128d434a0d0d2ab5cc485686bbc78)) - update dependency com.google.oauth-client:google-oauth-client-bom to v1.34.0 ([#​708](https://togithub.com/googleapis/java-shared-dependencies/issues/708)) ([620336e](https://togithub.com/googleapis/java-shared-dependencies/commit/620336e6733e2017116e5e8a7b403b183a728bc1)) - update dependency com.google.oauth-client:google-oauth-client-bom to v1.34.1 ([#​712](https://togithub.com/googleapis/java-shared-dependencies/issues/712)) ([a2c18a5](https://togithub.com/googleapis/java-shared-dependencies/commit/a2c18a5bc4152cc9034cec691a29f54a35c38a51)) - update dependency com.google.protobuf:protobuf-bom to v3.21.0 ([#​703](https://togithub.com/googleapis/java-shared-dependencies/issues/703)) ([5f9fe12](https://togithub.com/googleapis/java-shared-dependencies/commit/5f9fe1200b4bdf4c54bf947c21bd3ed02f26f990)) - update dependency com.google.protobuf:protobuf-bom to v3.21.1 ([#​705](https://togithub.com/googleapis/java-shared-dependencies/issues/705)) ([c68edfb](https://togithub.com/googleapis/java-shared-dependencies/commit/c68edfbe7e1993e1112640b867b29aa2fbcf7579)) - update dependency io.grpc:grpc-bom to v1.47.0 ([#​707](https://togithub.com/googleapis/java-shared-dependencies/issues/707)) ([d02918a](https://togithub.com/googleapis/java-shared-dependencies/commit/d02918a0418cd65d1d247f27afb0637f1f8f5666)) - update dependency org.checkerframework:checker-qual to v3.22.1 ([#​706](https://togithub.com/googleapis/java-shared-dependencies/issues/706)) ([545843b](https://togithub.com/googleapis/java-shared-dependencies/commit/545843b492cead230b8cc72a1dae7d4922f33b39)) - update dependency org.checkerframework:checker-qual to v3.22.2 ([#​717](https://togithub.com/googleapis/java-shared-dependencies/issues/717)) ([142852a](https://togithub.com/googleapis/java-shared-dependencies/commit/142852a37140f221197f5c71aed451def353b1e0)) - update gax.version to v2.18.2 ([#​718](https://togithub.com/googleapis/java-shared-dependencies/issues/718)) ([5f8156e](https://togithub.com/googleapis/java-shared-dependencies/commit/5f8156e55c6a07b018a8c5efafa68be781b4288b)) - update google.common-protos.version to v2.9.0 ([#​714](https://togithub.com/googleapis/java-shared-dependencies/issues/714)) ([9e5591e](https://togithub.com/googleapis/java-shared-dependencies/commit/9e5591ec3035350450ecbfebd00e08216433b06c)) - update google.core.version to v2.8.0 ([#​719](https://togithub.com/googleapis/java-shared-dependencies/issues/719)) ([4023c60](https://togithub.com/googleapis/java-shared-dependencies/commit/4023c6063a2c5b5308da531df1a08c90c491965d)) - update iam.version to v1.4.0 ([#​700](https://togithub.com/googleapis/java-shared-dependencies/issues/700)) ([c1097a4](https://togithub.com/googleapis/java-shared-dependencies/commit/c1097a46ab0739b0b7234bc510e4c3d9ce2c2861)) - update iam.version to v1.4.1 ([#​716](https://togithub.com/googleapis/java-shared-dependencies/issues/716)) ([e2dc7c2](https://togithub.com/googleapis/java-shared-dependencies/commit/e2dc7c21c39e007878841e2664d548ec44a72d54)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-vision).
🤖 I have created a release *beep* *boop* --- ## [2.1.3](googleapis/java-vision@v2.1.2...v2.1.3) (2022-06-23) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#924](googleapis/java-vision#924)) ([7886084](googleapis/java-vision@7886084)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Making CLIRR not required. The version bumps are now controlled by the Release Please and OwlBot. The CL authors create appropriate change description to control major version bumps.
Source-Link: googleapis/synthtool@7336562 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:d4b80feffe1579818cdc39466152e9de95789a193408506cd4a1ffbe8804dc00 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…-info-reports-plugin to v3.4.1 (#924) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) | `3.4.0` -> `3.4.1` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/compatibility-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/confidence-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-containeranalysis). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNjAuMSIsInVwZGF0ZWRJblZlciI6IjMyLjE2MC4xIn0=-->
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-crc32c](https://togithub.com/googleapis/python-crc32c) | `==1.3.0` -> `==1.5.0` | [![age](https://badges.renovateapi.com/packages/pypi/google-crc32c/1.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-crc32c/1.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-crc32c/1.5.0/compatibility-slim/1.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-crc32c/1.5.0/confidence-slim/1.3.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-language). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMiIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4yIn0=-->
… to v4.0.6 (#924) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-dataproc](https://togithub.com/googleapis/java-dataproc) | `4.0.5` -> `4.0.6` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dataproc/4.0.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dataproc/4.0.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dataproc/4.0.6/compatibility-slim/4.0.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dataproc/4.0.6/confidence-slim/4.0.5)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dataproc). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTguMSIsInVwZGF0ZWRJblZlciI6IjMyLjE5OC4xIn0=-->
🤖 I have created a release *beep* *boop* --- ## [2.11.0](https://togithub.com/googleapis/java-securitycenter/compare/v2.10.0...v2.11.0) (2022-10-03) ### Features * Added parent display name i.e. source display name for a finding as one of the finding attributes ([#915](https://togithub.com/googleapis/java-securitycenter/issues/915)) ([034d25a](https://togithub.com/googleapis/java-securitycenter/commit/034d25a3191ccc82dd4e9fe69124af3c24b1029f)) ### Dependencies * Update dependency cachetools to v5 ([#933](https://togithub.com/googleapis/java-securitycenter/issues/933)) ([5b2b39d](https://togithub.com/googleapis/java-securitycenter/commit/5b2b39dabf51c323316033c558efce77c2c19bf9)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.16.1 ([#917](https://togithub.com/googleapis/java-securitycenter/issues/917)) ([58ed894](https://togithub.com/googleapis/java-securitycenter/commit/58ed8942ca8012cf0456bfe431d21e7d553f1fd0)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.16 ([#913](https://togithub.com/googleapis/java-securitycenter/issues/913)) ([1eaf4b3](https://togithub.com/googleapis/java-securitycenter/commit/1eaf4b3b295ba7e248f88ef14a377d1e865ac5c3)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.17 ([#923](https://togithub.com/googleapis/java-securitycenter/issues/923)) ([60d65d3](https://togithub.com/googleapis/java-securitycenter/commit/60d65d35a3c50f8cedeb8ef9b4db0480d667a976)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.18 ([#924](https://togithub.com/googleapis/java-securitycenter/issues/924)) ([f94db64](https://togithub.com/googleapis/java-securitycenter/commit/f94db64c37b4e0c734ee8bd42a6d174feb2251ba)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#937](https://togithub.com/googleapis/java-securitycenter/issues/937)) ([001091d](https://togithub.com/googleapis/java-securitycenter/commit/001091d1d178d81e3cec06f3847687c8905be49a)) * Update dependency com.google.protobuf:protobuf-java-util to v3.21.6 ([#914](https://togithub.com/googleapis/java-securitycenter/issues/914)) ([992d37a](https://togithub.com/googleapis/java-securitycenter/commit/992d37a4fe95b598b638d159aa86e41e324a63ff)) * Update dependency com.google.protobuf:protobuf-java-util to v3.21.7 ([#935](https://togithub.com/googleapis/java-securitycenter/issues/935)) ([2353016](https://togithub.com/googleapis/java-securitycenter/commit/23530169d5c988e30c9a1c43a0405243dd6614ad)) * Update dependency markupsafe to v2.1.1 ([#927](https://togithub.com/googleapis/java-securitycenter/issues/927)) ([2c42b32](https://togithub.com/googleapis/java-securitycenter/commit/2c42b32a1831e08a8f0f5e4e600e18ca075d5c10)) * Update dependency protobuf to v3.20.2 ([#928](https://togithub.com/googleapis/java-securitycenter/issues/928)) ([faf7200](https://togithub.com/googleapis/java-securitycenter/commit/faf72009d3deea9bd869cc6e93a08d28325f2ace)) * Update dependency protobuf to v4 ([#934](https://togithub.com/googleapis/java-securitycenter/issues/934)) ([19f8da3](https://togithub.com/googleapis/java-securitycenter/commit/19f8da31814ae8f957b142655c45cdcb5254c696)) * Update dependency pyjwt to v2.5.0 ([#929](https://togithub.com/googleapis/java-securitycenter/issues/929)) ([a5b8ae2](https://togithub.com/googleapis/java-securitycenter/commit/a5b8ae2802dfaea8745eab65fa7c4ac83ebd973e)) * Update dependency requests to v2.28.1 ([#930](https://togithub.com/googleapis/java-securitycenter/issues/930)) ([ca80e91](https://togithub.com/googleapis/java-securitycenter/commit/ca80e911c33af260892a95998d15c1dd024c67d4)) * Update dependency typing-extensions to v4.3.0 ([#931](https://togithub.com/googleapis/java-securitycenter/issues/931)) ([12fda13](https://togithub.com/googleapis/java-securitycenter/commit/12fda1317eb93337827ee03918b91d0c3cbe1a15)) * Update dependency zipp to v3.8.1 ([#932](https://togithub.com/googleapis/java-securitycenter/issues/932)) ([15a6c7f](https://togithub.com/googleapis/java-securitycenter/commit/15a6c7f01f4e6da74e037852857af1e0cceaad11)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [2.4.1](https://togithub.com/googleapis/java-language/compare/v2.4.0...v2.4.1) (2022-10-03) ### Documentation * Update classification sample to use v2 model ([#899](https://togithub.com/googleapis/java-language/issues/899)) ([3f956fe](https://togithub.com/googleapis/java-language/commit/3f956fe12e0eeee2fb4fdf546f77d6b1043f1f73)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#929](https://togithub.com/googleapis/java-language/issues/929)) ([26b8438](https://togithub.com/googleapis/java-language/commit/26b84380417fa4bb153f6d7c4f30716192440f81)) * Update dependency google-api-core to v2.10.1 ([#921](https://togithub.com/googleapis/java-language/issues/921)) ([412cbb9](https://togithub.com/googleapis/java-language/commit/412cbb97138f52f8b706fbae3c847a80fbe34b4f)) * Update dependency google-auth to v2.12.0 ([#922](https://togithub.com/googleapis/java-language/issues/922)) ([5e2fd20](https://togithub.com/googleapis/java-language/commit/5e2fd20f9d720cde6f6cf7a4547115373b57a3a8)) * Update dependency google-cloud-storage to v2.5.0 ([#923](https://togithub.com/googleapis/java-language/issues/923)) ([fa6ec7b](https://togithub.com/googleapis/java-language/commit/fa6ec7b5f759f16d7ca9e420f46afa29cca859dd)) * Update dependency google-crc32c to v1.5.0 ([#924](https://togithub.com/googleapis/java-language/issues/924)) ([a400871](https://togithub.com/googleapis/java-language/commit/a40087156b32159f72ce3908ff1f77bfd2727a3a)) * Update dependency importlib-metadata to v4.12.0 ([#925](https://togithub.com/googleapis/java-language/issues/925)) ([7fa6782](https://togithub.com/googleapis/java-language/commit/7fa678217951ab0ab7729e082c1e2f43a6c294a2)) * Update dependency jeepney to v0.8.0 ([#926](https://togithub.com/googleapis/java-language/issues/926)) ([d52324e](https://togithub.com/googleapis/java-language/commit/d52324e86b8d192a5e2ff0ab7aa8c5209d93b112)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
…aenterprise to v3.0.11 (googleapis#924) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-recaptchaenterprise](https://togithub.com/googleapis/java-recaptchaenterprise) | `3.0.10` -> `3.0.12` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-recaptchaenterprise/3.0.12/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-recaptchaenterprise/3.0.12/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-recaptchaenterprise/3.0.12/compatibility-slim/3.0.10)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-recaptchaenterprise/3.0.12/confidence-slim/3.0.10)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-recaptchaenterprise). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTcuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxNy4wIn0=-->
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
…924) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.fasterxml.jackson:jackson-bom](https://togithub.com/FasterXML/jackson-bom) | `2.14.0` -> `2.14.1` | [![age](https://badges.renovateapi.com/packages/maven/com.fasterxml.jackson:jackson-bom/2.14.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.fasterxml.jackson:jackson-bom/2.14.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.fasterxml.jackson:jackson-bom/2.14.1/compatibility-slim/2.14.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.fasterxml.jackson:jackson-bom/2.14.1/confidence-slim/2.14.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-shared-dependencies). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yOS4yIiwidXBkYXRlZEluVmVyIjoiMzQuMjkuMiJ9-->
This issue follows up on #883. Some idempotent methods can report an exception when retries. This was observed for example within #808 and #816. The intuition is that there are cases when the socket connection reports a timeout while waiting for a server response. A subsequent retry then receives an error because the operation finished in the meantime.
We introduced a new attribute
rejected
in BaseServiceException which indicates if an error has been certainly refused by the server (for example when quota has been exceeded). We need to adjust error handling in all the modules to properly work withidempotent
andrejected
attributes. The discussion regarding create and delete operations in #883 should be kept in mind.We established that 500-type errors should not be treated as
rejected
because we cannot guarantee that the server did not process anything. We should assume that we can get a 500 while the request has been processed and committed on the service side.The text was updated successfully, but these errors were encountered: