Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [recommender] Support cost_in_local_currency field in the cost projection #10140

Merged
merged 3 commits into from
Jan 3, 2024
Merged

feat: [recommender] Support cost_in_local_currency field in the cost projection #10140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4dd6092
feat: Support cost_in_local_currency field in the cost projection
gcf-owl-bot[bot] Dec 12, 2023
dd4657e
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Dec 12, 2023
bab6d31
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions java-recommender/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ If you are using Maven with [BOM][libraries-bom], add this to your pom.xml file:
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>libraries-bom</artifactId>
<version>26.27.0</version>
<version>26.29.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand All @@ -42,20 +42,20 @@ If you are using Maven without the BOM, add this to your dependencies:
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-recommender</artifactId>
<version>2.33.0</version>
<version>2.34.0</version>
</dependency>
```

If you are using Gradle without BOM, add this to your dependencies:

```Groovy
implementation 'com.google.cloud:google-cloud-recommender:2.33.0'
implementation 'com.google.cloud:google-cloud-recommender:2.34.0'
```

If you are using SBT, add this to your dependencies:

```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-recommender" % "2.33.0"
libraryDependencies += "com.google.cloud" % "google-cloud-recommender" % "2.34.0"
```
<!-- {x-version-update-end} -->

Expand Down Expand Up @@ -195,7 +195,7 @@ Java is a registered trademark of Oracle and/or its affiliates.
[kokoro-badge-link-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/google-cloud-java/java11.html
[stability-image]: https://img.shields.io/badge/stability-stable-green
[maven-version-image]: https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-recommender.svg
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-recommender/2.32.0
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-recommender/2.34.0
[authentication]: https://github.com/googleapis/google-cloud-java#authentication
[auth-scopes]: https://developers.google.com/identity/protocols/oauth2/scopes
[predefined-iam-roles]: https://cloud.google.com/iam/docs/understanding-roles#predefined_roles
Expand Down
16 changes: 16 additions & 0 deletions ...le-cloud-recommender/src/main/java/com/google/cloud/recommender/v1/RecommenderClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,9 @@ public final ListRecommendationsPagedResponse listRecommendations(String parent)
* <ul>
* <li>`priority`
* </ul>
* <ul>
* <li>`targetResources`
* </ul>
* <p>Examples:
* <ul>
* <li>`stateInfo.state = ACTIVE OR stateInfo.state = DISMISSED`
Expand All @@ -857,8 +860,13 @@ public final ListRecommendationsPagedResponse listRecommendations(String parent)
* <li>`priority = P1 OR priority = P2`
* </ul>
* <ul>
* <li>`targetResources :
* //compute.googleapis.com/projects/1234/zones/us-central1-a/instances/instance-1`
* </ul>
* <ul>
* <li>`stateInfo.state = ACTIVE AND (priority = P1 OR priority = P2)`
* </ul>
* <p>The max allowed filter length is 500 characters.
* <p>(These expressions are based on the filter language described at
* https://google.aip.dev/160)
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
Expand Down Expand Up @@ -930,6 +938,9 @@ public final ListRecommendationsPagedResponse listRecommendations(
* <ul>
* <li>`priority`
* </ul>
* <ul>
* <li>`targetResources`
* </ul>
* <p>Examples:
* <ul>
* <li>`stateInfo.state = ACTIVE OR stateInfo.state = DISMISSED`
Expand All @@ -941,8 +952,13 @@ public final ListRecommendationsPagedResponse listRecommendations(
* <li>`priority = P1 OR priority = P2`
* </ul>
* <ul>
* <li>`targetResources :
* //compute.googleapis.com/projects/1234/zones/us-central1-a/instances/instance-1`
* </ul>
* <ul>
* <li>`stateInfo.state = ACTIVE AND (priority = P1 OR priority = P2)`
* </ul>
* <p>The max allowed filter length is 500 characters.
* <p>(These expressions are based on the filter language described at
* https://google.aip.dev/160)
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
Expand Down
Loading
Loading