Extend StorageExample to show how to add ACLs to blobs and buckets #1033

mziccard · 2016-05-31T15:00:18Z

This PR adds examples to StorageExample that show how to add different types of ACLs to existing blobs/buckets. This fixes #1012.

mziccard · 2016-05-31T15:54:49Z

/cc @lesv

coveralls · 2016-05-31T16:23:32Z

Coverage decreased (-0.007%) to 86.028% when pulling 6e859c9 on mziccard:storage-example into 11f4573 on GoogleCloudPlatform:master.

gcloud-java-examples/src/main/java/com/google/cloud/examples/storage/StorageExample.java

+  private abstract static class AclAction extends StorageAction<Tuple<BlobId, Acl>> {
+
+    @Override
+    public void run(Storage storage, Tuple<BlobId, Acl> params) {


lesv · 2016-06-01T20:48:27Z

Where do you expect this to be used?

If it's our formal docs, you are missing // [START sectionName] and // [END sectionName] tags.

Putting them in threads doesn't seem super clear, but that probably started before your time.

gcloud-java-examples/src/main/java/com/google/cloud/examples/storage/StorageExample.java

+  private static class AddGroupAclAction extends AclAction {
+
+    @Override
+    Tuple<BlobId, Acl> parse(String... args) {


mziccard · 2016-06-01T21:15:32Z

Where do you expect this to be used?
If it's our formal docs, you are missing // [START sectionName] and // [END sectionName] tags.

These examples don't go in the formal docs (AFAIK gcloud-java should not/will not go in the formal docs until v1.0.0 is out). We just reference them in our READMEs (see here for example).

Putting them in threads doesn't seem super clear, but that probably started before your time.

What do you mean with this?

gcloud-java-examples/src/main/java/com/google/cloud/examples/storage/StorageExample.java

+        }
+        String domain = args[nextArg++];
+        Acl.Role role = Acl.Role.valueOf(args[nextArg]);
+        return Tuple.of(blob, Acl.of(new Acl.Domain(domain), role));


lesv · 2016-06-07T15:12:23Z

I think you'll find that they will start being more in formal docs quickly.

lesv · 2016-06-07T15:14:13Z

I think there are a couple of AI's you agreed to above, do them, and it's ok to merge. I'll figure out what I want as next steps and write an issue for it.

coveralls · 2016-06-08T16:07:04Z

Coverage increased (+0.03%) to 86.065% when pulling 44cb081 on mziccard:storage-example into 11f4573 on GoogleCloudPlatform:master.

…#1033) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.18` -> `2.8.19` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.19/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.19/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.19/compatibility-slim/2.8.18)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.19/confidence-slim/2.8.18)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-intelligence).

🤖 I have created a release *beep* *boop* --- ## [2.2.11](https://togithub.com/googleapis/java-video-intelligence/compare/v2.2.10...v2.2.11) (2022-10-02) ### Dependencies * Update dependency com.google.cloud:google-cloud-core to v2.8.19 ([#1033](https://togithub.com/googleapis/java-video-intelligence/issues/1033)) ([824fc46](https://togithub.com/googleapis/java-video-intelligence/commit/824fc46f142727ae2bdbf4c7c819e5b809b3daa8)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…o v3.1.3 (#1033) * chore(deps): update dependency com.google.cloud:google-cloud-vision to v3.1.3 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

mziccard added docs api: storage Issues related to the Cloud Storage API. labels May 31, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 31, 2016

Extend StorageExample to show how to add ACLs to blobs and buckets

6e859c9

mziccard force-pushed the storage-example branch from f3d3be2 to 6e859c9 Compare May 31, 2016 15:26

lesv reviewed Jun 1, 2016
View reviewed changes

lesv reviewed Jun 7, 2016
View reviewed changes

gcloud-java-examples/src/main/java/com/google/cloud/examples/storage/StorageExample.java

}

String domain = args[nextArg++];

Acl.Role role = Acl.Role.valueOf(args[nextArg]);

return Tuple.of(blob, Acl.of(new Acl.Domain(domain), role));

This comment was marked as spam.

Sign in to view

Document AclAction and InfoAction run() methods

44cb081

mziccard merged commit f176d81 into googleapis:master Jun 8, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend StorageExample to show how to add ACLs to blobs and buckets #1033

Extend StorageExample to show how to add ACLs to blobs and buckets #1033

mziccard commented May 31, 2016

mziccard commented May 31, 2016

coveralls commented May 31, 2016

This comment was marked as spam.

This comment was marked as spam.

lesv commented Jun 1, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

mziccard commented Jun 1, 2016

This comment was marked as spam.

lesv commented Jun 7, 2016

lesv commented Jun 7, 2016

coveralls commented Jun 8, 2016

Extend StorageExample to show how to add ACLs to blobs and buckets #1033

Extend StorageExample to show how to add ACLs to blobs and buckets #1033

Conversation

mziccard commented May 31, 2016

mziccard commented May 31, 2016

coveralls commented May 31, 2016

This comment was marked as spam.

This comment was marked as spam.

lesv commented Jun 1, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

mziccard commented Jun 1, 2016

This comment was marked as spam.

lesv commented Jun 7, 2016

lesv commented Jun 7, 2016

coveralls commented Jun 8, 2016