Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: temp fix for failing unit teses in service management #10539

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

JoeWang1127
Copy link
Contributor

@JoeWang1127 JoeWang1127 commented Mar 13, 2024

In this PR:

  • Ignore failing unit tests in service management.

This is a temporary fix of googleapis/sdk-platform-java#1839.

Confirm the change can generate @Ignore annotation to failing tests:

pip install library_generation
python library_generation/generate_repo.py generate --generation-config-yaml="$(pwd)"/generation_config.yaml --target-library-api-shortname=servicemanagement

For simplicity, I copied library_generation directory in sdk-platform-java to my local google-cloud-java repo.

@JoeWang1127 JoeWang1127 marked this pull request as ready for review March 14, 2024 00:05
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner March 14, 2024 00:05
@JoeWang1127 JoeWang1127 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2024
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for writing the confirmation in the description.

@JoeWang1127 JoeWang1127 merged commit 890e241 into main Mar 14, 2024
31 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/temp-fix-ut branch March 14, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants