Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MonitoredResourceDescriptor class and tests #1062

Merged
merged 2 commits into from
Jul 4, 2016
Merged

Add MonitoredResourceDescriptor class and tests #1062

merged 2 commits into from
Jul 4, 2016

Conversation

mziccard
Copy link
Contributor

No description provided.

@mziccard mziccard added the api: logging Issues related to the Cloud Logging API. label Jun 19, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 19, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 83.897% when pulling c8be379 on mziccard:logging-resource-descriptor into 0edaca8 on GoogleCloudPlatform:logging-alpha.

@mziccard
Copy link
Contributor Author

/cc @lesv

@lesv
Copy link
Contributor

lesv commented Jun 20, 2016

LGTM

@mziccard mziccard added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 22, 2016
@mziccard
Copy link
Contributor Author

MonitoredResourceDescriptor and LabelDescriptor (as well as MonitoredResource) entities are also used in Stackdriver monitoring. We should move those classes to gcloud-java-core. This also means that conversion methods (toPb and fromPb) will have to become public.

@lesv
Copy link
Contributor

lesv commented Jun 22, 2016

Are any of the other (API's) toPb() / fromPb() public elsewhere?

@mziccard
Copy link
Contributor Author

Are any of the other (API's) toPb() / fromPb() public elsewhere?

No, they are all package scope. But to reuse these classes we might have no choice.

@lesv
Copy link
Contributor

lesv commented Jun 23, 2016

Sigh - SGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 84.1% when pulling ebe8c77 on mziccard:logging-resource-descriptor into 0edaca8 on GoogleCloudPlatform:logging-alpha.

@mziccard mziccard removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 1, 2016
@mziccard
Copy link
Contributor Author

mziccard commented Jul 1, 2016

@lesv I moved the classes to the core package, PTAL

@lesv
Copy link
Contributor

lesv commented Jul 1, 2016

LGTM

@mziccard mziccard merged commit 0bcca69 into googleapis:logging-alpha Jul 4, 2016
mziccard added a commit to mziccard/gcloud-java that referenced this pull request Jul 20, 2016
@mziccard
Add MonitoredResourceDescriptor class and tests (googleapis#1062)
b83bae7 
* Add MonitoredResourceDescriptor class and tests

* Move MonitoredResourceDescriptor to core module
suztomo pushed a commit that referenced this pull request Feb 1, 2023
@renovate-bot
deps: update dependency org.easymock:easymock to v5.1.0 (#1062)
6b6e8ed 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.easymock:easymock](http://easymock.org) ([source](https://togithub.com/easymock/easymock)) | `5.0.1` -> `5.1.0` | [![age](https://badges.renovateapi.com/packages/maven/org.easymock:easymock/5.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.easymock:easymock/5.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.easymock:easymock/5.1.0/compatibility-slim/5.0.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.easymock:easymock/5.1.0/confidence-slim/5.0.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mziccard @coveralls @lesv @googlebot