feat!: Remove orphaned protoc generated files from bigquerydatatransfer, monitoring and speech. #11148
Conversation
blakeli0
changed the title
blakeli0
changed the title
| @@ -20,52 +20,7 @@ deep-remove-regex: | |||
| - "/java-bigquerydatatransfer/samples/snippets/generated" | |||
|
|
|||
| deep-preserve-regex: | |||
| - "/java-bigquerydatatransfer/google-.*/src/test/java/com/google/cloud/.*/v.*/it/IT.*Test.java" | |||
There was a problem hiding this comment.
Do we want to delete this IT?
There was a problem hiding this comment.
There is actually no integration tests for bigquerydatatransfer, so this is like a not-directly-related clean up. I can revert this as well if it is causing confusion.
There was a problem hiding this comment.
Ah ok. If there are no ITs to being with then it doesn't matter. I'm fine with removing
| grpc-google-cloud-speech-v1beta1:2.44.0:2.45.0-SNAPSHOT | ||
| grpc-google-cloud-speech-v1p1beta1:2.44.0:2.45.0-SNAPSHOT | ||
| proto-google-cloud-speech-v1:4.44.0:4.45.0-SNAPSHOT | ||
| proto-google-cloud-speech-v1beta1:2.44.0:2.45.0-SNAPSHOT |
There was a problem hiding this comment.
qq, why are these two removed?
There was a problem hiding this comment.
For speech, the whole v1beta1 version does not exist anymore, see googleapis
There was a problem hiding this comment.
I can't really tell from the diffs on Github, but I'm guessing the entire subfolder is removed in this PR?
There was a problem hiding this comment.
Actually I think still see the folders in the branch. Can we just remove the folders in google-cloud-java?
There was a problem hiding this comment.
I think they should be removed already. Let's merge this in first, I'll create a follow up cleanup PR if the folders still exist.
There are some protoc generated files are not updated in over 3 years, which made them not compatible with latest protobuf runtime anymore. Since the source proto of these files are already deleted, we should delete them from our client library as well.
See go/incompatible-protoc-files-java-sdk for more details.