Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for customer-supplied encryption keys #1236

Merged
merged 2 commits into from
Sep 13, 2016

Conversation

mziccard
Copy link
Contributor

@mziccard mziccard commented Sep 9, 2016

This fixes #1037

@mziccard mziccard added the api: storage Issues related to the Cloud Storage API. label Sep 9, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 9, 2016
@mziccard
Copy link
Contributor Author

mziccard commented Sep 9, 2016

/cc @lesv

(I'll add some more tests to avoid this coverage drop)

@lesv
Copy link
Contributor

lesv commented Sep 9, 2016

LGTM - Thanks for this! Ping and I'll read the additional tests.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 84.985% when pulling b0b6aa0 on mziccard:storage-encryption-key into 4d5a86c on GoogleCloudPlatform:master.

@mziccard
Copy link
Contributor Author

@lesv I rebased on top of master and added more coverage.

@lesv
Copy link
Contributor

lesv commented Sep 12, 2016

LOL - coveralls says it decreased.

@lesv
Copy link
Contributor

lesv commented Sep 12, 2016

LGTM

@mziccard mziccard merged commit 470d948 into googleapis:master Sep 13, 2016
github-actions bot pushed a commit that referenced this pull request Jun 21, 2022
github-actions bot pushed a commit that referenced this pull request Sep 15, 2022
🤖 I have created a release *beep* *boop*
---


## [2.3.8](googleapis/java-automl@v2.3.7...v2.3.8) (2022-09-09)


### Dependencies

* Update dependency com.google.cloud:google-cloud-core to v2.8.11 ([#1234](googleapis/java-automl#1234)) ([810774b](googleapis/java-automl@810774b))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1235](googleapis/java-automl#1235)) ([c839ade](googleapis/java-automl@c839ade))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support customer-supplied encryption keys in Storage
4 participants