-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten URL and update logo #149
Shorten URL and update logo #149
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Errr, @aozarov , can we make sure that we....
? @ajkannan I know you're a Googler - but can you make sure that you've signed the CLA with your personal address or author your commits with your @google.com address...? |
@jgeewax we do follow that but I think in this case googlebot was wrong and I am not sure why. "ajkannan" git account was already associated with Google and prior PRs by the same account were marked as |
It's not about the github username -- git doesn't have that concept. GitHub's UI will turn an e-mail address into a username, but Googlebot can only see the e-mail address. That means... all commits either need to be with the @google.com username, or Ajay needs to sign the CLA with his @gmail.com account. Make sense? (Of course, I've lost context on this issue, so could be totally wrong here) |
@jgeewax I still don't quite understand why Googlebot said I didn't sign the CLA on this PR. I assume the email address that GH's UI gets is from my GH account "ajkannan" account, because I commit using that account and create PRs online from that account. As far as I can remember, I followed the same login process as I do for all my other PRs, just on my work laptop rather than my desktop. |
Can you show the full git log for the PR? That should show the email
address you used.... and then we can check if that email is on the list of
CLA signers.
|
Ah, it looks like the email was a special macbook email on the roaming corp network. I'll sign the CLA with that email address for future use. |
Or just edit your git config to the correct email address....?
|
Shorten URL and update logo
Shorten URL and update logo
Shorten URL and update logo
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/73acaa15-5a29-4a7c-8e53-614c4025c959/targets
…onfig to v1.5.2 (#149) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.5.1` -> `1.5.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.2/compatibility-slim/1.5.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.2/confidence-slim/1.5.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.5.2`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#​152-httpsgithubcomgoogleapisjava-shared-configcomparev151v152-2022-07-25) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.5.1...v1.5.2) ##### Dependencies - update dependency com.puppycrawl.tools:checkstyle to v10 ([#​435](https://togithub.com/googleapis/java-shared-config/issues/435)) ([bfc8ce1](https://togithub.com/googleapis/java-shared-config/commit/bfc8ce1deca6292147d002d3afe22a09840aa5d6)) - update dependency org.graalvm.buildtools:junit-platform-native to v0.9.13 ([#​488](https://togithub.com/googleapis/java-shared-config/issues/488)) ([39b91ee](https://togithub.com/googleapis/java-shared-config/commit/39b91ee1283f0a5fbbe63e8bfd1ec97ab4ab377e)) - update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.13 ([#​489](https://togithub.com/googleapis/java-shared-config/issues/489)) ([cc3bcfa](https://togithub.com/googleapis/java-shared-config/commit/cc3bcfa2d6717441a8d5b5048fa78c2cf7aabf2b)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-bigquerymigration). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjMyLjEyNy4wIn0=-->
🤖 I have created a release *beep* *boop* --- ## [1.1.4](googleapis/java-deploy@v1.1.3...v1.1.4) (2022-08-02) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#146](googleapis/java-deploy#146)) ([c544216](googleapis/java-deploy@c544216)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [1.3.3](googleapis/java-vmmigration@v1.3.2...v1.3.3) (2022-09-29) ### Dependencies * Update dependency cachetools to v5 ([#162](googleapis/java-vmmigration#162)) ([673c232](googleapis/java-vmmigration@673c232)) * Update dependency certifi to v2022.9.24 ([#142](googleapis/java-vmmigration#142)) ([40be099](googleapis/java-vmmigration@40be099)) * Update dependency charset-normalizer to v2.1.1 ([#146](googleapis/java-vmmigration#146)) ([c82b8bd](googleapis/java-vmmigration@c82b8bd)) * Update dependency click to v8.1.3 ([#147](googleapis/java-vmmigration#147)) ([99e10f7](googleapis/java-vmmigration@99e10f7)) * Update dependency gcp-releasetool to v1.8.8 ([#143](googleapis/java-vmmigration#143)) ([778f845](googleapis/java-vmmigration@778f845)) * Update dependency google-api-core to v2.10.1 ([#148](googleapis/java-vmmigration#148)) ([7b74afa](googleapis/java-vmmigration@7b74afa)) * Update dependency google-auth to v2.12.0 ([#149](googleapis/java-vmmigration#149)) ([6585870](googleapis/java-vmmigration@6585870)) * Update dependency google-cloud-core to v2.3.2 ([#144](googleapis/java-vmmigration#144)) ([cb815f8](googleapis/java-vmmigration@cb815f8)) * Update dependency google-cloud-storage to v2.5.0 ([#150](googleapis/java-vmmigration#150)) ([89e854a](googleapis/java-vmmigration@89e854a)) * Update dependency google-crc32c to v1.5.0 ([#151](googleapis/java-vmmigration#151)) ([dc88700](googleapis/java-vmmigration@dc88700)) * Update dependency googleapis-common-protos to v1.56.4 ([#145](googleapis/java-vmmigration#145)) ([5c8312d](googleapis/java-vmmigration@5c8312d)) * Update dependency importlib-metadata to v4.12.0 ([#152](googleapis/java-vmmigration#152)) ([c4ffddc](googleapis/java-vmmigration@c4ffddc)) * Update dependency jeepney to v0.8.0 ([#153](googleapis/java-vmmigration#153)) ([d84c437](googleapis/java-vmmigration@d84c437)) * Update dependency jinja2 to v3.1.2 ([#154](googleapis/java-vmmigration#154)) ([6682d82](googleapis/java-vmmigration@6682d82)) * Update dependency keyring to v23.9.3 ([#155](googleapis/java-vmmigration#155)) ([3d1a2d6](googleapis/java-vmmigration@3d1a2d6)) * Update dependency markupsafe to v2.1.1 ([#156](googleapis/java-vmmigration#156)) ([5666a1e](googleapis/java-vmmigration@5666a1e)) * Update dependency protobuf to v3.20.2 ([#157](googleapis/java-vmmigration#157)) ([e422694](googleapis/java-vmmigration@e422694)) * Update dependency protobuf to v4 ([#163](googleapis/java-vmmigration#163)) ([39884b8](googleapis/java-vmmigration@39884b8)) * Update dependency pyjwt to v2.5.0 ([#158](googleapis/java-vmmigration#158)) ([af206d0](googleapis/java-vmmigration@af206d0)) * Update dependency requests to v2.28.1 ([#159](googleapis/java-vmmigration#159)) ([83eb4d1](googleapis/java-vmmigration@83eb4d1)) * Update dependency typing-extensions to v4.3.0 ([#160](googleapis/java-vmmigration#160)) ([9d2cf45](googleapis/java-vmmigration@9d2cf45)) * Update dependency zipp to v3.8.1 ([#161](googleapis/java-vmmigration#161)) ([1ad1a9c](googleapis/java-vmmigration@1ad1a9c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This PR creates a simpler link (without "site/latest" in the URL) for other gcloud language sites to link to gcloud-java landing page. This PR also updates the logo on the current homepage to reflect the new svg logo.
The home page will look like this after the changes: