-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make getProjectId()
supports GAE
#1726
Conversation
google-cloud-core/pom.xml
Outdated
<groupId>com.google.appengine</groupId> | ||
<artifactId>appengine-api-1.0-sdk</artifactId> | ||
<version>1.9.50</version> | ||
</dependency> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@garrettjonesgoogle I have reverted the change and improve the error message. PTAL |
} catch (Exception exception) { | ||
if (System.getProperty("com.google.appengine.runtime.version") != null) { | ||
// Could not resolve appengine classes under GAE environment. | ||
throw new RuntimeException("Unable to resolve appengine classes. Missing dependency."); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Changes Unknown when pulling 6438385 on shinfan:master into ** on GoogleCloudPlatform:master**. |
PTAL |
APPENGINE.md
Outdated
---------- | ||
This file provides extra instructions to setup Google Cloud Java client with GoogleAppEngine. | ||
See [Quickstart](./README.md#quickstart) for Google Cloud Java common instructions. | ||
See [Quickstart](https://cloud.google.com/appengine/docs/standard/java/quickstart) for extra GAE instructions. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
README.md
Outdated
@@ -57,6 +57,8 @@ If you are using SBT, add this to your dependencies | |||
libraryDependencies += "com.google.cloud" % "google-cloud" % "0.9.4-alpha" | |||
``` | |||
|
|||
For GoogleAppEngine use case, see [more instructions here](./APPENGINE.md). |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
APPENGINE.md
Outdated
@@ -0,0 +1,31 @@ | |||
Use Google Cloud Java Client with GoogleAppEngine |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
APPENGINE.md
Outdated
Quickstart | ||
---------- | ||
This file provides extra instructions to setup Google Cloud Java client with GoogleAppEngine. | ||
See [Quickstart](./README.md#quickstart) for Google Cloud Java common instructions. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
APPENGINE.md
Outdated
|
||
Quickstart | ||
---------- | ||
This file provides extra instructions to setup Google Cloud Java client with GoogleAppEngine. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Changes Unknown when pulling 37fe816 on shinfan:master into ** on GoogleCloudPlatform:master**. |
Changes Unknown when pulling 37fe816 on shinfan:master into ** on GoogleCloudPlatform:master**. |
PTAL |
APPENGINE.md
Outdated
---------- | ||
This file provides extra instructions to set up Google Cloud Java Client with Google App Engine. | ||
See [Quickstart](./README.md#quickstart) for general instructions on using Google Cloud Java. | ||
See [Instructions](https://cloud.google.com/appengine/docs/standard/java/quickstart) for extra Google App Engine instructions. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
} catch (Exception exception) { | ||
if (System.getProperty("com.google.appengine.runtime.version") != null) { | ||
// Could not resolve appengine classes under GAE environment. | ||
throw new UnsupportedOperationException("Unable to resolve appengine-sdk classes. " |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Changes Unknown when pulling 977ec60 on shinfan:master into ** on GoogleCloudPlatform:master**. |
Changes Unknown when pulling 977ec60 on shinfan:master into ** on GoogleCloudPlatform:master**. |
Changes Unknown when pulling 977ec60 on shinfan:master into ** on GoogleCloudPlatform:master**. |
PTAL |
if (System.getProperty("com.google.appengine.runtime.version") != null) { | ||
// Could not resolve appengine classes under GAE environment. | ||
throw new RuntimeException("Unable to resolve appengine-sdk classes. " | ||
+ "For more details see " |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@garrettjonesgoogle PTAL |
LGTM |
Changes Unknown when pulling 7a65a30 on shinfan:master into ** on GoogleCloudPlatform:master**. |
Changes Unknown when pulling 7a65a30 on shinfan:master into ** on GoogleCloudPlatform:master**. |
Changes Unknown when pulling 5881706 on shinfan:master into ** on GoogleCloudPlatform:master**. |
Changes Unknown when pulling 5881706 on shinfan:master into ** on GoogleCloudPlatform:master**. |
Has it been tested in prod?
With java7 and the new Java8 standard runtime?
Ping me if you want access.
Ludo
…On Mar 13, 2017 12:40, "Coveralls" ***@***.***> wrote:
[image: Coverage Status] <https://coveralls.io/builds/10570688>
Changes Unknown when pulling *5881706
<5881706>
on shinfan:master* into ** on GoogleCloudPlatform:master**.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1726 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAE4zbdVJCRr5PHBQmiIG-uKS-IkVjv-ks5rlZuwgaJpZM4MYmUu>
.
|
@ludoch I have tested this end-to-end on my local machine. I am happy to test it in prod if you gave me the access. |
Fixes #1500