Make `getProjectId()` supports GAE #1726

shinfan · 2017-03-09T20:34:53Z

Testing:
- Local sample app on GAE
- Local gcloud logging sample app on gRPC (throws CallNotFoundException)

google-cloud-core/pom.xml

+      <groupId>com.google.appengine</groupId>
+      <artifactId>appengine-api-1.0-sdk</artifactId>
+      <version>1.9.50</version>
+    </dependency>


shinfan · 2017-03-10T00:55:24Z

@garrettjonesgoogle I have reverted the change and improve the error message. PTAL

google-cloud-core/src/main/java/com/google/cloud/ServiceOptions.java

+    } catch (Exception exception) {
+      if (System.getProperty("com.google.appengine.runtime.version") != null) {
+        // Could not resolve appengine classes under GAE environment.
+        throw new RuntimeException("Unable to resolve appengine classes. Missing dependency.");


coveralls · 2017-03-10T01:38:04Z

Changes Unknown when pulling 6438385 on shinfan:master into ** on GoogleCloudPlatform:master**.

shinfan · 2017-03-11T00:52:13Z

PTAL

APPENGINE.md

+----------
+This file provides extra instructions to setup Google Cloud Java client with GoogleAppEngine.
+See [Quickstart](./README.md#quickstart) for Google Cloud Java common instructions.
+See [Quickstart](https://cloud.google.com/appengine/docs/standard/java/quickstart) for extra GAE instructions.


README.md

@@ -57,6 +57,8 @@ If you are using SBT, add this to your dependencies
 libraryDependencies += "com.google.cloud" % "google-cloud" % "0.9.4-alpha"
 ```

+For GoogleAppEngine use case, see [more instructions here](./APPENGINE.md).


APPENGINE.md

@@ -0,0 +1,31 @@
+Use Google Cloud Java Client with GoogleAppEngine


APPENGINE.md

+Quickstart
+----------
+This file provides extra instructions to setup Google Cloud Java client with GoogleAppEngine.
+See [Quickstart](./README.md#quickstart) for Google Cloud Java common instructions.


APPENGINE.md

+
+Quickstart
+----------
+This file provides extra instructions to setup Google Cloud Java client with GoogleAppEngine.


coveralls · 2017-03-11T01:06:49Z

Changes Unknown when pulling 37fe816 on shinfan:master into ** on GoogleCloudPlatform:master**.

coveralls · 2017-03-11T01:06:49Z

Changes Unknown when pulling 37fe816 on shinfan:master into ** on GoogleCloudPlatform:master**.

shinfan · 2017-03-13T17:50:28Z

PTAL

APPENGINE.md

+----------
+This file provides extra instructions to set up Google Cloud Java Client with Google App Engine.
+See [Quickstart](./README.md#quickstart) for general instructions on using Google Cloud Java.
+See [Instructions](https://cloud.google.com/appengine/docs/standard/java/quickstart) for extra Google App Engine instructions.


google-cloud-core/src/main/java/com/google/cloud/ServiceOptions.java

+    } catch (Exception exception) {
+      if (System.getProperty("com.google.appengine.runtime.version") != null) {
+        // Could not resolve appengine classes under GAE environment.
+        throw new UnsupportedOperationException("Unable to resolve appengine-sdk classes. "


coveralls · 2017-03-13T18:34:35Z

Changes Unknown when pulling 977ec60 on shinfan:master into ** on GoogleCloudPlatform:master**.

coveralls · 2017-03-13T18:36:43Z

Changes Unknown when pulling 977ec60 on shinfan:master into ** on GoogleCloudPlatform:master**.

coveralls · 2017-03-13T18:36:43Z

Changes Unknown when pulling 977ec60 on shinfan:master into ** on GoogleCloudPlatform:master**.

shinfan · 2017-03-13T18:38:37Z

PTAL

google-cloud-core/src/main/java/com/google/cloud/ServiceOptions.java

+      if (System.getProperty("com.google.appengine.runtime.version") != null) {
+        // Could not resolve appengine classes under GAE environment.
+        throw new RuntimeException("Unable to resolve appengine-sdk classes. "
+            + "For more details see "


shinfan · 2017-03-13T18:55:06Z

@garrettjonesgoogle PTAL

garrettjonesgoogle · 2017-03-13T18:55:21Z

LGTM

coveralls · 2017-03-13T19:21:59Z

Changes Unknown when pulling 7a65a30 on shinfan:master into ** on GoogleCloudPlatform:master**.

coveralls · 2017-03-13T19:25:09Z

Changes Unknown when pulling 7a65a30 on shinfan:master into ** on GoogleCloudPlatform:master**.

coveralls · 2017-03-13T19:30:16Z

Changes Unknown when pulling 5881706 on shinfan:master into ** on GoogleCloudPlatform:master**.

coveralls · 2017-03-13T19:40:31Z

Changes Unknown when pulling 5881706 on shinfan:master into ** on GoogleCloudPlatform:master**.

ludoch · 2017-03-13T19:43:42Z

Has it been tested in prod? With java7 and the new Java8 standard runtime? Ping me if you want access. Ludo

…

On Mar 13, 2017 12:40, "Coveralls" ***@***.***> wrote: [image: Coverage Status] <https://coveralls.io/builds/10570688> Changes Unknown when pulling *5881706 <5881706> on shinfan:master* into ** on GoogleCloudPlatform:master**. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1726 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAE4zbdVJCRr5PHBQmiIG-uKS-IkVjv-ks5rlZuwgaJpZM4MYmUu> .

shinfan · 2017-03-13T19:50:14Z

@ludoch I have tested this end-to-end on my local machine. I am happy to test it in prod if you gave me the access.

shinfan added api: core running on app engine Status: Release Blocking labels Mar 9, 2017

shinfan requested review from garrettjonesgoogle and michaelbausor March 9, 2017 20:34

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 9, 2017

garrettjonesgoogle reviewed Mar 9, 2017

View reviewed changes

google-cloud-core/pom.xml Outdated

<groupId>com.google.appengine</groupId>

<artifactId>appengine-api-1.0-sdk</artifactId>

<version>1.9.50</version>

</dependency>

This comment was marked as spam.

Sign in to view

Improve error msg

6438385

shinfan force-pushed the master branch from 60c20aa to 6438385 Compare March 10, 2017 00:53

garrettjonesgoogle reviewed Mar 10, 2017

View reviewed changes

shinfan added 2 commits March 10, 2017 16:49

Update PR comment. Add README file

f095181

edit APPENGINE.md

37fe816

garrettjonesgoogle reviewed Mar 11, 2017

View reviewed changes

shinfan added 3 commits March 13, 2017 10:46

Fix comments

5773ec8

Revert

19655bf

Add space

977ec60

garrettjonesgoogle reviewed Mar 13, 2017

View reviewed changes

Fix comments

3862e96

shinfan added 3 commits March 13, 2017 11:37

Add new lines

c113bb2

Update

30ea628

Remove imports

7a65a30

garrettjonesgoogle reviewed Mar 13, 2017

View reviewed changes

Fix PR comments

5881706

shinfan merged commit 7a310c4 into googleapis:master Mar 13, 2017

		@@ -0,0 +1,31 @@
		Use Google Cloud Java Client with GoogleAppEngine

Make getProjectId() supports GAE #1726

Make getProjectId() supports GAE #1726

Conversation

shinfan commented Mar 9, 2017 • edited Loading

This comment was marked as spam.

shinfan commented Mar 10, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Mar 10, 2017

shinfan commented Mar 11, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Mar 11, 2017

coveralls commented Mar 11, 2017

shinfan commented Mar 13, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Mar 13, 2017

coveralls commented Mar 13, 2017

coveralls commented Mar 13, 2017

shinfan commented Mar 13, 2017

This comment was marked as spam.

This comment was marked as spam.

shinfan commented Mar 13, 2017

garrettjonesgoogle commented Mar 13, 2017

coveralls commented Mar 13, 2017

coveralls commented Mar 13, 2017

coveralls commented Mar 13, 2017

coveralls commented Mar 13, 2017

ludoch commented Mar 13, 2017 via email

shinfan commented Mar 13, 2017

Make `getProjectId()` supports GAE #1726

Make `getProjectId()` supports GAE #1726

shinfan commented Mar 9, 2017 •

edited

Loading