logging: update from proto #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #481. Changes are mostly comments so this should be straight forward. The only non-comment change is the addition of smoke test. Are we OK merging this into the repo?
googlebot
added
the
cla: yes
|
Remove the smoke test from the PR. Currently we always have to manually do this; we still have to fix the code generation process so that it doesn't put the smoke test here. |
|
LGTM |
|
Changes Unknown when pulling fd19049 on pongad:logging-through-method into ** on GoogleCloudPlatform:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #481.
Changes are mostly comments so this should be straight forward.
The only non-comment change is the addition of smoke test.
Are we OK merging this into the repo?