Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding dependency convergence #1943

Merged
merged 1 commit into from
Apr 19, 2017
Merged

Adding dependency convergence #1943

merged 1 commit into from
Apr 19, 2017

Conversation

garrettjonesgoogle
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle commented Apr 19, 2017 •
edited
Loading

I mostly based this on https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1659/files , but with the most up-to-date versions.

Fixes #1803

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 19, 2017
@garrettjonesgoogle garrettjonesgoogle mentioned this pull request Apr 19, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.851% when pulling 859707d on garrettjonesgoogle:alt2 into 67af4bf on GoogleCloudPlatform:master.

@michaelbausor
Copy link
Contributor

LGTM

@garrettjonesgoogle garrettjonesgoogle merged commit 87924c8 into googleapis:master Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbausor michaelbausor Awaiting requested review from michaelbausor

@vam-google vam-google Awaiting requested review from vam-google

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garrettjonesgoogle @coveralls @michaelbausor @googlebot