Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a snippet to show how to read a newline-delimited-json file and store it in a Table #2974

Merged
merged 8 commits into from
Mar 12, 2018
Merged

Added a snippet to show how to read a newline-delimited-json file and store it in a Table #2974

merged 8 commits into from
Mar 12, 2018

Conversation

happyhuman
Copy link

No description provided.

@happyhuman happyhuman requested a review from pongad as a code owner February 28, 2018 18:48
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 28, 2018
pongad
pongad reviewed Mar 1, 2018
View reviewed changes
...oud-examples/src/main/java/com/google/cloud/examples/bigquery/snippets/BigQuerySnippets.java Outdated
.build();
// Table field definition
ArrayList<Field> fields = new ArrayList<>();
for (String fieldName: fieldNames) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

...oud-examples/src/main/java/com/google/cloud/examples/bigquery/snippets/BigQuerySnippets.java Outdated
fields.add(Field.of(fieldName, LegacySQLTypeName.STRING));
}
// Table schema definition
Schema schema = Schema.of(fields.toArray(new Field[fields.size()]));

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pongad pongad requested a review from tswast March 1, 2018 03:24
tswast
tswast suggested changes Mar 1, 2018
View reviewed changes
...oud-examples/src/main/java/com/google/cloud/examples/bigquery/snippets/BigQuerySnippets.java Outdated
Schema schema = Schema.of(fields.toArray(new Field[fields.size()]));
// Create the table
StandardTableDefinition tableDefinition = StandardTableDefinition.of(schema);
bigquery.create(TableInfo.of(tableId, tableDefinition));

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

...oud-examples/src/main/java/com/google/cloud/examples/bigquery/snippets/BigQuerySnippets.java Outdated
// [TARGET writer(WriteChannelConfiguration)]
// [VARIABLE "my_dataset_name"]
// [VARIABLE "my_table_name"]
// [VARIABLE "my_source_uri")]

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

...oud-examples/src/main/java/com/google/cloud/examples/bigquery/snippets/BigQuerySnippets.java Outdated
// [VARIABLE "my_dataset_name"]
// [VARIABLE "my_table_name"]
// [VARIABLE "my_source_uri")]
// [VARIABLE "field_names")]

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@happyhuman
Copy link
Author

After talking to Tim, I made some changes. Can you please review the changes? Thanks.

tswast
tswast reviewed Mar 6, 2018
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample LGTM, thanks.

@tswast
Copy link
Contributor

tswast commented Mar 6, 2018

Sorry I forgot about this earlier, but there's also a Python script to run which will ensure this sample gets included in the Javadocs for the library. The script is at https://github.com/GoogleCloudPlatform/google-cloud-java/blob/master/utilities/add_snippets_to_file.py

tswast
tswast reviewed Mar 9, 2018
View reviewed changes
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQuery.java Outdated
@@ -524,6 +524,19 @@ public int hashCode() {
* }
* } </pre>
*
* <p>Example of creating a dataset.

This comment was marked as spam.

Sign in to view

tswast
tswast reviewed Mar 9, 2018
View reviewed changes
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQuery.java Outdated
* String query =
* "SELECT distinct(corpus) FROM `bigquery-public-data.samples.shakespeare` where word_count > ?";
* <pre> {@code
* String query = "SELECT distinct(corpus) FROM `bigquery-public-data.samples.shakespeare` where;

This comment was marked as spam.

Sign in to view

tswast
tswast approved these changes Mar 9, 2018
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Let's clean up some of the Javadoc strings in BigQuery.java manually and call this one done. I don't know what went wrong with the script.

@pongad pongad merged commit 848245e into master Mar 12, 2018
@pongad pongad deleted the bq_remote_file_import branch March 12, 2018 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pongad pongad pongad left review comments

@tswast tswast tswast approved these changes

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

Assignees

@garrettjonesgoogle garrettjonesgoogle

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@happyhuman @tswast @pongad @googlebot @garrettjonesgoogle