Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing warn log message #3011

Merged
merged 5 commits into from
Mar 11, 2018
Merged

Fixing warn log message #3011

merged 5 commits into from
Mar 11, 2018

Conversation

pgbhagat
Copy link

@pgbhagat pgbhagat commented Mar 8, 2018

Fixing warn log message

Fixing warn log message
@pgbhagat pgbhagat requested a review from pongad as a code owner March 8, 2018 12:05
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Mar 8, 2018
@pgbhagat
Copy link
Author

pgbhagat commented Mar 8, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 8, 2018
Copy link
Contributor

@pongad pongad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@@ -169,7 +169,7 @@ private TranslateOptions(Builder builder) {
logger.log(
Level.WARNING,
String.format(
"Ignoring Application Default Credentials: using explicit setting for API key instead.",
"Ignoring Application Default Credentials %s: using explicit setting for API key instead.",

This comment was marked as spam.

This comment was marked as spam.

}
} else if (builder.apiKey != null) {
credentials = null;
apiKey = builder.apiKey;
logger.log(
Level.WARNING,
String.format(
"Ignoring Application Default Credentials: using explicit setting for API key instead.",

This comment was marked as spam.

@pongad
Copy link
Contributor

pongad commented Mar 9, 2018

@pgbhagat Gah, I'm sorry. The format string should have been {0}, not {}. I was thinking in Python. LGTM otherwise. I apologize for the churn.

@pgbhagat
Copy link
Author

pgbhagat commented Mar 9, 2018

No problem, i checked other files and it is used like {0}. Corrected in the next commit.

@pgbhagat
Copy link
Author

pgbhagat commented Mar 9, 2018

Is the AppVeyor build is failing because of
'Build execution time has reached the maximum allowed time for your plan (60 minutes).' ?

@pongad pongad merged commit a21cc36 into googleapis:master Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants