Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: remove polling implementation #3040

Merged
merged 1 commit into from
Mar 14, 2018
Merged

pubsub: remove polling implementation #3040

merged 1 commit into from
Mar 14, 2018

Conversation

pongad
Copy link
Contributor

@pongad pongad commented Mar 14, 2018

There has been no way to use it since Aug 2017
and removing it will make moving the GAPIC stub easier.

@pongad
pubsub: remove polling implementation
45037c2 
There has been no way to use it since Aug 2017
and removing it will make moving the GAPIC stub easier.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2018
garrettjonesgoogle
garrettjonesgoogle approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pongad pongad merged commit d70feec into googleapis:master Mar 14, 2018
@pongad pongad deleted the sub-rm-poll branch March 14, 2018 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle approved these changes

@yihanzhen yihanzhen yihanzhen approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pongad @garrettjonesgoogle @yihanzhen @googlebot