Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow services to avoid setting project ID #346

Merged
merged 2 commits into from
Nov 10, 2015
Merged

Allow services to avoid setting project ID #346

merged 2 commits into from
Nov 10, 2015

Conversation

ajkannan
Copy link

This PR makes setting the project ID optional for service libraries that don't require a project ID (such as Resource Manager).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 10, 2015
aozarov
aozarov reviewed Nov 10, 2015
View reviewed changes
gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java
*
* @return true if a project ID is required to use the service, false if not.
*/
public boolean projectIdRequired() {

This comment was marked as spam.

Sign in to view

@ajkannan
Copy link
Author

@aozarov updated to make method protected

aozarov
aozarov reviewed Nov 10, 2015
View reviewed changes
gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java
projectId = checkNotNull(builder.projectId != null ? builder.projectId : defaultProject());
projectId = builder.projectId != null ? builder.projectId : defaultProject();
if (projectIdRequired()) {
checkNotNull(projectId);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Make projectIdRequired() method protected. Also supply nice error mes…
6c40825 
…sage if project could not be determined and is required
@ajkannan ajkannan force-pushed the project-id-optional branch from 4bbc9e8 to 6c40825 Compare November 10, 2015 23:39
aozarov added a commit that referenced this pull request Nov 10, 2015
@aozarov
Merge pull request #346 from ajkannan/project-id-optional
ed1d437 
Allow services to avoid setting project ID
@aozarov aozarov merged commit ed1d437 into googleapis:master Nov 10, 2015
@ajkannan ajkannan deleted the project-id-optional branch November 10, 2015 23:52
github-actions bot pushed a commit that referenced this pull request Jun 23, 2022
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-shared-dependen…
adbd804 
…cies to v2.13.0 (#346)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-shared-dependencies](https://togithub.com/googleapis/java-shared-dependencies) | `2.12.0` -> `2.13.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.13.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.13.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.13.0/compatibility-slim/2.12.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.13.0/confidence-slim/2.12.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-shared-dependencies</summary>

### [`v2.13.0`](https://togithub.com/googleapis/java-shared-dependencies/blob/HEAD/CHANGELOG.md#&#8203;2130-httpsgithubcomgoogleapisjava-shared-dependenciescomparev2120v2130-2022-06-22)

[Compare Source](https://togithub.com/googleapis/java-shared-dependencies/compare/v2.12.0...v2.13.0)

##### Dependencies

-   update dependency com.google.api-client:google-api-client-bom to v1.35.0 ([#&#8203;709](https://togithub.com/googleapis/java-shared-dependencies/issues/709)) ([239f8c3](https://togithub.com/googleapis/java-shared-dependencies/commit/239f8c33a11e233e6af79aee8c7e68cd156a0554))
-   update dependency com.google.api-client:google-api-client-bom to v1.35.1 ([#&#8203;713](https://togithub.com/googleapis/java-shared-dependencies/issues/713)) ([6559b45](https://togithub.com/googleapis/java-shared-dependencies/commit/6559b45b027dba783a9525d35e32183d78773cbe))
-   update dependency com.google.api:api-common to v2.2.1 ([#&#8203;710](https://togithub.com/googleapis/java-shared-dependencies/issues/710)) ([650d4c5](https://togithub.com/googleapis/java-shared-dependencies/commit/650d4c5f8c3cfce711257d47280ad773cd2e2414))
-   update dependency com.google.errorprone:error_prone_annotations to v2.14.0 ([#&#8203;701](https://togithub.com/googleapis/java-shared-dependencies/issues/701)) ([d24730f](https://togithub.com/googleapis/java-shared-dependencies/commit/d24730f78669f80b109e590b903446e5552e3e36))
-   update dependency com.google.http-client:google-http-client-bom to v1.42.0 ([#&#8203;711](https://togithub.com/googleapis/java-shared-dependencies/issues/711)) ([5168a18](https://togithub.com/googleapis/java-shared-dependencies/commit/5168a181722128d434a0d0d2ab5cc485686bbc78))
-   update dependency com.google.oauth-client:google-oauth-client-bom to v1.34.0 ([#&#8203;708](https://togithub.com/googleapis/java-shared-dependencies/issues/708)) ([620336e](https://togithub.com/googleapis/java-shared-dependencies/commit/620336e6733e2017116e5e8a7b403b183a728bc1))
-   update dependency com.google.oauth-client:google-oauth-client-bom to v1.34.1 ([#&#8203;712](https://togithub.com/googleapis/java-shared-dependencies/issues/712)) ([a2c18a5](https://togithub.com/googleapis/java-shared-dependencies/commit/a2c18a5bc4152cc9034cec691a29f54a35c38a51))
-   update dependency com.google.protobuf:protobuf-bom to v3.21.0 ([#&#8203;703](https://togithub.com/googleapis/java-shared-dependencies/issues/703)) ([5f9fe12](https://togithub.com/googleapis/java-shared-dependencies/commit/5f9fe1200b4bdf4c54bf947c21bd3ed02f26f990))
-   update dependency com.google.protobuf:protobuf-bom to v3.21.1 ([#&#8203;705](https://togithub.com/googleapis/java-shared-dependencies/issues/705)) ([c68edfb](https://togithub.com/googleapis/java-shared-dependencies/commit/c68edfbe7e1993e1112640b867b29aa2fbcf7579))
-   update dependency io.grpc:grpc-bom to v1.47.0 ([#&#8203;707](https://togithub.com/googleapis/java-shared-dependencies/issues/707)) ([d02918a](https://togithub.com/googleapis/java-shared-dependencies/commit/d02918a0418cd65d1d247f27afb0637f1f8f5666))
-   update dependency org.checkerframework:checker-qual to v3.22.1 ([#&#8203;706](https://togithub.com/googleapis/java-shared-dependencies/issues/706)) ([545843b](https://togithub.com/googleapis/java-shared-dependencies/commit/545843b492cead230b8cc72a1dae7d4922f33b39))
-   update dependency org.checkerframework:checker-qual to v3.22.2 ([#&#8203;717](https://togithub.com/googleapis/java-shared-dependencies/issues/717)) ([142852a](https://togithub.com/googleapis/java-shared-dependencies/commit/142852a37140f221197f5c71aed451def353b1e0))
-   update gax.version to v2.18.2 ([#&#8203;718](https://togithub.com/googleapis/java-shared-dependencies/issues/718)) ([5f8156e](https://togithub.com/googleapis/java-shared-dependencies/commit/5f8156e55c6a07b018a8c5efafa68be781b4288b))
-   update google.common-protos.version to v2.9.0 ([#&#8203;714](https://togithub.com/googleapis/java-shared-dependencies/issues/714)) ([9e5591e](https://togithub.com/googleapis/java-shared-dependencies/commit/9e5591ec3035350450ecbfebd00e08216433b06c))
-   update google.core.version to v2.8.0 ([#&#8203;719](https://togithub.com/googleapis/java-shared-dependencies/issues/719)) ([4023c60](https://togithub.com/googleapis/java-shared-dependencies/commit/4023c6063a2c5b5308da531df1a08c90c491965d))
-   update iam.version to v1.4.0 ([#&#8203;700](https://togithub.com/googleapis/java-shared-dependencies/issues/700)) ([c1097a4](https://togithub.com/googleapis/java-shared-dependencies/commit/c1097a46ab0739b0b7234bc510e4c3d9ce2c2861))
-   update iam.version to v1.4.1 ([#&#8203;716](https://togithub.com/googleapis/java-shared-dependencies/issues/716)) ([e2dc7c2](https://togithub.com/googleapis/java-shared-dependencies/commit/e2dc7c21c39e007878841e2664d548ec44a72d54))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-accesscontextmanager).
github-actions bot pushed a commit that referenced this pull request Jun 23, 2022
@release-please
chore(main): release 1.3.1 (#348)
5f907cf 
🤖 I have created a release *beep* *boop*
---


## [1.3.1](googleapis/java-accesscontextmanager@v1.3.0...v1.3.1) (2022-06-23)


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#346](googleapis/java-accesscontextmanager#346)) ([adbd804](googleapis/java-accesscontextmanager@adbd804))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022
@renovate-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v16.…
ec550bc 
…2.1 (googleapis#346)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | patch | `16.2.0` -> `16.2.1` |

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-resourcemanager).
github-actions bot pushed a commit that referenced this pull request Jul 1, 2022
@SurferJeffAtGoogle @gcf-owl-bot
chore: relocate owl bot post processor (#346)
6801f5f 
* chore: relocate owl bot post processor

* chore: relocate owl bot post processor

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Aug 24, 2022
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-bigquery to v2.…
5e0de9e 
…14.7 (#346)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-bigquery](https://togithub.com/googleapis/java-bigquery) | `2.14.6` -> `2.14.7` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.14.7/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.14.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.14.7/compatibility-slim/2.14.6)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.14.7/confidence-slim/2.14.6)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-bigquery</summary>

### [`v2.14.7`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#&#8203;2147-httpsgithubcomgoogleapisjava-bigquerycomparev2146v2147-2022-08-23)

##### Bug Fixes

-   table-not-found issue with executeSelect while running long queries  ([#&#8203;2222](https://togithub.com/googleapis/java-bigquery/issues/2222)) ([4876569](https://togithub.com/googleapis/java-bigquery/commit/487656973fe3e06d838c1b495ac024ab2c6810f6))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-contact-center-insights).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE3My4wIn0=-->
This was referenced Aug 24, 2022
Closed
Closed
github-actions bot pushed a commit that referenced this pull request Sep 15, 2022
@release-please
chore(main): release 2.3.3 (#346)
5f1dd36 
🤖 I have created a release *beep* *boop*
---


## [2.3.3](googleapis/java-workflow-executions@v2.3.2...v2.3.3) (2022-09-09)


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#345](googleapis/java-workflow-executions#345)) ([2cfa42a](googleapis/java-workflow-executions@2cfa42a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Sep 15, 2022
@release-please
chore(main): release 3.7.5-SNAPSHOT (#346)
ed3d371 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request Sep 23, 2022
Closed
github-actions bot pushed a commit that referenced this pull request Oct 5, 2022
@release-please
chore(main): release 2.3.9 (#349)
62f7888 
🤖 I have created a release *beep* *boop*
---


## [2.3.9](https://togithub.com/googleapis/java-contact-center-insights/compare/v2.3.8...v2.3.9) (2022-10-04)


### Bug Fixes

* update protobuf to v3.21.7 ([4758cf0](https://togithub.com/googleapis/java-contact-center-insights/commit/4758cf035c2092ffc1f1cad1b3984a0344eb67d5))


### Documentation

* Updating comments ([#345](https://togithub.com/googleapis/java-contact-center-insights/issues/345)) ([ebadaa5](https://togithub.com/googleapis/java-contact-center-insights/commit/ebadaa5e44ded908d5517d12f52e193b70be2dda))


### Dependencies

* Update dependency certifi to v2022.9.24 ([#362](https://togithub.com/googleapis/java-contact-center-insights/issues/362)) ([5d1ce8b](https://togithub.com/googleapis/java-contact-center-insights/commit/5d1ce8bf7dd759b4019e4b189d8c2054384e919d))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 ([#341](https://togithub.com/googleapis/java-contact-center-insights/issues/341)) ([4456bd4](https://togithub.com/googleapis/java-contact-center-insights/commit/4456bd42500b1da5d427702c187f8e71140acd94))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 ([#346](https://togithub.com/googleapis/java-contact-center-insights/issues/346)) ([5e0de9e](https://togithub.com/googleapis/java-contact-center-insights/commit/5e0de9ec21b8eb55a4622ec2f018cd4bfd79b304))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 ([#348](https://togithub.com/googleapis/java-contact-center-insights/issues/348)) ([e1c52f6](https://togithub.com/googleapis/java-contact-center-insights/commit/e1c52f6fd766c918756f4045926b2a02c9478cba))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#353](https://togithub.com/googleapis/java-contact-center-insights/issues/353)) ([4744d87](https://togithub.com/googleapis/java-contact-center-insights/commit/4744d876764bc18f52e2c570f2c72a34b3ef1a53))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.16.1 ([#356](https://togithub.com/googleapis/java-contact-center-insights/issues/356)) ([3c860f8](https://togithub.com/googleapis/java-contact-center-insights/commit/3c860f8a0377fd88e344ad228835cc0ff932c41d))
* Update dependency com.google.cloud:google-cloud-pubsub to v1.120.12 ([#339](https://togithub.com/googleapis/java-contact-center-insights/issues/339)) ([4e329c4](https://togithub.com/googleapis/java-contact-center-insights/commit/4e329c4ee1d5072fcd2c48958a6d48576813bcdd))
* Update dependency com.google.cloud:google-cloud-pubsub to v1.120.13 ([#347](https://togithub.com/googleapis/java-contact-center-insights/issues/347)) ([45b3540](https://togithub.com/googleapis/java-contact-center-insights/commit/45b35403b2997ef8421e9573f050537812c61cea))
* Update dependency com.google.cloud:google-cloud-pubsub to v1.120.14 ([#352](https://togithub.com/googleapis/java-contact-center-insights/issues/352)) ([9fc2624](https://togithub.com/googleapis/java-contact-center-insights/commit/9fc2624a370c0bd81d7d88204830a162a41f0f23))
* Update dependency com.google.cloud:google-cloud-pubsub to v1.120.16 ([#354](https://togithub.com/googleapis/java-contact-center-insights/issues/354)) ([9b355ad](https://togithub.com/googleapis/java-contact-center-insights/commit/9b355ad24da4561a7e10b7a06dcb6bf57e4aa9a7))
* Update dependency com.google.cloud:google-cloud-pubsub to v1.120.17 ([#358](https://togithub.com/googleapis/java-contact-center-insights/issues/358)) ([7d2a878](https://togithub.com/googleapis/java-contact-center-insights/commit/7d2a8784bc7f0422831844f823a304f3bfda3192))
* Update dependency com.google.cloud:google-cloud-pubsub to v1.120.18 ([#359](https://togithub.com/googleapis/java-contact-center-insights/issues/359)) ([4e93e08](https://togithub.com/googleapis/java-contact-center-insights/commit/4e93e08c425b09ca35c977c5ea22f4c7b2538ae3))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#351](https://togithub.com/googleapis/java-contact-center-insights/issues/351)) ([c1e8dfa](https://togithub.com/googleapis/java-contact-center-insights/commit/c1e8dfa39db2d82f89401b0aa14a95dd1d2b00e1))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#355](https://togithub.com/googleapis/java-contact-center-insights/issues/355)) ([8a57045](https://togithub.com/googleapis/java-contact-center-insights/commit/8a57045112d9b905dc3edae8b9b01d25d3f1788d))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#368](https://togithub.com/googleapis/java-contact-center-insights/issues/368)) ([c8e9ca4](https://togithub.com/googleapis/java-contact-center-insights/commit/c8e9ca43bf90feacda4129e1ac2f26592c8ae47e))
* Update dependency gcp-releasetool to v1.8.8 ([#363](https://togithub.com/googleapis/java-contact-center-insights/issues/363)) ([22d1d6b](https://togithub.com/googleapis/java-contact-center-insights/commit/22d1d6bada56d263474b8550bf92b72f6bfc24ad))
* Update dependency google-auth to v2.11.1 ([#364](https://togithub.com/googleapis/java-contact-center-insights/issues/364)) ([04b3da7](https://togithub.com/googleapis/java-contact-center-insights/commit/04b3da765c19bd53b4d7c5dfa814d1dd450a480d))
* Update dependency google-cloud-core to v2.3.2 ([#365](https://togithub.com/googleapis/java-contact-center-insights/issues/365)) ([94a569f](https://togithub.com/googleapis/java-contact-center-insights/commit/94a569f7adb2f3c59a57d1428eb70ca17c52f827))
* Update dependency pyjwt to v2.5.0 ([#366](https://togithub.com/googleapis/java-contact-center-insights/issues/366)) ([96d97a8](https://togithub.com/googleapis/java-contact-center-insights/commit/96d97a8c1dbe616f48474949dc936503842b170e))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull request Feb 1, 2023
@release-please
chore(main): release 1.3.5-SNAPSHOT (#346)
f86ceba 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: core cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajkannan @aozarov @googlebot