Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 11 compatibility #3821

Merged
merged 9 commits into from
Nov 30, 2018
Prev Previous commit
Next Next commit
Fix service option test visibility
chingor13 committed Oct 16, 2018
commit 553d06cce99058e332c381d0a8456bc1d5055b73
Original file line number Diff line number Diff line change
@@ -171,7 +171,7 @@ public long millisTime() {
}
}

private interface TestService extends Service<TestServiceOptions> {}
interface TestService extends Service<TestServiceOptions> {}

private static class TestServiceImpl extends BaseService<TestServiceOptions>
implements TestService {
@@ -180,7 +180,7 @@ private TestServiceImpl(TestServiceOptions options) {
}
}

private interface TestServiceFactory extends ServiceFactory<TestService, TestServiceOptions> {}
interface TestServiceFactory extends ServiceFactory<TestService, TestServiceOptions> {}

private static class DefaultTestServiceFactory implements TestServiceFactory {
private static final TestServiceFactory INSTANCE = new DefaultTestServiceFactory();
@@ -191,7 +191,7 @@ public TestService create(TestServiceOptions options) {
}
}

private interface TestServiceRpcFactory
interface TestServiceRpcFactory
extends ServiceRpcFactory<TestServiceOptions> {}

private static class DefaultTestServiceRpcFactory implements TestServiceRpcFactory {
@@ -209,7 +209,7 @@ private static class DefaultTestServiceRpc implements TestServiceRpc {
DefaultTestServiceRpc(TestServiceOptions options) {}
}

private static class TestServiceOptions
static class TestServiceOptions
extends ServiceOptions<TestService, TestServiceOptions> {
private static class Builder
extends ServiceOptions.Builder<TestService, TestServiceOptions, Builder> {