-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate vision client #4161
Regenerate vision client #4161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of breaking changes here.
"projects/{project}/locations/{location}/products/{product}/referenceImages/{image}"); | ||
|
||
/** Formats a string containing the fully-qualified path to represent a location resource. */ | ||
public static final String formatLocationName(String project, String location) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@andreamlin, do you have any comments on this issue? |
Ok, found the reason for the removal of those functions: these One possible solution is to always print out these formatting functions; however this adds a lot of cruft to every other Java API library. Another possible solution is to mark these formatting functions as @BetaApi after the fact and mark them for turn down. We would expect that eventually, per API, all resource messages are configured and these formatting functions wouldn't be necessary. cc'ing @michaelbausor. This behavior was introduced years ago, in googleapis/gapic-generator#824. |
Hmm. Another option - we add an optional configuration into the Separate question - how do we expect the generator to behave when we move to the proto annotation config spec? |
@michaelbausor re: proto annotation spec; for new API client libs, we would never |
Opened gapic-generator issue to track this: googleapis/gapic-generator#2521. |
@michaelbausor @chingor13 Would it be possible to deprecate these functions (if/when a major version comes around)? I'm not sure what the use of them would be given that they are are only present when there are no messages that reference them. |
This should be fixed now, if synthtool is run again. My local regen: andreamlin#2 |
This PR was generated using Autosynth. 🌈
Here's the log from Synthtool: