Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set connect/read timeout when calling the metadata service #4413

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Set connect/read timeout when calling the metadata service #4413

merged 1 commit into from
Feb 8, 2019

Conversation

dmichel1
Copy link

Otherwise callers of these methods can be waiting indefinitely.

Fixes #4398

@dmichel1 dmichel1 requested a review from a team as a code owner January 26, 2019 18:11
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 26, 2019
@ajaaym ajaaym added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2019
@dmichel1
Copy link
Author

dmichel1 commented Feb 5, 2019

@ajaaym can you take a look at this pls?

@sduskis
Copy link
Contributor

sduskis commented Feb 7, 2019

@dmichel1, can you please run mvn com.coveo:fmt-maven-plugin:format so that your code complies with our code formatting rule?

@sduskis sduskis added the status: blocked Resolving the issue is dependent on other work. label Feb 7, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 7, 2019
@dmichel1
Set connect/read timeout when calling the metadata service
3a5fd6a 
Otherwise callers of these methods can be waiting indefinitely.

googleapis#4398
@dmichel1
Copy link
Author

dmichel1 commented Feb 8, 2019

@sduskis i rebased and pushed my code again - build should be passing.

@sduskis sduskis added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed status: blocked Resolving the issue is dependent on other work. labels Feb 8, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2019
@dmichel1
Copy link
Author

dmichel1 commented Feb 8, 2019

Unrelated IT tests are failing for this PR now.

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2019
@sduskis
Copy link
Contributor

sduskis commented Feb 8, 2019

I'll try to run the tests again, just to be sure.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2019
@dmichel1
Copy link
Author

dmichel1 commented Feb 8, 2019

@sduskis yaya they are passing now. thanks

@ajaaym ajaaym merged commit 44db769 into googleapis:master Feb 8, 2019
@JesseLovelace JesseLovelace mentioned this pull request Feb 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaaym ajaaym ajaaym approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dmichel1 @sduskis @ajaaym @googlebot @yoshi-automation @yoshi-kokoro