Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing joda #4471

Merged
merged 2 commits into from
Feb 12, 2019
Merged

Removing joda #4471

merged 2 commits into from
Feb 12, 2019

Conversation

sduskis
Copy link
Contributor

@sduskis sduskis commented Feb 8, 2019

Fixes #3482

@sduskis sduskis requested a review from a team as a code owner February 8, 2019 15:01
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2019
it looks like the examples were using joda, but there was not an explicit dependency in the pom.xml file.
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2019
@codecov
Copy link

codecov bot commented Feb 10, 2019

Codecov Report

Merging #4471 into master will decrease coverage by 0.01%.
The diff coverage is 94.49%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4471      +/-   ##
============================================
- Coverage     49.17%   49.15%   -0.02%     
- Complexity    20988    21907     +919     
============================================
  Files          1996     2078      +82     
  Lines        194629   207014   +12385     
  Branches      21796    24078    +2282     
============================================
+ Hits          95702   101767    +6065     
- Misses        90817    97108    +6291     
- Partials       8110     8139      +29
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/compute/deprecated/MachineType.java 96.46% <100%> (+0.19%) 27 <0> (ø) ⬇️
...m/google/cloud/compute/deprecated/AddressInfo.java 93.5% <100%> (+0.4%) 28 <0> (ø) ⬇️
...com/google/cloud/compute/deprecated/ImageInfo.java 95.86% <100%> (+0.1%) 26 <0> (ø) ⬇️
...m/google/cloud/compute/deprecated/NetworkInfo.java 95.06% <100%> (+0.18%) 19 <0> (ø) ⬇️
.../com/google/cloud/compute/deprecated/DiskInfo.java 96.5% <100%> (+0.91%) 29 <0> (ø) ⬇️
...java/com/google/cloud/compute/deprecated/Zone.java 93.75% <100%> (+0.2%) 26 <0> (ø) ⬇️
.../google/cloud/compute/deprecated/SnapshotInfo.java 96.59% <100%> (+0.11%) 29 <0> (ø) ⬇️
.../google/cloud/compute/deprecated/InstanceInfo.java 95.21% <100%> (+0.19%) 34 <0> (ø) ⬇️
...va/com/google/cloud/compute/deprecated/Region.java 88.97% <100%> (+0.16%) 29 <0> (ø) ⬇️
...com/google/cloud/compute/deprecated/Operation.java 88.23% <100%> (+0.12%) 50 <1> (ø) ⬇️
... and 1614 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb2bb7c...f9e7d28. Read the comment docs.

@sduskis sduskis merged commit 4e4ce6c into googleapis:master Feb 12, 2019
@sduskis sduskis deleted the remove_joda branch April 22, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants