-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigQuery: Fix timestamp parsing regression #4510
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4510 +/- ##
============================================
- Coverage 49.16% 49.14% -0.02%
+ Complexity 21929 21927 -2
============================================
Files 2077 2078 +1
Lines 207074 207184 +110
Branches 24097 24106 +9
============================================
+ Hits 101801 101815 +14
- Misses 97100 97196 +96
Partials 8173 8173
Continue to review full report at Codecov.
|
@@ -60,6 +62,21 @@ | |||
@AutoValue | |||
public abstract class QueryParameterValue implements Serializable { | |||
|
|||
private static final DateTimeFormatter timestampValidator = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we replace timestampFormatter
with your configuration for timestampValidator
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can't be done with single formatter.
7700632
to
2387727
Compare
Fixes #4500