-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor BasePageFetcher #517
Conversation
* Base class for page fetchers. | ||
* | ||
* @param <T> the value type that the page holds. {@code T} should implement | ||
* {@code java.io.Serializable}. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@ajkannan great job, I just added some comments! |
b1d2478
to
5628d7f
Compare
Thanks for taking a look @mziccard! I made the fixes in place. |
* {@code java.io.Serializable} | ||
* @param <O> the service options type | ||
*/ | ||
@SuppressWarnings("rawtypes") |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
5628d7f
to
cbdfecc
Compare
cbdfecc
to
ce9b5c1
Compare
Added a commit to use the static method as @aozarov suggested. |
Committer: @miraleung PiperOrigin-RevId: 378266372 Source-Link: googleapis/googleapis@9e31055 Source-Link: https://github.com/googleapis/googleapis-gen/commit/14629f6b39dfee67009f79a96d2077d5bb17d1c3
🤖 I have created a release *beep* *boop* --- ## [0.14.1](googleapis/java-analytics-data@v0.14.0...v0.14.1) (2022-07-01) ### Dependencies * update dependency com.google.auth:google-auth-library-oauth2-http to v1.8.0 ([#511](googleapis/java-analytics-data#511)) ([8fe4a39](googleapis/java-analytics-data@8fe4a39)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…-plugin to v3.4.1 (#517) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) | `3.4.0` -> `3.4.1` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/compatibility-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/confidence-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-retail). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNjEuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE2MS4wIn0=-->
🤖 I have created a release *beep* *boop* --- ## [2.5.3](googleapis/java-os-config@v2.5.2...v2.5.3) (2022-09-09) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#516](googleapis/java-os-config#516)) ([2b361ba](googleapis/java-os-config@2b361ba)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Fixes #485