Update resumption strategy to use format-independent row count. #5658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the ReadRowsResumptionStrategy helper class in the BigQuery storage client to use the new format-independent row count value in the ReadRowsResponse message in order to track stream position. It also modifies various test files to use the new row count value.
googlebot
added
the
cla: yes
|
cc: @tswast |
sduskis
requested review from
tswast and
shollyman
and removed request for
a team
sduskis
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #5658 +/- ##
=========================================
Coverage 46.71% 46.71%
+ Complexity 24644 24629 -15
=========================================
Files 2351 2351
Lines 256127 256127
Branches 29320 29325 +5
=========================================
Hits 119648 119648
Misses 127559 127559
Partials 8920 8920
Continue to review full report at Codecov.
|
chingor13
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
shollyman
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the ReadRowsResumptionStrategy helper class in the BigQuery
storage client to use the new format-independent row count value in the
ReadRowsResponse message in order to track stream position. It also modifies
various test files to use the new row count value.