-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datastore fixes #648
Merged
Merged
Datastore fixes #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Feb 16, 2016
@Override | ||
public Key parent() { | ||
List<PathElement> ancestors = ancestors(); | ||
if (!ancestors.isEmpty()) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
… other minor fixes
Incorporated the comments, ready for another pass. |
Removed unnecessary changes to ListValue and made addValue() unambiguous. |
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jun 29, 2022
…onfig to v1.1.0 (googleapis#648) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.0.3` -> `1.1.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.1.0/compatibility-slim/1.0.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.1.0/confidence-slim/1.0.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.1.0`](https://togithub.com/googleapis/java-shared-config/blob/master/CHANGELOG.md#​110-httpswwwgithubcomgoogleapisjava-shared-configcomparev103v110-2021-10-12) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.0.3...v1.1.0) ##### Features - introduce Maven configuration for GraalVM testing ([#&googleapis#8203;314](https://www.togithub.com/googleapis/java-shared-config/issues/314)) ([28fbeb8](https://www.github.com/googleapis/java-shared-config/commit/28fbeb86c4466a58a05d6933584564dbf3352e79)) ##### Bug Fixes - update doclet version ([#&googleapis#8203;332](https://www.togithub.com/googleapis/java-shared-config/issues/332)) ([3fd0350](https://www.github.com/googleapis/java-shared-config/commit/3fd035030e4f0954dd1f62f7b8ea62583685880c)) ##### Dependencies - update dependency com.puppycrawl.tools:checkstyle to v9.0.1 ([#&googleapis#8203;327](https://www.togithub.com/googleapis/java-shared-config/issues/327)) ([b6c9b65](https://www.github.com/googleapis/java-shared-config/commit/b6c9b657550db2dee6b36edbb9a6084baee125e2)) - update dependency org.graalvm.buildtools:junit-platform-native to v0.9.6 ([#&googleapis#8203;330](https://www.togithub.com/googleapis/java-shared-config/issues/330)) ([271ed7d](https://www.github.com/googleapis/java-shared-config/commit/271ed7dba35623e22fc8a7f7d477e6043e772014)) - update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.6 ([#&googleapis#8203;331](https://www.togithub.com/googleapis/java-shared-config/issues/331)) ([4f9ba15](https://www.github.com/googleapis/java-shared-config/commit/4f9ba1551df0a2d4fc8c9acca8a951afbe8cb78a)) - update dependency org.junit.vintage:junit-vintage-engine to v5.8.1 ([#&googleapis#8203;329](https://www.togithub.com/googleapis/java-shared-config/issues/329)) ([4a8789e](https://www.github.com/googleapis/java-shared-config/commit/4a8789ee814ba8a3480beecc76c16fd1cb4e5f12)) ##### [1.0.3](https://www.github.com/googleapis/java-shared-config/compare/v1.0.2...v1.0.3) (2021-09-21) ##### Bug Fixes - update java-docfx-doclet version ([#&googleapis#8203;315](https://www.togithub.com/googleapis/java-shared-config/issues/315)) ([07af07c](https://www.github.com/googleapis/java-shared-config/commit/07af07c188447ea5728ecd2700121ff477d1c58a)) ##### [1.0.2](https://www.github.com/googleapis/java-shared-config/compare/v1.0.1...v1.0.2) (2021-09-13) ##### Bug Fixes - specify animal-sniffer-maven-plugin version ([#&googleapis#8203;308](https://www.togithub.com/googleapis/java-shared-config/issues/308)) ([378bf43](https://www.github.com/googleapis/java-shared-config/commit/378bf431383306c1cdd0a4f922956c87edf321b5)) - update java docfx doclet version ([#&googleapis#8203;312](https://www.togithub.com/googleapis/java-shared-config/issues/312)) ([dd7f6e0](https://www.github.com/googleapis/java-shared-config/commit/dd7f6e0c1a7cc73831b74b4475457611a8c097d3)) ##### Dependencies - update dependency com.puppycrawl.tools:checkstyle to v9 ([#&googleapis#8203;303](https://www.togithub.com/googleapis/java-shared-config/issues/303)) ([71faea3](https://www.github.com/googleapis/java-shared-config/commit/71faea38d4132407598550e2bb4c77f9d4a4d83d)) ##### [1.0.1](https://www.github.com/googleapis/java-shared-config/compare/v1.0.0...v1.0.1) (2021-08-18) ##### Dependencies - update dependency com.puppycrawl.tools:checkstyle to v8.45.1 ([#&googleapis#8203;292](https://www.togithub.com/googleapis/java-shared-config/issues/292)) ([66bf6e6](https://www.github.com/googleapis/java-shared-config/commit/66bf6e6fb95997b9eb4b34268b8d20c2fbe9ed5a)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-resourcemanager).
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
🤖 I have created a release *beep* *boop* --- ## [2.10.0](googleapis/java-shared-dependencies@v2.9.0...v2.10.0) (2022-04-15) ### Dependencies * google-cloud-core 2.6.0 ([#668](googleapis/java-shared-dependencies#668)) ([14bad98](googleapis/java-shared-dependencies@14bad98)) * reverting protobuf to 3.19.4 ([#657](googleapis/java-shared-dependencies#657)) ([9fda073](googleapis/java-shared-dependencies@9fda073)) * update dependency com.fasterxml.jackson:jackson-bom to v2.13.2.20220328 ([#646](googleapis/java-shared-dependencies#646)) ([2bd0149](googleapis/java-shared-dependencies@2bd0149)) * update dependency com.google.api-client:google-api-client-bom to v1.34.0 ([#662](googleapis/java-shared-dependencies#662)) ([f8f38ff](googleapis/java-shared-dependencies@f8f38ff)) * update dependency com.google.errorprone:error_prone_annotations to v2.12.1 ([#652](googleapis/java-shared-dependencies#652)) ([452dcb7](googleapis/java-shared-dependencies@452dcb7)) * update dependency com.google.errorprone:error_prone_annotations to v2.13.0 ([#669](googleapis/java-shared-dependencies#669)) ([5d255fd](googleapis/java-shared-dependencies@5d255fd)) * update dependency com.google.http-client:google-http-client-bom to v1.41.6 ([#654](googleapis/java-shared-dependencies#654)) ([c93b54f](googleapis/java-shared-dependencies@c93b54f)) * update dependency com.google.http-client:google-http-client-bom to v1.41.7 ([#658](googleapis/java-shared-dependencies#658)) ([95e5d5c](googleapis/java-shared-dependencies@95e5d5c)) * update dependency com.google.oauth-client:google-oauth-client-bom to v1.33.2 ([#655](googleapis/java-shared-dependencies#655)) ([061038b](googleapis/java-shared-dependencies@061038b)) * update dependency com.google.oauth-client:google-oauth-client-bom to v1.33.3 ([#663](googleapis/java-shared-dependencies#663)) ([140cfea](googleapis/java-shared-dependencies@140cfea)) * update dependency com.google.protobuf:protobuf-bom to v3.20.0 ([#651](googleapis/java-shared-dependencies#651)) ([f9f656f](googleapis/java-shared-dependencies@f9f656f)) * update dependency io.grpc:grpc-bom to v1.45.1 ([#647](googleapis/java-shared-dependencies#647)) ([2d12ba9](googleapis/java-shared-dependencies@2d12ba9)) * update dependency org.checkerframework:checker-qual to v3.21.4 ([#650](googleapis/java-shared-dependencies#650)) ([43bcd75](googleapis/java-shared-dependencies@43bcd75)) * update gax.version to v2.15.0 ([#649](googleapis/java-shared-dependencies#649)) ([68c5a35](googleapis/java-shared-dependencies@68c5a35)) * update gax.version to v2.16.0 ([#664](googleapis/java-shared-dependencies#664)) ([1e62b89](googleapis/java-shared-dependencies@1e62b89)) * update google.common-protos.version to v2.8.1 ([#656](googleapis/java-shared-dependencies#656)) ([b00e7fd](googleapis/java-shared-dependencies@b00e7fd)) * update google.common-protos.version to v2.8.2 ([#659](googleapis/java-shared-dependencies#659)) ([52c5798](googleapis/java-shared-dependencies@52c5798)) * update google.common-protos.version to v2.8.3 ([#660](googleapis/java-shared-dependencies#660)) ([9871634](googleapis/java-shared-dependencies@9871634)) * update iam.version to v1.3.0 ([#648](googleapis/java-shared-dependencies#648)) ([5252213](googleapis/java-shared-dependencies@5252213)) * update iam.version to v1.3.1 ([#661](googleapis/java-shared-dependencies#661)) ([bfedb46](googleapis/java-shared-dependencies@bfedb46)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: datastore
Issues related to the Datastore API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: