Add functional methods for snapshots and Snapshot class #780

mziccard · 2016-03-23T17:22:34Z

This PR adds functional methods for snasphots to Compute and ComputeRpc. This also adds the Snapshot class. Unit tests are added. Intergration tests will come as soon as we have disks in place.

coveralls · 2016-03-23T17:48:19Z

Changes Unknown when pulling fe57d61 on mziccard:compute into * on GoogleCloudPlatform:compute-alpha*.

gcloud-java-compute/src/main/java/com/google/gcloud/compute/Compute.java

+    }
+
+    /**
+     * Returns an equality filter for the given field and string value. For string fields,


ajkannan · 2016-03-24T02:53:54Z

Hey @mziccard, I didn't get a chance to finish my review. I'll pick back up tomorrow morning.

gcloud-java-compute/src/main/java/com/google/gcloud/compute/ComputeImpl.java

@@ -914,6 +933,99 @@ public Operation delete(final AddressId addressId, OperationOption... options) {
    }
  }

+  @Override
+  public Operation create(SnapshotInfo snapshot, final OperationOption... options) {


ajkannan · 2016-03-24T17:51:08Z

Done with my pass.

gcloud-java-compute/src/main/java/com/google/gcloud/compute/Compute.java

+     *
+     * @see <a href="https://github.com/google/re2/wiki/Syntax">RE2</a>
+     */
+    public static SnapshotFilter equals(SnapshotField field, String value) {


coveralls · 2016-03-24T20:44:33Z

Changes Unknown when pulling d86ede9 on mziccard:compute into * on GoogleCloudPlatform:compute-alpha*.

mziccard · 2016-03-24T22:10:16Z

All comments are fixed

gcloud-java-compute/src/test/java/com/google/gcloud/compute/SnapshotTest.java

+  private static final SnapshotInfo.StorageBytesStatus STORAGE_BYTES_STATUS =
+      SnapshotInfo.StorageBytesStatus.UP_TO_DATE;
+
+  private Compute serviceMockReturnsOptions = createStrictMock(Compute.class);


gcloud-java-compute/src/test/java/com/google/gcloud/compute/ComputeImplTest.java

+  }
+
+  @Test
+  public void testGetSnapshot_Null() {


aozarov · 2016-03-25T00:05:43Z

Looks good to me. Few minor things and a question.
Also, I assume you are passing along the codacy comments?

mziccard · 2016-03-25T14:46:02Z

Also, I assume you are passing along the codacy comments?

I enabled Codacy to send messages with issue, it seems to be posting them with my account :) (Remember when I asked you if it was too invasive?)

We can disable this feature, just let me know.

aozarov · 2016-03-25T15:30:08Z

I enabled Codacy to send messages with issue, it seems to be posting them with my account :)
(Remember when I asked you if it was too invasive?)
We can disable this feature, just let me know.

Sorry, I meant to ask if you pass along to codacy the issues with their suggestions.
I am fine with the current state though would like to change some of the "suggestions" that for the
moment do not work well for us.

coveralls · 2016-03-25T21:28:19Z

Changes Unknown when pulling fc1d0ed on mziccard:compute into * on GoogleCloudPlatform:compute-alpha*.

mziccard · 2016-03-25T21:30:04Z

All comments should be fixed now

gcloud-java-compute/src/main/java/com/google/gcloud/compute/Compute.java

@@ -1668,7 +1668,7 @@ public static SnapshotListOption fields(SnapshotField... fields) {
  Snapshot getSnapshot(String snapshot, SnapshotOption... options);

  /**
-   * Lists all snapshots.
+   * Lists snapshots.


aozarov · 2016-03-25T23:46:54Z

Looks good. Feel free to merge.

coveralls · 2016-03-25T23:58:11Z

Changes Unknown when pulling bc2d7a1 on mziccard:compute into * on GoogleCloudPlatform:compute-alpha*.

Making CLIRR not required. The version bumps are now controlled by the Release Please and OwlBot. The CL authors create appropriate change description to control major version bumps.

🤖 I have created a release *beep* *boop* --- ## [2.3.0](googleapis/java-secretmanager@v2.2.0...v2.3.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#790](googleapis/java-secretmanager#790)) ([d41cd58](googleapis/java-secretmanager@d41cd58)) ### Documentation * **sample:** clean up README for native image sample ([googleapis#785](googleapis/java-secretmanager#785)) ([c6005b3](googleapis/java-secretmanager@c6005b3)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#789](googleapis/java-secretmanager#789)) ([6591df5](googleapis/java-secretmanager@6591df5)) * update dependency com.google.protobuf:protobuf-java-util to v3.21.0 ([googleapis#779](googleapis/java-secretmanager#779)) ([ff31a24](googleapis/java-secretmanager@ff31a24)) * update dependency com.google.protobuf:protobuf-java-util to v3.21.1 ([googleapis#780](googleapis/java-secretmanager#780)) ([9011c89](googleapis/java-secretmanager@9011c89)) * update dependency com.google.protobuf:protobuf-java-util to v3.21.2 ([googleapis#791](googleapis/java-secretmanager#791)) ([1fdde19](googleapis/java-secretmanager@1fdde19)) * update dependency org.graalvm.buildtools:junit-platform-native to v0.9.12 ([googleapis#787](googleapis/java-secretmanager#787)) ([b1bde96](googleapis/java-secretmanager@b1bde96)) * update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 ([googleapis#788](googleapis/java-secretmanager#788)) ([9c10bdf](googleapis/java-secretmanager@9c10bdf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…onfig to v1.5.1 (#780) * build(deps): update dependency com.google.cloud:google-cloud-shared-config to v1.5.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [3.5.2](googleapis/java-cloudbuild@v3.5.1...v3.5.2) (2022-08-02) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#777](googleapis/java-cloudbuild#777)) ([35ba1c6](googleapis/java-cloudbuild@35ba1c6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.4.3](googleapis/java-accessapproval@v2.4.2...v2.4.3) (2022-08-09) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.3 ([#779](googleapis/java-accessapproval#779)) ([f11b5f4](googleapis/java-accessapproval@f11b5f4)) * update dependency com.google.cloud:google-cloud-core to v2.8.5 ([#780](googleapis/java-accessapproval#780)) ([ccbc03d](googleapis/java-accessapproval@ccbc03d)) * update dependency com.google.cloud:google-cloud-core to v2.8.6 ([#784](googleapis/java-accessapproval#784)) ([2b8872d](googleapis/java-accessapproval@2b8872d)) * update dependency com.google.cloud:google-cloud-core to v2.8.7 ([#785](googleapis/java-accessapproval#785)) ([464c702](googleapis/java-accessapproval@464c702)) * update dependency com.google.cloud:google-cloud-core to v2.8.8 ([#786](googleapis/java-accessapproval#786)) ([4d28115](googleapis/java-accessapproval@4d28115)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#781](googleapis/java-accessapproval#781)) ([f8fac7c](googleapis/java-accessapproval@f8fac7c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [0.123.4](googleapis/java-datalabeling@v0.123.3...v0.123.4) (2022-09-09) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#780](googleapis/java-datalabeling#780)) ([3fa6104](googleapis/java-datalabeling@3fa6104)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…s#1687) (googleapis#780) * chore(java): add a note in README for migrated split repos Disable renovate bot and flaky bot for split repositories that have moved to the Java monorepo. The Java monorepo will pass the "monorepo=True" parameter to java.common_templates method in its owlbot.py files so that the migration note will not appear in the README in the monorepo. Co-authored-by: Jeff Ching <chingor@google.com> Source-Link: https://togithub.com/googleapis/synthtool/commit/d4b291604f148cde065838c498bc8aa79b8dc10e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:edae91ccdd2dded2f572ec341a768ad180305a3e8fbfd93064b28e237d35920a

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.grpc:grpc-bom](https://togithub.com/grpc/grpc-java) | `1.45.0` -> `1.45.1` | [![age](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.45.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.45.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.45.1/compatibility-slim/1.45.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.45.1/confidence-slim/1.45.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc/grpc-java</summary> ### [`v1.45.1`](https://togithub.com/grpc/grpc-java/releases/v1.45.1) [Compare Source](https://togithub.com/grpc/grpc-java/compare/v1.45.0...v1.45.1) #### Bug Fixes - netty: Fixed incompatibility with Netty 4.1.75.Final that caused COMPRESSION_ERROR ([#9004](https://togithub.com/grpc/grpc-java/issues/9004)) - xds: Fix LBs blindly propagating control plane errors ([#9012](https://togithub.com/grpc/grpc-java/issues/9012)). This change forces the use of UNAVAILABLE for any xDS communication failures, which otherwise could greatly confuse an application. This is essentially a continuation of the fix in 1.45.0 for XdsNameResolver, but for other similar cases </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).

🤖 I have created a release *beep* *boop* --- ## [2.6.0](googleapis/java-core@v2.5.11...v2.6.0) (2022-04-14) ### Features * **java:** remove GoogleJsonClentFeature and OpenCensusFeature after relocation ([#793](googleapis/java-core#793)) ([cafd489](googleapis/java-core@cafd489)) * **java:** remove Netty Native Image configuration after relocation to gax ([#771](googleapis/java-core#771)) ([9cc7dba](googleapis/java-core@9cc7dba)) * **java:** remove protobuf Native Image configuration ([#784](googleapis/java-core#784)) ([7a8df66](googleapis/java-core@7a8df66)) * remove native-image.properties settings after relocation ([#794](googleapis/java-core#794)) ([219a519](googleapis/java-core@219a519)) * remove resource-config after relocation ([#795](googleapis/java-core#795)) ([8ed3110](googleapis/java-core@8ed3110)) * remove substitutions after relocation to gax ([#789](googleapis/java-core#789)) ([85280b1](googleapis/java-core@85280b1)) ### Bug Fixes * **java:** register test class for reflection to fix native image test ([#766](googleapis/java-core#766)) ([fa07125](googleapis/java-core@fa07125)) ### Dependencies * revert protobuf to 3.19 and common-protos 2.8.3 ([#798](googleapis/java-core#798)) ([27ca70c](googleapis/java-core@27ca70c)) * update dependency com.google.api-client:google-api-client-bom to v1.34.0 ([#800](googleapis/java-core#800)) ([3abc47d](googleapis/java-core@3abc47d)) * update dependency com.google.api:gax-bom to v2.16.0 ([#785](googleapis/java-core#785)) ([bd33a76](googleapis/java-core@bd33a76)) * update dependency com.google.api.grpc:proto-google-common-protos to v2.8.1 ([#792](googleapis/java-core#792)) ([3f85e62](googleapis/java-core@3f85e62)) * update dependency com.google.api.grpc:proto-google-common-protos to v2.8.2 ([#796](googleapis/java-core#796)) ([d6ea18e](googleapis/java-core@d6ea18e)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.0 ([#783](googleapis/java-core#783)) ([48594f3](googleapis/java-core@48594f3)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.1 ([#799](googleapis/java-core#799)) ([9fe7d35](googleapis/java-core@9fe7d35)) * update dependency com.google.errorprone:error_prone_annotations to v2.12.1 ([#788](googleapis/java-core#788)) ([cfdabb4](googleapis/java-core@cfdabb4)) * update dependency com.google.http-client:google-http-client-bom to v1.41.6 ([#791](googleapis/java-core#791)) ([d9ff405](googleapis/java-core@d9ff405)) * update dependency com.google.http-client:google-http-client-bom to v1.41.7 ([#797](googleapis/java-core#797)) ([dfc3c57](googleapis/java-core@dfc3c57)) * update dependency com.google.protobuf:protobuf-bom to v3.20.0 ([#787](googleapis/java-core#787)) ([51f59fc](googleapis/java-core@51f59fc)) * update dependency io.grpc:grpc-bom to v1.45.1 ([#780](googleapis/java-core#780)) ([cd8a078](googleapis/java-core@cd8a078)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…780) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.protobuf:protobuf-bom](https://developers.google.com/protocol-buffers/) ([source](https://togithub.com/protocolbuffers/protobuf)) | `3.21.4` -> `3.21.5` | [![age](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.5/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.5/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.5/compatibility-slim/3.21.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.5/confidence-slim/3.21.4)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>protocolbuffers/protobuf</summary> ### [`v3.21.5`](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.4...v3.21.5) [Compare Source](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.4...v3.21.5) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-shared-dependencies).

mziccard added the api: compute Issues related to the Compute Engine API. label Mar 23, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 23, 2016

Add functional methods for snapshots and Snapshot class

fe57d61

mziccard force-pushed the compute branch from f3c135c to fe57d61 Compare March 23, 2016 17:42

ajkannan reviewed Mar 24, 2016
View reviewed changes

gcloud-java-compute/src/main/java/com/google/gcloud/compute/Compute.java

}

/**

* Returns an equality filter for the given field and string value. For string fields,

This comment was marked as spam.

Sign in to view

ajkannan reviewed Mar 24, 2016
View reviewed changes

aozarov reviewed Mar 24, 2016
View reviewed changes

gcloud-java-compute/src/main/java/com/google/gcloud/compute/Compute.java

*

* @see <a href="https://github.com/google/re2/wiki/Syntax">RE2</a>

*/

public static SnapshotFilter equals(SnapshotField field, String value) {

This comment was marked as spam.

Sign in to view

Fix minor issues with functional snapshot methods and tests

d86ede9

ajkannan reviewed Mar 24, 2016
View reviewed changes

aozarov reviewed Mar 25, 2016
View reviewed changes

gcloud-java-compute/src/test/java/com/google/gcloud/compute/ComputeImplTest.java

}

@Test

public void testGetSnapshot_Null() {

This comment was marked as spam.

Sign in to view

Add missing final, fix codacy issues

fc1d0ed

aozarov reviewed Mar 25, 2016
View reviewed changes

Better javadoc for aggregated list methods

bc2d7a1

mziccard merged commit 32394d2 into googleapis:compute-alpha Mar 26, 2016

release-please bot mentioned this pull request Aug 3, 2022

chore: release monorepo_script_output #8089

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add functional methods for snapshots and Snapshot class #780

Add functional methods for snapshots and Snapshot class #780

mziccard commented Mar 23, 2016

coveralls commented Mar 23, 2016

This comment was marked as spam.

ajkannan commented Mar 24, 2016

This comment was marked as spam.

ajkannan commented Mar 24, 2016

This comment was marked as spam.

coveralls commented Mar 24, 2016

mziccard commented Mar 24, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Mar 25, 2016

mziccard commented Mar 25, 2016

aozarov commented Mar 25, 2016

coveralls commented Mar 25, 2016

mziccard commented Mar 25, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Mar 25, 2016

coveralls commented Mar 25, 2016

Add functional methods for snapshots and Snapshot class #780

Add functional methods for snapshots and Snapshot class #780

Conversation

mziccard commented Mar 23, 2016

coveralls commented Mar 23, 2016

This comment was marked as spam.

ajkannan commented Mar 24, 2016

This comment was marked as spam.

ajkannan commented Mar 24, 2016

This comment was marked as spam.

coveralls commented Mar 24, 2016

mziccard commented Mar 24, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Mar 25, 2016

mziccard commented Mar 25, 2016

aozarov commented Mar 25, 2016

coveralls commented Mar 25, 2016

mziccard commented Mar 25, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Mar 25, 2016

coveralls commented Mar 25, 2016