Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: OwlBot config to specify correct paths with module names #8482

Merged
merged 7 commits into from
Sep 29, 2022

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Sep 28, 2022

Towards #8479

  • build: set_owlbot_config
  • Updating OwlBot configuration files with modules

Comment on lines 22 to 23
- "/google-.*/src/test/java/com/google/cloud/.*/v.*/it/IT.*Test.java"
- "/java-bigquerydatatransfer/google-.*/src/test/java/com/google/cloud/.*/v.*/it/IT.*Test.java"
- "/google-cloud-bigquerydatatransfer/src/main/java/com/google/cloud/bigquery/datatransfer/v1/SampleApp.java"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect.

- "/java-kms/google-.*/src/test/java/com/google/cloud/.*/v.*/it/IT.*Test.java"
- "/java-kms/proto-google-cloud-kms-v1/src/main/java/com/google/cloud/kms/v1/UntypedKeyName.java"
- "/java-kms/proto-google-cloud-kms-v1/src/main/java/com/google/cloud/kms/v1/KeyName.java"
- "/java-kms/proto-google-cloud-kms-v1/src/main/java/com/google/cloud/kms/v1/KeyNames.java"
- "/google-cloud-kms/src/test/java/com/google/cloud/kms/it/ITKmsTest.java"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missed.

Comment on lines 26 to 27
- "/google-cloud-secretmanager/src/main/java/com/google/cloud/secretmanager/v1beta1"
- "/google-cloud-secretmanager/src/test/java/com/google/cloud/secretmanager/v1beta1"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missed

Comment on lines 23 to 24
- "/google-cloud-trace/src/test/java/com/google/cloud/trace/v1/VPCServiceControlTest.java"
- "/google-cloud-trace/src/test/java/com/google/cloud/trace/v2/VPCServiceControlTest.java"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are missed.

Comment on lines 25 to 27
- "/google-cloud-vision/src/test/java/com/google/cloud/vision/it/ITSystemTest.java"
- "/google-cloud-vision/src/test/resources/city.jpg"
- "/google-cloud-vision/src/test/resources/face_no_surprise.jpg"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are missed

Comment on lines 24 to 25
- "/google-cloud-websecurityscanner/src/test/java/com/google/cloud/websecurityscanner/it/v1beta/VPCServiceControlNegativeTest.java"
- "/google-cloud-websecurityscanner/src/test/java/com/google/cloud/websecurityscanner/it/v1beta/VPCServiceControlPositiveTest.java"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are missed

@suztomo suztomo changed the title build: OwlBot configuration to have module name build: OwlBot config to specify correct paths with module names Sep 29, 2022
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 29, 2022
@suztomo suztomo requested review from lqiu96 and a team September 29, 2022 14:14
generation/set_owlbot_config.sh Show resolved Hide resolved
@suztomo suztomo merged commit d42c6d5 into googleapis:main Sep 29, 2022
@suztomo suztomo deleted the i8479 branch September 29, 2022 16:32
suztomo added a commit to suztomo/google-cloud-java that referenced this pull request Oct 4, 2022
…leapis#8482)

* build: set_owlbot_config

* Updating OwlBot configuration files with modules

* build: checking deep-copy destination

* /google-cloud entries

* fixed google-cloud-* directory entries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants