Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initial generation of apikeys #8519

Closed
wants to merge 3 commits into from
Closed

feat: initial generation of apikeys #8519

wants to merge 3 commits into from

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Oct 4, 2022 •
edited
Loading

Example pull request created by the new-client.py #8517

@snippet-bot
Copy link

snippet-bot bot commented Oct 4, 2022 •
edited
Loading

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@suztomo
Copy link
Member Author

suztomo commented Oct 4, 2022

It needs the latest shared dependencies BOM.

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project proto-google-cloud-apikeys-v2: Compilation failure: Compilation failure: 
Error:  /home/runner/work/google-cloud-java/google-cloud-java/java-apikeys/proto-google-cloud-apikeys-v2/src/main/java/com/google/api/apikeys/v2/Restrictions.java:[941,27] cannot find symbol
Error:    symbol: method parseUnknownField(com.google.protobuf.CodedInputStream,com.google.protobuf.ExtensionRegistryLite,int)
Error:  /home/runner/work/google-cloud-java/google-cloud-java/java-apikeys/proto-google-cloud-apikeys-v2/src/main/java/com/google/api/apikeys/v2/BrowserKeyRestrictions.java:[469,27] cannot find symbol
Error:    symbol: method

meltsufin
meltsufin reviewed Oct 4, 2022
View reviewed changes
java-apikeys/samples/install-without-bom/pom.xml Outdated
@@ -0,0 +1,84 @@
<?xml version='1.0' encoding='UTF-8'?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't be included along with other poms in samples/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True.

@suztomo
Copy link
Member Author

suztomo commented Oct 4, 2022

The version bump of the shared dependencies BOM in synthtool googleapis/synthtool#1641

@suztomo suztomo force-pushed the new_module_java-apikeys branch from 78d1c05 to 1f4a425 Compare October 4, 2022 21:52
suztomo
suztomo commented Oct 4, 2022
View reviewed changes
google-cloud-gapic-bom/pom.xml Outdated
<groupId>com.google.api</groupId>
<groupId>com.google.cloud</groupId>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The group ID was wrong.

@suztomo suztomo force-pushed the new_module_java-apikeys branch from 1f4a425 to a41d7df Compare October 4, 2022 22:51
@suztomo suztomo mentioned this pull request Oct 4, 2022
Closed
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2022
@suztomo suztomo force-pushed the new_module_java-apikeys branch from a41d7df to 324737c Compare October 5, 2022 00:02
@suztomo
Copy link
Member Author

suztomo commented Oct 5, 2022

For Release Please config, #8480 needs to happen first.

@suztomo suztomo mentioned this pull request Oct 5, 2022
Merged
@suztomo
Copy link
Member Author

suztomo commented Oct 5, 2022

#8480 is merged. Regenerating this pull request.

@suztomo suztomo force-pushed the new_module_java-apikeys branch from 324737c to ceaf816 Compare October 5, 2022 17:25
suztomo
suztomo commented Oct 5, 2022
View reviewed changes
google-cloud-gapic-bom/pom.xml Outdated
Comment on lines 719 to 720
<groupId>com.google.api</groupId>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-notification</artifactId>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

@suztomo suztomo closed this Oct 7, 2022
@suztomo suztomo deleted the new_module_java-apikeys branch October 7, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltsufin meltsufin meltsufin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suztomo @meltsufin