Add ServiceAccountSigner interface, enable signing for AE credentials #854

mziccard · 2016-04-05T16:18:09Z

This PR follows from #701:

Add SigningAuthCredentials interface
Make AppEngineAuthCredentials extend SigningAuthCredentials and enable signing on AE
Make AppEngineAuthCredentials public as other AuthCredentials classes
Change createApplicationDefaults to return ServiceAccountAuthCredentials if a service account is available
Add constructor to ApplicationDefaultAuthCredentials that takes GoogleCredentials

aozarov · 2016-04-05T16:19:32Z

gcloud-java-core/src/main/java/com/google/gcloud/SigningAuthCredentials.java

+package com.google.gcloud;
+
+/**
+ * Interface for authentication credentials that support signing.


aozarov · 2016-04-05T17:20:59Z

Nice work! I really like the way you handled the default credentials.

coveralls · 2016-04-05T18:24:08Z

Changes Unknown when pulling 08e23ff on mziccard:signing-auth-interface into * on GoogleCloudPlatform:master*.

mziccard · 2016-04-05T18:24:42Z

Comments fixed in 08e23ff

aozarov · 2016-04-05T23:06:15Z

Looks great. Few more suggestions.

coveralls · 2016-04-06T07:49:01Z

Changes Unknown when pulling 72ae3cb on mziccard:signing-auth-interface into * on GoogleCloudPlatform:master*.

mziccard · 2016-04-06T14:46:46Z

Latest comments fixed in 72ae3cb

gcloud-java-storage/src/main/java/com/google/gcloud/storage/Blob.java

@@ -470,20 +470,26 @@ public WriteChannel writer(BlobWriteOption... options) {
   * {@link StorageOptions} do not implement {@link ServiceAccountSigner} (this is the case for
   * Compute Engine credentials and Google Cloud SDK credentials) then {@code signUrl} will throw an
   * {@link IllegalArgumentException} unless an implementation of {@link ServiceAccountSigner} is


aozarov · 2016-04-06T16:57:38Z

Looks good. One ( x 2) Javadoc fix, and I think we can fix the codacy complaint as well.
Feel free to merge after.

tmatsuo · 2016-04-06T17:43:58Z

👍 Thanks!

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 454939894 Source-Link: googleapis/googleapis@519ca44 Source-Link: https://github.com/googleapis/googleapis-gen/commit/fc639d21a7cbc30aa0a9b862586942a0fb46c5c8 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmM2MzlkMjFhN2NiYzMwYWEwYTliODYyNTg2OTQyYTBmYjQ2YzVjOCJ9 feat: Add Java REST transport to analytics, servicecontrol, servicemanagement, serviceusage and langauge APIs PiperOrigin-RevId: 454254635 Source-Link: googleapis/googleapis@84fb822 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ffb61264d6fb634c430829dd2da75c5bed08304 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZmYjYxMjY0ZDZmYjYzNGM0MzA4MjlkZDJkYTc1YzViZWQwODMwNCJ9

🤖 I have created a release *beep* *boop* --- ## [2.6.1](googleapis/java-document-ai@v2.6.0...v2.6.1) (2022-07-13) ### Bug Fixes * enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-document-ai/issues/1485)) ([#853](googleapis/java-document-ai#853)) ([441aa93](googleapis/java-document-ai@441aa93)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [3.0.3](googleapis/java-recaptchaenterprise@v3.0.2...v3.0.3) (2022-07-29) ### Dependencies * update dependency io.github.bonigarcia:webdrivermanager to v5.2.2 ([#853](googleapis/java-recaptchaenterprise#853)) ([2943c01](googleapis/java-recaptchaenterprise@2943c01)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…1.1 (#854) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.0` -> `26.1.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/compatibility-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/confidence-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-datacatalog).

…1575) (#854) Source-Link: googleapis/synthtool@2e9ac19 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [typing-extensions](https://togithub.com/python/typing_extensions) ([changelog](https://togithub.com/python/typing_extensions/blob/main/CHANGELOG.md)) | `==4.1.1` -> `==4.4.0` | [![age](https://badges.renovateapi.com/packages/pypi/typing-extensions/4.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/typing-extensions/4.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/typing-extensions/4.4.0/compatibility-slim/4.1.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/typing-extensions/4.4.0/confidence-slim/4.1.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-shared-dependencies).

mziccard added the auth label Apr 5, 2016

aozarov added the api: core label Apr 5, 2016

aozarov reviewed Apr 5, 2016
View reviewed changes

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 5, 2016

aozarov reviewed Apr 6, 2016
View reviewed changes

Add ServiceAccountSigner interface, enable signing for AE credentials

804d447

mziccard force-pushed the signing-auth-interface branch from 72ae3cb to 804d447 Compare April 6, 2016 17:07

mziccard changed the title ~~Add SigningAuthCredentials interface, enable signing for AE credentials~~ Add ServiceAccountSigner interface, enable signing for AE credentials Apr 6, 2016

mziccard merged commit 29b1ea5 into googleapis:master Apr 6, 2016

mziccard mentioned this pull request Apr 6, 2016

Is it possible to use ApplicationDefaultCredentials for SignUrlOption? #701

Closed

github-actions bot pushed a commit that referenced this pull request Jul 14, 2022

chore: add native image checks as required (#854)

4a05f1a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ServiceAccountSigner interface, enable signing for AE credentials #854

Add ServiceAccountSigner interface, enable signing for AE credentials #854

mziccard commented Apr 5, 2016 •

edited

Loading

aozarov commented Apr 5, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Apr 5, 2016

coveralls commented Apr 5, 2016

mziccard commented Apr 5, 2016

aozarov commented Apr 5, 2016

coveralls commented Apr 6, 2016

mziccard commented Apr 6, 2016

This comment was marked as spam.

aozarov commented Apr 6, 2016

tmatsuo commented Apr 6, 2016

Add ServiceAccountSigner interface, enable signing for AE credentials #854

Add ServiceAccountSigner interface, enable signing for AE credentials #854

Conversation

mziccard commented Apr 5, 2016 • edited Loading

aozarov commented Apr 5, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Apr 5, 2016

coveralls commented Apr 5, 2016

mziccard commented Apr 5, 2016

aozarov commented Apr 5, 2016

coveralls commented Apr 6, 2016

mziccard commented Apr 6, 2016

This comment was marked as spam.

aozarov commented Apr 6, 2016

tmatsuo commented Apr 6, 2016

mziccard commented Apr 5, 2016 •

edited

Loading