Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [maps-mapsplatformdatasets] new module for maps-mapsplatformdatasets #9119

Closed
wants to merge 2 commits into from
Closed

feat: [maps-mapsplatformdatasets] new module for maps-mapsplatformdatasets #9119

wants to merge 2 commits into from

Conversation

emmileaf
Copy link
Contributor

@emmileaf emmileaf commented Feb 14, 2023 •
edited
Loading

Initial generation for new mapsplatformdatasets client library:

python3.9 generation/new_client/new-client.py generate \
  --api_shortname=maps-mapsplatformdatasets \
  --proto-path=google/maps/mapsplatformdatasets \
  --name-pretty="Maps Platform Datasets API" \
  --product-docs="https://developers.google.com/maps/documentation" \
  --api-description="Maps Platform Datasets API." \
  --cloud-api=false \
  --distribution-name="com.google.maps:google-maps-mapsplatformdatasets"

@emmileaf emmileaf marked this pull request as ready for review February 14, 2023 15:34
@snippet-bot
Copy link

snippet-bot bot commented Feb 14, 2023

Here is the summary of possible violations 😱

There are 34 possible violations for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.

Here is the summary of changes.

You are about to add 34 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@emmileaf emmileaf requested review from suztomo and blakeli0 February 14, 2023 15:34
suztomo
suztomo requested changes Feb 14, 2023
View reviewed changes
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may have to rewrite the generation script. No need to take action from you.

java-maps-mapsplatformdatasets/grpc-google-maps-mapsplatformdatasets-v1alpha/pom.xml
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.api.grpc</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't became maps...

@emmileaf emmileaf mentioned this pull request Feb 16, 2023
Merged
@suztomo suztomo mentioned this pull request Feb 16, 2023
Closed
@suztomo
Copy link
Member

suztomo commented Feb 24, 2023

@emmileaf Once googleapis/synthtool#1770 is merged and you get necessary information via b/264293181, would you recreate the pull request?

@suztomo suztomo closed this Feb 24, 2023
@emmileaf
Copy link
Contributor Author

@emmileaf Once googleapis/synthtool#1770 is merged and you get necessary information via b/264293181, would you recreate the pull request?

@suztomo Sounds good, thank you for the heads up!

@emmileaf emmileaf deleted the new_module_java-maps-mapsplatformdatasets branch February 25, 2023 00:29
@emmileaf emmileaf mentioned this pull request Feb 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo requested changes

@blakeli0 blakeli0 Awaiting requested review from blakeli0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmileaf @suztomo