Make DNS batch get zone/changerequest return null for NOT_FOUND #953

mziccard · 2016-04-22T12:21:55Z

This fixes #949: DnsBatch.getZone and DnsBatch.getChangeRequest now return null for NOT_FOUND. This PR also adds more tests.

coveralls · 2016-04-22T13:00:52Z

Coverage decreased (-0.006%) to 85.731% when pulling dfbfeeb on mziccard:fix-dns-batch into 0a6c6f7 on GoogleCloudPlatform:master.

gcloud-java-dns/src/main/java/com/google/cloud/dns/spi/DefaultDnsRpc.java

-          return null;
-        }
-        // the zone does not exist, so throw an exception
+      if (serviceException.code() == HTTP_NOT_FOUND


aozarov · 2016-04-22T16:37:35Z

LGTM

coveralls · 2016-04-22T18:58:25Z

Coverage decreased (-0.001%) to 85.736% when pulling 7d9f33d on mziccard:fix-dns-batch into 0a6c6f7 on GoogleCloudPlatform:master.

…rm to v2.9.7 (#953) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-aiplatform](https://togithub.com/googleapis/java-) | `2.9.6` -> `2.9.7` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-aiplatform/2.9.7/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-aiplatform/2.9.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-aiplatform/2.9.7/compatibility-slim/2.9.6)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-aiplatform/2.9.7/confidence-slim/2.9.6)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-aiplatform).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…953) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.7` -> `2.8.8` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/compatibility-slim/2.8.7)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/confidence-slim/2.8.7)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.8.8`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#288-httpsgithubcomgoogleapisjava-corecomparev287v288-2022-08-04) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.7...v2.8.8) ##### Dependencies - update dependency com.google.errorprone:error_prone_annotations to v2.15.0 ([#897](https://togithub.com/googleapis/java-core/issues/897)) ([29e4fc9](https://togithub.com/googleapis/java-core/commit/29e4fc93d5d4d50f7de85eae7a8150314cca6f43)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-intelligence).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [markupsafe](https://palletsprojects.com/p/markupsafe/) ([changelog](https://markupsafe.palletsprojects.com/changes/)) | `==2.0.1` -> `==2.1.1` | [![age](https://badges.renovateapi.com/packages/pypi/markupsafe/2.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/markupsafe/2.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/markupsafe/2.1.1/compatibility-slim/2.0.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/markupsafe/2.1.1/confidence-slim/2.0.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-monitoring).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jinja2](https://palletsprojects.com/p/jinja/) ([changelog](https://jinja.palletsprojects.com/changes/)) | `==3.0.3` -> `==3.1.2` | [![age](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/compatibility-slim/3.0.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/confidence-slim/3.0.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).

mziccard added the api: dns Issues related to the Cloud DNS API. label Apr 22, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 22, 2016

mziccard force-pushed the fix-dns-batch branch from a5e83e5 to dfbfeeb Compare April 22, 2016 12:53

aozarov reviewed Apr 22, 2016
View reviewed changes

gcloud-java-dns/src/main/java/com/google/cloud/dns/spi/DefaultDnsRpc.java

return null;

}

// the zone does not exist, so throw an exception

if (serviceException.code() == HTTP_NOT_FOUND

This comment was marked as spam.

Sign in to view

Make DNS batch get zone/changerequest return null for NOT_FOUND

7d9f33d

mziccard force-pushed the fix-dns-batch branch from dfbfeeb to 7d9f33d Compare April 22, 2016 18:36

mziccard merged commit 121783a into googleapis:master Apr 22, 2016

suztomo pushed a commit that referenced this pull request Feb 1, 2023

deps: update dependency io.grpc:grpc-bom to v1.51.1 (#953)

35a98fe

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make DNS batch get zone/changerequest return null for NOT_FOUND #953

Make DNS batch get zone/changerequest return null for NOT_FOUND #953

mziccard commented Apr 22, 2016

coveralls commented Apr 22, 2016

This comment was marked as spam.

aozarov commented Apr 22, 2016

coveralls commented Apr 22, 2016

Make DNS batch get zone/changerequest return null for NOT_FOUND #953

Make DNS batch get zone/changerequest return null for NOT_FOUND #953

Conversation

mziccard commented Apr 22, 2016

coveralls commented Apr 22, 2016

This comment was marked as spam.

aozarov commented Apr 22, 2016

coveralls commented Apr 22, 2016