-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [batch] Add comment to the unsupported order_by field of ListTasksRequest #9684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: Mark `order_by` field in `ListTasksRequest` as not implemented. docs: Improve url examples in comments PiperOrigin-RevId: 550631094 Source-Link: googleapis/googleapis@a2223b1 Source-Link: https://github.com/googleapis/googleapis-gen/commit/30139239002a1d592923b8cc55b87a9c02c248bd Copy-Tag: eyJwIjoiamF2YS1iYXRjaC8uT3dsQm90LnlhbWwiLCJoIjoiMzAxMzkyMzkwMDJhMWQ1OTI5MjNiOGNjNTViODdhOWMwMmMyNDhiZCJ9
trusted-contributions-gcf
bot
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Jul 24, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jul 24, 2023
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 24, 2023
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
trusted-contributions-gcf
bot
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Jul 24, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jul 24, 2023
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 24, 2023
--- feat: Enable gpu driver version field on v1 --- feat: allow order_by for v1 ListJobs --- feat: Improve url examples formats on Batch API comments PiperOrigin-RevId: 552573521 Source-Link: googleapis/googleapis@c34b78b Source-Link: https://github.com/googleapis/googleapis-gen/commit/12deb79966c3c6791755d66749e1611799ee95ab Copy-Tag: eyJwIjoiamF2YS1iYXRjaC8uT3dsQm90LnlhbWwiLCJoIjoiMTJkZWI3OTk2NmMzYzY3OTE3NTVkNjY3NDllMTYxMTc5OWVlOTVhYiJ9
gcf-owl-bot
bot
changed the title
feat: [batch] Enable gpu driver version field on v1
feat: [batch] Add comment to the unsupported order_by field of ListTasksRequest
Jul 31, 2023
trusted-contributions-gcf
bot
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Jul 31, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jul 31, 2023
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 31, 2023
trusted-contributions-gcf
bot
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Jul 31, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jul 31, 2023
yoshi-kokoro
removed
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Jul 31, 2023
JoeWang1127
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Enable gpu driver version field on v1
feat: allow order_by for v1 ListJobs
feat: Improve url examples formats on Batch API comments
PiperOrigin-RevId: 552573521
Source-Link: googleapis/googleapis@c34b78b
Source-Link: https://github.com/googleapis/googleapis-gen/commit/12deb79966c3c6791755d66749e1611799ee95ab
Copy-Tag: eyJwIjoiamF2YS1iYXRjaC8uT3dsQm90LnlhbWwiLCJoIjoiMTJkZWI3OTk2NmMzYzY3OTE3NTVkNjY3NDllMTYxMTc5OWVlOTVhYiJ9
BEGIN_NESTED_COMMIT
feat: [batch] Enable gpu driver version field on v1
docs: Mark
order_by
field inListTasksRequest
as not implemented.docs: Improve url examples in comments
PiperOrigin-RevId: 550631094
Source-Link: googleapis/googleapis@a2223b1
Source-Link: https://github.com/googleapis/googleapis-gen/commit/30139239002a1d592923b8cc55b87a9c02c248bd
Copy-Tag: eyJwIjoiamF2YS1iYXRjaC8uT3dsQm90LnlhbWwiLCJoIjoiMzAxMzkyMzkwMDJhMWQ1OTI5MjNiOGNjNTViODdhOWMwMmMyNDhiZCJ9
END_NESTED_COMMIT