Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TopicId and SubscriptionId classes #984

Merged
merged 4 commits into from
May 10, 2016

Conversation

mziccard
Copy link
Contributor

@mziccard mziccard commented May 5, 2016

This PR adds the TopicId class, thus allowing to create subscriptions for topics that reside in different projects.
This PR also adds the SubscriptionId class that is returned by pubsub.list(topic) and pubsub.listAsync(topic) (thus fixing #978).

/cc @aozarov

@mziccard mziccard added the api: pubsub Issues related to the Pub/Sub API. label May 5, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 81.939% when pulling 54596c0 on mziccard:pubsub-ids into 7857986 on GoogleCloudPlatform:pubsub-alpha.

/**
* Identity for a Google PubSub subscription. {@code SubscriptionId} objects are returned by the
* {@link PubSub#listSubscriptions(String, PubSub.ListOption...)} and
* {@link PubSub#listSubscriptionsAsync(String, PubSub.ListOption...)} methods as the same topic

This comment was marked as spam.

@aozarov
Copy link
Contributor

aozarov commented May 5, 2016

Not a thorough review by any means but this change looks good to me.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 81.939% when pulling b27eb5c on mziccard:pubsub-ids into 7857986 on GoogleCloudPlatform:pubsub-alpha.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 81.942% when pulling 67be29c on mziccard:pubsub-ids into 7857986 on GoogleCloudPlatform:pubsub-alpha.

@mziccard mziccard merged commit 9879a16 into googleapis:pubsub-alpha May 10, 2016
mziccard added a commit to mziccard/gcloud-java that referenced this pull request Jun 27, 2016
* Add TopicId class and tests. Use TopicId in SubscriptionInfo

* Add SubscriptionId class and tests. Use SubscriptionId in listSubscriptions(topic)

* Minor javadoc fixes

* Add identity for deleted topics
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jul 1, 2022
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Sep 15, 2022
…cies to v3.0.3 (#984)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-shared-dependencies](https://togithub.com/googleapis/java-shared-dependencies) | `3.0.2` -> `3.0.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/3.0.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/3.0.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/3.0.3/compatibility-slim/3.0.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/3.0.3/confidence-slim/3.0.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-shared-dependencies</summary>

### [`v3.0.3`](https://togithub.com/googleapis/java-shared-dependencies/blob/HEAD/CHANGELOG.md#&#8203;303-httpsgithubcomgoogleapisjava-shared-dependenciescomparev302v303-2022-09-14)

[Compare Source](https://togithub.com/googleapis/java-shared-dependencies/compare/v3.0.2...v3.0.3)

##### Dependencies

-   Google-cloud-core 2.8.12 ([#&#8203;799](https://togithub.com/googleapis/java-shared-dependencies/issues/799)) ([1b3db8d](https://togithub.com/googleapis/java-shared-dependencies/commit/1b3db8d1e17c49ebae79fc96164fa9058e1df6e3))
-   Moving gson to first-party-dependencies ([#&#8203;800](https://togithub.com/googleapis/java-shared-dependencies/issues/800)) ([a41fcc1](https://togithub.com/googleapis/java-shared-dependencies/commit/a41fcc11d32e02e5af2837561792e3919f6d4b3f))
-   Update dependency com.google.protobuf:protobuf-bom to v3.21.6 ([#&#8203;797](https://togithub.com/googleapis/java-shared-dependencies/issues/797)) ([bc5fdc9](https://togithub.com/googleapis/java-shared-dependencies/commit/bc5fdc9b3af7973c28f063a9ac156fe2af562814))
-   Update gax.version to v2.19.1 ([#&#8203;798](https://togithub.com/googleapis/java-shared-dependencies/issues/798)) ([84e5487](https://togithub.com/googleapis/java-shared-dependencies/commit/84e5487b2e3dce4bb60badecebde788c3cb702b8))
-   Update google.core.version to v2.8.11 ([#&#8203;793](https://togithub.com/googleapis/java-shared-dependencies/issues/793)) ([63c1297](https://togithub.com/googleapis/java-shared-dependencies/commit/63c129722aa0b821031ff5b4c11004adf7b12044))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dlp).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTUuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5NS41In0=-->
github-actions bot pushed a commit that referenced this pull request Sep 19, 2022
🤖 I have created a release *beep* *boop*
---


## [3.7.0](googleapis/java-dlp@v3.6.7...v3.7.0) (2022-09-15)


### Features

* Add Deidentify action ([#977](googleapis/java-dlp#977)) ([4f43cd5](googleapis/java-dlp@4f43cd5))


### Bug Fixes

* Update DeIdentificationTest ([#976](googleapis/java-dlp#976)) ([661f316](googleapis/java-dlp@661f316))


### Dependencies

* Update dependency com.google.cloud:google-cloud-pubsub to v1.120.11 ([#960](googleapis/java-dlp#960)) ([c66384d](googleapis/java-dlp@c66384d))
* Update dependency com.google.cloud:google-cloud-pubsub to v1.120.12 ([#969](googleapis/java-dlp#969)) ([586795f](googleapis/java-dlp@586795f))
* Update dependency com.google.cloud:google-cloud-pubsub to v1.120.13 ([#974](googleapis/java-dlp#974)) ([b37407b](googleapis/java-dlp@b37407b))
* Update dependency com.google.cloud:google-cloud-pubsub to v1.120.14 ([#982](googleapis/java-dlp#982)) ([8ac525a](googleapis/java-dlp@8ac525a))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#980](googleapis/java-dlp#980)) ([885dc15](googleapis/java-dlp@885dc15))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#984](googleapis/java-dlp#984)) ([8cd0a40](googleapis/java-dlp@8cd0a40))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Oct 5, 2022
🤖 I have created a release *beep* *boop*
---


## [3.1.2](https://togithub.com/googleapis/java-vision/compare/v3.1.1...v3.1.2) (2022-10-03)


### Documentation

* Update comments for image annotator OCR models ([#983](https://togithub.com/googleapis/java-vision/issues/983)) ([5c408fe](https://togithub.com/googleapis/java-vision/commit/5c408fef37777fb9899d9190b89896318f64d262))


### Dependencies

* Update dependency com.google.cloud:google-cloud-core to v2.8.12 ([#984](https://togithub.com/googleapis/java-vision/issues/984)) ([59f683c](https://togithub.com/googleapis/java-vision/commit/59f683ce1933b80a3b6256d9cf7f737c689ba711))
* Update dependency com.google.cloud:google-cloud-core to v2.8.13 ([#992](https://togithub.com/googleapis/java-vision/issues/992)) ([e0882e8](https://togithub.com/googleapis/java-vision/commit/e0882e83f338f4fb530a0c304dfa97bc1977fc56))
* Update dependency com.google.cloud:google-cloud-core to v2.8.14 ([#993](https://togithub.com/googleapis/java-vision/issues/993)) ([efd9c3f](https://togithub.com/googleapis/java-vision/commit/efd9c3fc7863dd4d819e9628d18bb43998f73ef8))
* Update dependency com.google.cloud:google-cloud-core to v2.8.18 ([#995](https://togithub.com/googleapis/java-vision/issues/995)) ([ead37cc](https://togithub.com/googleapis/java-vision/commit/ead37cc0cf1a1af8bb513d89153e30f06ea71f20))
* Update dependency com.google.cloud:google-cloud-core to v2.8.19 ([#1023](https://togithub.com/googleapis/java-vision/issues/1023)) ([ce23a3b](https://togithub.com/googleapis/java-vision/commit/ce23a3b2ae1c49a8df71fd66eda38f4845763cad))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#1026](https://togithub.com/googleapis/java-vision/issues/1026)) ([71a4c70](https://togithub.com/googleapis/java-vision/commit/71a4c70366ab05af1307d914975aa43a2e5679a7))
* Update dependency com.google.cloud:google-cloud-storage to v2.12.0 ([#986](https://togithub.com/googleapis/java-vision/issues/986)) ([08262f8](https://togithub.com/googleapis/java-vision/commit/08262f87c3ce67eed973ccf9fc2f1f63525f5857))
* Update spring.version to v2.7.4 ([#994](https://togithub.com/googleapis/java-vision/issues/994)) ([8688790](https://togithub.com/googleapis/java-vision/commit/868879044e4296f524d6157d37b8601a5fc8dc4d))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull request Feb 1, 2023
…984)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.protobuf:protobuf-bom](https://developers.google.com/protocol-buffers/) ([source](https://togithub.com/protocolbuffers/protobuf)) | `3.21.7` -> `3.21.8` | [![age](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.8/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.8/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.8/compatibility-slim/3.21.7)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.8/confidence-slim/3.21.7)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>protocolbuffers/protobuf</summary>

### [`v3.21.8`](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.7...v3.21.8)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMzguNCIsInVwZGF0ZWRJblZlciI6IjMyLjI0MC41In0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants