Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [cloudquotas] new module for cloudquotas #9991

Merged
merged 6 commits into from
Jan 8, 2024
Merged

feat: [cloudquotas] new module for cloudquotas #9991

merged 6 commits into from
Jan 8, 2024

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Oct 24, 2023 •
edited
Loading 

python3.9 generation/new_client/new-client.py generate \
  --api_shortname=cloudquotas \
  --proto-path=google/api/cloudquotas \
  --name-pretty="Cloud Quotas API" \
  --product-docs="https://cloud.google.com/cloudquotas/docs/" \
  --api-description="Cloud Quotas API provides GCP service consumers with management and
    observability for resource usage, quotas, and restrictions of the services
    they consume."

@snippet-bot
Copy link

snippet-bot bot commented Oct 24, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 32 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

meltsufin
meltsufin reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suztomo My only concern is that Maven group id is different from the GAPIC package. If that's OK, feel free to approve.

suztomo
suztomo approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think of a problem that would be caused by the groupId and Java package mismatch.

java-cloudquotas/google-cloud-cloudquotas/pom.xml
observability for resource usage, quotas, and restrictions of the services
they consume.</description>
<parent>
<groupId>com.google.cloud</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It got "com.google.cloud" appropriately.

.../google-cloud-cloudquotas/src/main/java/com/google/api/cloudquotas/v1/CloudQuotasClient.java
* limitations under the License.
*/

package com.google.api.cloudquotas.v1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated class has "com.google.api" (no "cloud")

@lqiu96
Copy link
Contributor Author

lqiu96 commented Oct 24, 2023 •
edited
Loading

Adding Do Not Merge for now. See b/307334197 and b/307334464 for more info.

@lqiu96 lqiu96 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 24, 2023
@diegomarquezp
Copy link
Contributor

cc: @ddixit14

@lqiu96 Looking at the updates on b/307334197 I think we can merge this PR now since we are almost past the freeze

@lqiu96
Copy link
Contributor Author

lqiu96 commented Jan 4, 2024

cc: @ddixit14

@lqiu96 Looking at the updates on b/307334197 I think we can merge this PR now since we are almost past the freeze

Thanks! Yep, I think you're right and this should be good to go. This library probably needs to be regenerated. @ddixit14 Feel to free to create a new branch/ PR and close this one if that's easier.

@lqiu96 lqiu96 requested a review from a team as a code owner January 8, 2024 18:30
@suztomo suztomo removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 8, 2024
@ddixit14 ddixit14 merged commit 0a11aac into main Jan 8, 2024
33 of 34 checks passed
@ddixit14 ddixit14 deleted the new_module_java-cloudquotas branch January 8, 2024 20:10
@release-please release-please bot mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddixit14 ddixit14 ddixit14 approved these changes

@meltsufin meltsufin meltsufin approved these changes

@suztomo suztomo suztomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lqiu96 @diegomarquezp @suztomo @meltsufin @ddixit14