Skip to content

Commit

Permalink
docs: BinaryAuthorization.enabled field is marked as deprecated (#556)
Browse files Browse the repository at this point in the history
* docs: BinaryAuthorization.enabled field is marked as deprecated

PiperOrigin-RevId: 464729666

Source-Link: googleapis/googleapis@c77c067

Source-Link: googleapis/googleapis-gen@68c2282
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjhjMjI4Mjg1MGFkZDE2ZGRhY2YzOTA2ZmYyZGFlODgwYmY5YjRjYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
  • Loading branch information
gcf-owl-bot[bot] and gcf-owl-bot[bot] authored Aug 2, 2022
1 parent ccea0d3 commit 0d10ed8
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1219,9 +1219,10 @@ message BinaryAuthorization {
PROJECT_SINGLETON_POLICY_ENFORCE = 2;
}

// Enable Binary Authorization for this cluster. If enabled, all container
// images will be validated by Binary Authorization.
bool enabled = 1;
// This field is deprecated. Leave this unset and instead configure
// BinaryAuthorization using evaluation_mode. If evaluation_mode is set to
// anything other than EVALUATION_MODE_UNSPECIFIED, this field is ignored.
bool enabled = 1 [deprecated = true];

// Mode of operation for binauthz policy evaluation. Currently the only
// options are equivalent to enable/disable. If unspecified, defaults to
Expand Down Expand Up @@ -1705,7 +1706,7 @@ message NodePoolDefaults {

// Subset of NodeConfig message that has defaults.
message NodeConfigDefaults {
// GCFS (Google Container File System, a.k.a. Riptide) options.
// GCFS (Google Container File System, also known as Riptide) options.
GcfsConfig gcfs_config = 1;
}

Expand Down Expand Up @@ -3203,7 +3204,7 @@ message SetNodePoolSizeRequest {
message CompleteNodePoolUpgradeRequest {
// The name (project, location, cluster, node pool id) of the node pool to
// complete upgrade.
// Specified in the format 'projects/*/locations/*/clusters/*/nodePools/*'.
// Specified in the format `projects/*/locations/*/clusters/*/nodePools/*`.
string name = 1;
}

Expand Down Expand Up @@ -3306,7 +3307,8 @@ message AutoprovisioningNodePoolDefaults {
// information, read [how to specify min CPU
// platform](https://cloud.google.com/compute/docs/instances/specify-min-cpu-platform)
// This field is deprecated, min_cpu_platform should be specified using
// cloud.google.com/requested-min-cpu-platform label selector on the pod.
// https://cloud.google.com/requested-min-cpu-platform label selector on the
// pod.
// To unset the min cpu platform field pass "automatic"
// as field value.
string min_cpu_platform = 5 [deprecated = true];
Expand Down
5 changes: 4 additions & 1 deletion packages/google-container/protos/protos.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function main() {
/**
* The name (project, location, cluster, node pool id) of the node pool to
* complete upgrade.
* Specified in the format 'projects/* /locations/* /clusters/* /nodePools/*'.
* Specified in the format `projects/* /locations/* /clusters/* /nodePools/*`.
*/
// const name = 'abc123'

Expand Down
2 changes: 1 addition & 1 deletion packages/google-container/src/v1/cluster_manager_client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2679,7 +2679,7 @@ export class ClusterManagerClient {
* @param {string} request.name
* The name (project, location, cluster, node pool id) of the node pool to
* complete upgrade.
* Specified in the format 'projects/* /locations/* /clusters/* /nodePools/*'.
* Specified in the format `projects/* /locations/* /clusters/* /nodePools/*`.
* @param {object} [options]
* Call options. See {@link https://googleapis.dev/nodejs/google-gax/latest/interfaces/CallOptions.html|CallOptions} for more details.
* @returns {Promise} - The promise which resolves to an array.
Expand Down

0 comments on commit 0d10ed8

Please sign in to comment.