Skip to content

Commit

Permalink
feat: [deploy] Add support for disabling Pod overprovisioning in the …
Browse files Browse the repository at this point in the history
…progressive deployment strategy configuration for a Kubernetes Target (#4317)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 537857136

Source-Link: https://togithub.com/googleapis/googleapis/commit/a7658127bcfc80102023ed0c4474f5a5c92813c1

Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/7c8cf36e390b92a2bc403b17d5fc2b59a60d8f85
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWRlcGxveS8uT3dsQm90LnlhbWwiLCJoIjoiN2M4Y2YzNmUzOTBiOTJhMmJjNDAzYjE3ZDVmYzJiNTlhNjBkOGY4NSJ9
  • Loading branch information
gcf-owl-bot[bot] authored Jun 6, 2023
1 parent d266f18 commit 10bb492
Show file tree
Hide file tree
Showing 8 changed files with 75 additions and 51 deletions.
59 changes: 29 additions & 30 deletions packages/google-cloud-deploy/README.md

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,13 @@ message KubernetesConfig {
// Required. Name of the Kubernetes Deployment whose traffic is managed by
// the specified Service.
string deployment = 2 [(google.api.field_behavior) = REQUIRED];

// Optional. Whether to disable Pod overprovisioning. If Pod
// overprovisioning is disabled then Cloud Deploy will limit the number of
// total Pods used for the deployment strategy to the number of Pods the
// Deployment has on the cluster.
bool disable_pod_overprovisioning = 3
[(google.api.field_behavior) = OPTIONAL];
}

// The service definition configuration.
Expand Down Expand Up @@ -1175,7 +1182,7 @@ message DeleteTargetRequest {
string request_id = 2 [(google.api.field_behavior) = OPTIONAL];

// Optional. If set to true, then deleting an already deleted or non-existing
// DeliveryPipeline will succeed.
// `Target` will succeed.
bool allow_missing = 3 [(google.api.field_behavior) = OPTIONAL];

// Optional. If set, validate the request and preview the review, but do not
Expand Down
6 changes: 6 additions & 0 deletions packages/google-cloud-deploy/protos/protos.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 23 additions & 0 deletions packages/google-cloud-deploy/protos/protos.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions packages/google-cloud-deploy/protos/protos.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 0 additions & 18 deletions packages/google-cloud-deploy/samples/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
* [Cloud_deploy.update_delivery_pipeline](#cloud_deploy.update_delivery_pipeline)
* [Cloud_deploy.update_target](#cloud_deploy.update_target)
* [Quickstart](#quickstart)
* [Quickstart](#quickstart)

## Before you begin

Expand Down Expand Up @@ -510,23 +509,6 @@ __Usage:__
`node packages/google-cloud-deploy/samples/quickstart.js`


-----




### Quickstart

View the [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-deploy/samples/test/quickstart.js).

[![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/google-cloud-node&page=editor&open_in_editor=packages/google-cloud-deploy/samples/test/quickstart.js,samples/README.md)

__Usage:__


`node packages/google-cloud-deploy/samples/test/quickstart.js`





Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ function main(name) {
// const requestId = 'abc123'
/**
* Optional. If set to true, then deleting an already deleted or non-existing
* DeliveryPipeline will succeed.
* `Target` will succeed.
*/
// const allowMissing = true
/**
Expand Down
2 changes: 1 addition & 1 deletion packages/google-cloud-deploy/src/v1/cloud_deploy_client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2585,7 +2585,7 @@ export class CloudDeployClient {
* not supported (00000000-0000-0000-0000-000000000000).
* @param {boolean} [request.allowMissing]
* Optional. If set to true, then deleting an already deleted or non-existing
* DeliveryPipeline will succeed.
* `Target` will succeed.
* @param {boolean} [request.validateOnly]
* Optional. If set, validate the request and preview the review, but do not
* actually post it.
Expand Down

0 comments on commit 10bb492

Please sign in to comment.