refactor: improve generated code style (#162)

googleapis · Feb 7, 2019 · 3b88059 · 3b88059
1 parent 37d0bcc
commit 3b88059
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 25 deletions.
diff --git a/packages/google-cloud-bigquery-datatransfer/smoke-test/data_transfer_service_smoke_test.js b/packages/google-cloud-bigquery-datatransfer/smoke-test/data_transfer_service_smoke_test.js
@@ -34,8 +34,8 @@ describe('DataTransferServiceSmokeTest', () => {
  .listDataSources({parent: formattedParent})
  .then(responses => {
  const resources = responses[0];
- for (let i = 0; i < resources.length; i += 1) {
- console.log(resources[i]);
+ for (const resource of resources) {
+ console.log(resource);
  }
  })
  .then(done)
@@ -60,8 +60,8 @@ describe('DataTransferServiceSmokeTest', () => {
  const nextRequest = responses[1];
  // The actual response object, if necessary.
  // const rawResponse = responses[2];
- for (let i = 0; i < resources.length; i += 1) {
- console.log(resources[i]);
+ for (const resource of resources) {
+ console.log(resource);
  }
  if (nextRequest) {
  // Fetch the next page.

diff --git a/packages/google-cloud-bigquery-datatransfer/src/v1/data_transfer_service_client.js b/packages/google-cloud-bigquery-datatransfer/src/v1/data_transfer_service_client.js
@@ -335,8 +335,8 @@ class DataTransferServiceClient {
  * client.listDataSources({parent: formattedParent})
  * .then(responses => {
  * const resources = responses[0];
- * for (let i = 0; i < resources.length; i += 1) {
- * // doThingsWith(resources[i])
+ * for (const resource of resources) {
+ * // doThingsWith(resource)
  * }
  * })
  * .catch(err => {
@@ -355,8 +355,8 @@ class DataTransferServiceClient {
  * const nextRequest = responses[1];
  * // The actual response object, if necessary.
  * // const rawResponse = responses[2];
- * for (let i = 0; i < resources.length; i += 1) {
- * // doThingsWith(resources[i]);
+ * for (const resource of resources) {
+ * // doThingsWith(resource);
  * }
  * if (nextRequest) {
  * // Fetch the next page.
@@ -760,8 +760,8 @@ class DataTransferServiceClient {
  * client.listTransferConfigs({parent: formattedParent})
  * .then(responses => {
  * const resources = responses[0];
- * for (let i = 0; i < resources.length; i += 1) {
- * // doThingsWith(resources[i])
+ * for (const resource of resources) {
+ * // doThingsWith(resource)
  * }
  * })
  * .catch(err => {
@@ -780,8 +780,8 @@ class DataTransferServiceClient {
  * const nextRequest = responses[1];
  * // The actual response object, if necessary.
  * // const rawResponse = responses[2];
- * for (let i = 0; i < resources.length; i += 1) {
- * // doThingsWith(resources[i]);
+ * for (const resource of resources) {
+ * // doThingsWith(resource);
  * }
  * if (nextRequest) {
  * // Fetch the next page.
@@ -1103,8 +1103,8 @@ class DataTransferServiceClient {
  * client.listTransferRuns({parent: formattedParent})
  * .then(responses => {
  * const resources = responses[0];
- * for (let i = 0; i < resources.length; i += 1) {
- * // doThingsWith(resources[i])
+ * for (const resource of resources) {
+ * // doThingsWith(resource)
  * }
  * })
  * .catch(err => {
@@ -1123,8 +1123,8 @@ class DataTransferServiceClient {
  * const nextRequest = responses[1];
  * // The actual response object, if necessary.
  * // const rawResponse = responses[2];
- * for (let i = 0; i < resources.length; i += 1) {
- * // doThingsWith(resources[i]);
+ * for (const resource of resources) {
+ * // doThingsWith(resource);
  * }
  * if (nextRequest) {
  * // Fetch the next page.
@@ -1275,8 +1275,8 @@ class DataTransferServiceClient {
  * client.listTransferLogs({parent: formattedParent})
  * .then(responses => {
  * const resources = responses[0];
- * for (let i = 0; i < resources.length; i += 1) {
- * // doThingsWith(resources[i])
+ * for (const resource of resources) {
+ * // doThingsWith(resource)
  * }
  * })
  * .catch(err => {
@@ -1295,8 +1295,8 @@ class DataTransferServiceClient {
  * const nextRequest = responses[1];
  * // The actual response object, if necessary.
  * // const rawResponse = responses[2];
- * for (let i = 0; i < resources.length; i += 1) {
- * // doThingsWith(resources[i]);
+ * for (const resource of resources) {
+ * // doThingsWith(resource);
  * }
  * if (nextRequest) {
  * // Fetch the next page.

diff --git a/packages/google-cloud-bigquery-datatransfer/synth.metadata b/packages/google-cloud-bigquery-datatransfer/synth.metadata
@@ -1,19 +1,19 @@
 {
- "updateTime": "2019-01-25T12:13:43.705956Z",
+ "updateTime": "2019-02-07T12:08:50.108535Z",
  "sources": [
  {
  "generator": {
  "name": "artman",
- "version": "0.16.7",
- "dockerImage": "googleapis/artman@sha256:d6c8ced606eb49973ca95d2af7c55a681acc042db0f87d135968349e7bf6dd80"
+ "version": "0.16.10",
+ "dockerImage": "googleapis/artman@sha256:0954ba3e40d694e631bb2f39460d502a3d9f3a66d40b7a9a67f4b30012195beb"
  }
  },
  {
  "git": {
  "name": "googleapis",
  "remote": "https://github.com/googleapis/googleapis.git",
- "sha": "9aac88a22468b1e291937f55fa1ef237adfdc63e",
- "internalRef": "230568136"
+ "sha": "49b7906ba5f15c1bc52bf5febc3bd0645d29b980",
+ "internalRef": "232773383"
  }
  },
  {