Skip to content

Commit

Permalink
chore: cleanup synth.py (#386)
Browse files Browse the repository at this point in the history
  • Loading branch information
xiaozhenliu-gg5 authored Apr 15, 2020
1 parent b415a54 commit 52984c1
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 10 deletions.
1 change: 0 additions & 1 deletion packages/google-cloud-automl/linkinator.config.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"recurse": true,
"concurrency": 10,
"skip": [
"https://codecov.io/gh/googleapis/",
"www.googleapis.com",
Expand Down
19 changes: 16 additions & 3 deletions packages/google-cloud-automl/synth.metadata
Original file line number Diff line number Diff line change
@@ -1,12 +1,25 @@
{
"updateTime": "2020-04-10T23:52:26.331147Z",
"sources": [
{
"git": {
"name": ".",
"remote": "git@github.com:googleapis/nodejs-automl.git",
"sha": "91df30b681cc6f03bcb41e389340418cb5bf488a"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "629e6bea8418ad4a5d081ab9eb48bb327ad368e1",
"internalRef": "306660765"
}
},
{
"git": {
"name": "synthtool",
"remote": "https://github.com/googleapis/synthtool.git",
"sha": "6f32150677c9784f3c3a7e1949472bd29c9d72c5",
"log": "6f32150677c9784f3c3a7e1949472bd29c9d72c5\nfix: installs test_utils from its common repo (#480)\n\n\n74ce986d3b5431eb66985e9a00c4eb45295a4020\nfix: stop recording update_time in synth.metadata (#478)\n\n\n7f8e62aa3edd225f76347a16f92e400661fdfb52\nchore(java): release-please only updates non maven versions in README (#476)\n\nPrevent release-please and synthtool from fighting over the released library version. Synthtool updates the install snippets from the samples pom.xml files so the bots fight if they are temporarily out of sync after a release.\nc7e0e517d7f46f77bebd27da2e5afcaa6eee7e25\nbuild(java): fix nightly integration test config to run integrations (#465)\n\nThis was only running the units.\nbd69a2aa7b70875f3c988e269706b22fefbef40e\nbuild(java): fix retry_with_backoff when -e option set (#475)\n\n\nd9b173c427bfa0c6cca818233562e7e8841a357c\nfix: record version of working repo in synth.metadata (#473)\n\nPartial revert of b37cf74d12e9a42b9de9e61a4f26133d7cd9c168.\nf73a541770d95a609e5be6bf6b3b220d17cefcbe\nfeat(discogapic): allow local discovery-artifact-manager (#474)\n\n\n8cf0f5d93a70c3dcb0b4999d3152c46d4d9264bf\ndoc: describe the Autosynth & Synthtool protocol (#472)\n\n* doc: describe the Autosynth & Synthtool protocol\n\n* Accommodate review comments.\n980baaa738a1ad8fa02b4fdbd56be075ee77ece5\nfix: pin sphinx to <3.0.0 as new version causes new error (#471)\n\nThe error `toctree contains reference to document changlelog that doesn't have a title: no link will be generated` occurs as of 3.0.0. Pinning to 2.x until we address the docs build issue.\n\nTowards #470\n\nI did this manually for python-datastore https://github.com/googleapis/python-datastore/pull/22\n928b2998ac5023e7c7e254ab935f9ef022455aad\nchore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.15 (#466)\n\nCo-authored-by: Jeffrey Rennie <rennie@google.com>\n188f1b1d53181f739b98f8aa5d40cfe99eb90c47\nfix: allow local and external deps to be specified (#469)\n\nModify noxfile.py to allow local and external dependencies for\nsystem tests to be specified.\n"
"sha": "85cbc7f954f4c4c3534f0caafbaed22a8f80f602"
}
}
],
Expand Down
6 changes: 2 additions & 4 deletions packages/google-cloud-automl/synth.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
'automl', version,
generator_args={
"grpc-service-config": f"google/cloud/automl/{version}/automl_grpc_service_config.json",
"package-name": f"@google-cloud/automl",
"main-service": f"automl"
"package-name": "@google-cloud/automl",
"main-service": "automl"
},
proto_path=f'/google/cloud/automl/{version}',
extra_proto_files=['google/cloud/common_resources.proto'],
Expand All @@ -41,8 +41,6 @@
templates = common_templates.node_library(source_location='build/src')
s.copy(templates)

linkinator_json="linkinator.config.json"
s.replace(linkinator_json, '"recurse": true,', '"recurse": true,\n\t"concurrency": 10,')
# Node.js specific cleanup
subprocess.run(['npm', 'install'])
subprocess.run(['npm', 'run', 'fix'])
Expand Down
4 changes: 2 additions & 2 deletions packages/google-cloud-automl/system-test/install.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import {readFileSync} from 'fs';
import {describe, it} from 'mocha';

describe('typescript consumer tests', () => {
it('should have correct type signature for typescript users', async function() {
it('should have correct type signature for typescript users', async function () {
this.timeout(300000);
const options = {
packageDir: process.cwd(), // path to your module.
Expand All @@ -35,7 +35,7 @@ describe('typescript consumer tests', () => {
await packNTest(options); // will throw upon error.
});

it('should have correct type signature for javascript users', async function() {
it('should have correct type signature for javascript users', async function () {
this.timeout(300000);
const options = {
packageDir: process.cwd(), // path to your module.
Expand Down

0 comments on commit 52984c1

Please sign in to comment.