fix: DEADLINE_EXCEEDED retry code is idempotent (#234)

googleapis · May 10, 2019 · 681fa9a · 681fa9a
1 parent 2e2dc6d
commit 681fa9a
Show file tree

Hide file tree

Showing 10 changed files with 15 additions and 8 deletions.
diff --git a/packages/google-cloud-videointelligence/src/v1/video_intelligence_service_client.js b/packages/google-cloud-videointelligence/src/v1/video_intelligence_service_client.js
@@ -269,7 +269,7 @@ class VideoIntelligenceServiceClient {
  * // optional auth parameters.
  * });
  *
- * const inputUri = 'gs://videodemomaker/cat.mp4';
+ * const inputUri = 'gs://cloud-samples-data/video/cat.mp4';
  * const featuresElement = 'LABEL_DETECTION';
  * const features = [featuresElement];
  * const request = {
@@ -294,7 +294,7 @@ class VideoIntelligenceServiceClient {
  * console.error(err);
  * });
  *
- * const inputUri = 'gs://videodemomaker/cat.mp4';
+ * const inputUri = 'gs://cloud-samples-data/video/cat.mp4';
  * const featuresElement = 'LABEL_DETECTION';
  * const features = [featuresElement];
  * const request = {
@@ -328,7 +328,7 @@ class VideoIntelligenceServiceClient {
  * console.error(err);
  * });
  *
- * const inputUri = 'gs://videodemomaker/cat.mp4';
+ * const inputUri = 'gs://cloud-samples-data/video/cat.mp4';
  * const featuresElement = 'LABEL_DETECTION';
  * const features = [featuresElement];
  * const request = {

diff --git a/packages/google-cloud-videointelligence/src/v1/video_intelligence_service_client_config.json b/packages/google-cloud-videointelligence/src/v1/video_intelligence_service_client_config.json
@@ -3,6 +3,7 @@
  "google.cloud.videointelligence.v1.VideoIntelligenceService": {
  "retry_codes": {
  "idempotent": [
+ "DEADLINE_EXCEEDED",
  "UNAVAILABLE"
  ],
  "non_idempotent": []

diff --git a/.../google-cloud-videointelligence/src/v1beta1/video_intelligence_service_client_config.json b/.../google-cloud-videointelligence/src/v1beta1/video_intelligence_service_client_config.json
@@ -3,6 +3,7 @@
  "google.cloud.videointelligence.v1beta1.VideoIntelligenceService": {
  "retry_codes": {
  "idempotent": [
+ "DEADLINE_EXCEEDED",
  "UNAVAILABLE"
  ],
  "non_idempotent": []

diff --git a/.../google-cloud-videointelligence/src/v1beta2/video_intelligence_service_client_config.json b/.../google-cloud-videointelligence/src/v1beta2/video_intelligence_service_client_config.json
@@ -3,6 +3,7 @@
  "google.cloud.videointelligence.v1beta2.VideoIntelligenceService": {
  "retry_codes": {
  "idempotent": [
+ "DEADLINE_EXCEEDED",
  "UNAVAILABLE"
  ],
  "non_idempotent": []

diff --git a/...oogle-cloud-videointelligence/src/v1p1beta1/video_intelligence_service_client_config.json b/...oogle-cloud-videointelligence/src/v1p1beta1/video_intelligence_service_client_config.json
@@ -3,6 +3,7 @@
  "google.cloud.videointelligence.v1p1beta1.VideoIntelligenceService": {
  "retry_codes": {
  "idempotent": [
+ "DEADLINE_EXCEEDED",
  "UNAVAILABLE"
  ],
  "non_idempotent": []

diff --git a/...oogle-cloud-videointelligence/src/v1p2beta1/video_intelligence_service_client_config.json b/...oogle-cloud-videointelligence/src/v1p2beta1/video_intelligence_service_client_config.json
@@ -3,6 +3,7 @@
  "google.cloud.videointelligence.v1p2beta1.VideoIntelligenceService": {
  "retry_codes": {
  "idempotent": [
+ "DEADLINE_EXCEEDED",
  "UNAVAILABLE"
  ],
  "non_idempotent": []

diff --git a/...d-videointelligence/src/v1p3beta1/streaming_video_intelligence_service_client_config.json b/...d-videointelligence/src/v1p3beta1/streaming_video_intelligence_service_client_config.json
@@ -3,6 +3,7 @@
  "google.cloud.videointelligence.v1p3beta1.StreamingVideoIntelligenceService": {
  "retry_codes": {
  "idempotent": [
+ "DEADLINE_EXCEEDED",
  "UNAVAILABLE"
  ],
  "non_idempotent": []

diff --git a/...oogle-cloud-videointelligence/src/v1p3beta1/video_intelligence_service_client_config.json b/...oogle-cloud-videointelligence/src/v1p3beta1/video_intelligence_service_client_config.json
@@ -3,6 +3,7 @@
  "google.cloud.videointelligence.v1p3beta1.VideoIntelligenceService": {
  "retry_codes": {
  "idempotent": [
+ "DEADLINE_EXCEEDED",
  "UNAVAILABLE"
  ],
  "non_idempotent": []

diff --git a/packages/google-cloud-videointelligence/synth.metadata b/packages/google-cloud-videointelligence/synth.metadata
@@ -1,5 +1,5 @@
 {
- "updateTime": "2019-05-09T11:25:45.168969Z",
+ "updateTime": "2019-05-10T12:18:43.741935Z",
  "sources": [
  {
  "generator": {
@@ -12,8 +12,8 @@
  "git": {
  "name": "googleapis",
  "remote": "https://github.com/googleapis/googleapis.git",
- "sha": "2f6e293d9a0097167ed5160fd366403c21b5fa49",
- "internalRef": "247230302"
+ "sha": "07883be5bf3c3233095e99d8e92b8094f5d7084a",
+ "internalRef": "247530843"
  }
  },
  {

diff --git a/packages/google-cloud-videointelligence/test/gapic-v1.js b/packages/google-cloud-videointelligence/test/gapic-v1.js
@@ -33,7 +33,7 @@ describe('VideoIntelligenceServiceClient', () => {
  );
 
  // Mock request
- const inputUri = 'gs://videodemomaker/cat.mp4';
+ const inputUri = 'gs://cloud-samples-data/video/cat.mp4';
  const featuresElement = 'LABEL_DETECTION';
  const features = [featuresElement];
  const request = {
@@ -74,7 +74,7 @@ describe('VideoIntelligenceServiceClient', () => {
  );
 
  // Mock request
- const inputUri = 'gs://videodemomaker/cat.mp4';
+ const inputUri = 'gs://cloud-samples-data/video/cat.mp4';
  const featuresElement = 'LABEL_DETECTION';
  const features = [featuresElement];
  const request = {