Skip to content

Commit

Permalink
docs: dont override inherited, but then overwritten methods
Browse files Browse the repository at this point in the history
  • Loading branch information
stephenplusplus committed Dec 3, 2014
1 parent 8fac3f2 commit a935b04
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
10 changes: 7 additions & 3 deletions docs/components/docs/docs.js
Original file line number Diff line number Diff line change
Expand Up @@ -181,24 +181,28 @@ angular

function getMixIns($sce, $q, $http, version, baseUrl) {
return function(data) {
var classMethodNames = data.map(function(method) {
return method.name;
});
var methodWithMixIns = data.filter(function(method) {
return method.mixes.length > 0;
})[0];
if (!methodWithMixIns) {
return data;
}
return $q
.all(getMixInMethods(methodWithMixIns))
.all(getMixInMethods(classMethodNames, methodWithMixIns))
.then(combineMixInMethods(data));
};
function getMixInMethods(method) {
function getMixInMethods(classMethodNames, method) {
return method.mixes.map(function (module) {
module = module.string.trim().replace('module:', '');
return $http.get(baseUrl + '/' + module + '.json')
.then(filterDocJson($sce, version))
.then(function(mixInData) {
return mixInData.filter(function(method) {
return !method.constructor;
return !method.constructor &&
classMethodNames.indexOf(method.name) === -1;
});
});
});
Expand Down
2 changes: 0 additions & 2 deletions lib/datastore/transaction.js
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,6 @@ Transaction.prototype.commit = function(callback) {
* transaction.
*
* @param {Key|Key[]} key - Datastore key object(s).
* @param {function} callback - The callback function.
*
* @example
* // Delete a single entity.
Expand Down Expand Up @@ -303,7 +302,6 @@ Transaction.prototype.delete = function(entities) {
* If you provide an array of objects, you must use the explicit syntax:
* `name` for the name of the property and `value` for its value. You may
* also specify an `excludeFromIndexes` property, set to `true` or `false`.
* @param {function} callback - The callback function.
*
* @example
* //-
Expand Down

0 comments on commit a935b04

Please sign in to comment.