feat: support apiEndpoint override in client constructor (#206)

googleapis · Jun 5, 2019 · bcfcb97 · bcfcb97
1 parent 11bfd8d
commit bcfcb97
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/packages/google-cloud-oslogin/src/v1beta/os_login_service_client.js b/packages/google-cloud-oslogin/src/v1beta/os_login_service_client.js
@@ -58,6 +58,7 @@ class OsLoginServiceClient {
  * API remote host.
  */
  constructor(opts) {
+ opts = opts || {};
  this._descriptors = {};
 
  const servicePath =

diff --git a/packages/google-cloud-oslogin/synth.metadata b/packages/google-cloud-oslogin/synth.metadata
@@ -1,19 +1,19 @@
 {
- "updateTime": "2019-06-04T19:38:15.784953Z",
+ "updateTime": "2019-06-05T11:11:11.250834Z",
  "sources": [
  {
  "generator": {
  "name": "artman",
- "version": "0.23.0",
- "dockerImage": "googleapis/artman@sha256:846102ebf7ea2239162deea69f64940443b4147f7c2e68d64b332416f74211ba"
+ "version": "0.23.1",
+ "dockerImage": "googleapis/artman@sha256:9d5cae1454da64ac3a87028f8ef486b04889e351c83bb95e83b8fab3959faed0"
  }
  },
  {
  "git": {
  "name": "googleapis",
  "remote": "https://github.com/googleapis/googleapis.git",
- "sha": "0026f4b890ed9e2388fb0573c0727defa6f5b82e",
- "internalRef": "251265049"
+ "sha": "4f3516a6f96dac182973a3573ff5117e8e4f76c7",
+ "internalRef": "251559960"
  }
  },
  {

diff --git a/packages/google-cloud-oslogin/test/gapic-v1beta.js b/packages/google-cloud-oslogin/test/gapic-v1beta.js
@@ -39,6 +39,11 @@ describe('OsLoginServiceClient', () => {
  assert(typeof port === 'number');
  });
 
+ it('should create a client with no options', () => {
+ const client = new osLoginModule.v1beta.OsLoginServiceClient();
+ assert(client);
+ });
+
  describe('deletePosixAccount', () => {
  it('invokes deletePosixAccount without error', done => {
  const client = new osLoginModule.v1beta.OsLoginServiceClient({