Skip to content

Commit

Permalink
build(npm): correct artifact name for npm (#96)
Browse files Browse the repository at this point in the history
fix: Mark a couple networkconnectivity API fields as required, to match implemented behavior
docs(samples): add example tags to generated samples
PiperOrigin-RevId: 408969147
PiperOrigin-RevId: 411807571
PiperOrigin-RevId: 408439482
Source-Link: googleapis/googleapis-gen@5bca272
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWJjYTI3MjRlOGQ0NGIxM2ViNDFhNTZjNDg4MjhhYTAyM2VmZmEyMyJ9
  • Loading branch information
gcf-owl-bot[bot] authored Nov 23, 2021
1 parent b80a4b7 commit e487bb0
Show file tree
Hide file tree
Showing 26 changed files with 2,058 additions and 736 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
"img.shields.io"
],
"silent": true,
"concurrency": 10
"concurrency": 5
}
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,8 @@ service HubService {
}
}

// A hub is essentially a collection of spokes. A single hub can contain spokes
// from multiple regions. However, all of a hub's spokes must be associated with
// A hub is a collection of spokes. A single hub can contain spokes from
// multiple regions. However, all of a hub's spokes must be associated with
// resources that reside in the same VPC network.
message Hub {
option (google.api.resource) = {
Expand Down Expand Up @@ -225,10 +225,10 @@ enum State {
DELETING = 3;
}

// RoutingsVPC contains information about a VPC network that is associated with
// RoutingVPC contains information about the VPC network that is associated with
// a hub's spokes.
message RoutingVPC {
// The URI of a VPC network.
// The URI of the VPC network.
string uri = 1 [(google.api.resource_reference) = {
type: "compute.googleapis.com/Network"
}];
Expand Down Expand Up @@ -268,7 +268,7 @@ message Spoke {
// An optional description of the spoke.
string description = 5;

// Immutable. The URI of the hub that this spoke is attached to.
// Immutable. The name of the hub that this spoke is attached to.
string hub = 6 [
(google.api.field_behavior) = IMMUTABLE,
(google.api.resource_reference) = {
Expand Down Expand Up @@ -351,8 +351,8 @@ message CreateHubRequest {
}
];

// Optional. A unique identifier for the hub.
string hub_id = 2 [(google.api.field_behavior) = OPTIONAL];
// Required. A unique identifier for the hub.
string hub_id = 2 [(google.api.field_behavior) = REQUIRED];

// Required. The initial values for a new hub.
Hub hub = 3 [(google.api.field_behavior) = REQUIRED];
Expand Down Expand Up @@ -487,8 +487,8 @@ message CreateSpokeRequest {
}
];

// Optional. Unique id for the spoke to create.
string spoke_id = 2 [(google.api.field_behavior) = OPTIONAL];
// Required. Unique id for the spoke to create.
string spoke_id = 2 [(google.api.field_behavior) = REQUIRED];

// Required. The initial values for a new spoke.
Spoke spoke = 3 [(google.api.field_behavior) = REQUIRED];
Expand Down
4 changes: 2 additions & 2 deletions packages/google-cloud-networkconnectivity/protos/protos.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
// Copyright 2021 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

'use strict';

function main(parent, hubId, hub) {
// [START networkconnectivity_v1_generated_HubService_CreateHub_async]
/**
* TODO(developer): Uncomment these variables before running the sample.
*/
/**
* Required. The parent resource.
*/
// const parent = 'abc123'
/**
* Required. A unique identifier for the hub.
*/
// const hubId = 'abc123'
/**
* Required. The initial values for a new hub.
*/
// const hub = {}
/**
* Optional. A unique request ID (optional). If you specify this ID, you can use it
* in cases when you need to retry your request. When you need to retry, this
* ID lets the server know that it can ignore the request if it has already
* been completed. The server guarantees that for at least 60 minutes after
* the first request.
* For example, consider a situation where you make an initial request and
* the request times out. If you make the request again with the same request
* ID, the server can check to see whether the original operation
* was received. If it was, the server ignores the second request. This
* behavior prevents clients from mistakenly creating duplicate commitments.
* The request ID must be a valid UUID, with the exception that zero UUID is
* not supported (00000000-0000-0000-0000-000000000000).
*/
// const requestId = 'abc123'

// Imports the Networkconnectivity library
const {HubServiceClient} = require('@google-cloud/network-connectivity').v1;

// Instantiates a client
const networkconnectivityClient = new HubServiceClient();

async function callCreateHub() {
// Construct request
const request = {
parent,
hubId,
hub,
};

// Run request
const [operation] = await networkconnectivityClient.createHub(request);
const [response] = await operation.promise();
console.log(response);
}

callCreateHub();
// [END networkconnectivity_v1_generated_HubService_CreateHub_async]
}

process.on('unhandledRejection', err => {
console.error(err.message);
process.exitCode = 1;
});
main(...process.argv.slice(2));
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
// Copyright 2021 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

'use strict';

function main(parent, spokeId, spoke) {
// [START networkconnectivity_v1_generated_HubService_CreateSpoke_async]
/**
* TODO(developer): Uncomment these variables before running the sample.
*/
/**
* Required. The parent resource.
*/
// const parent = 'abc123'
/**
* Required. Unique id for the spoke to create.
*/
// const spokeId = 'abc123'
/**
* Required. The initial values for a new spoke.
*/
// const spoke = {}
/**
* Optional. A unique request ID (optional). If you specify this ID, you can use it
* in cases when you need to retry your request. When you need to retry, this
* ID lets the server know that it can ignore the request if it has already
* been completed. The server guarantees that for at least 60 minutes after
* the first request.
* For example, consider a situation where you make an initial request and
* the request times out. If you make the request again with the same request
* ID, the server can check to see whether the original operation
* was received. If it was, the server ignores the second request. This
* behavior prevents clients from mistakenly creating duplicate commitments.
* The request ID must be a valid UUID, with the exception that zero UUID is
* not supported (00000000-0000-0000-0000-000000000000).
*/
// const requestId = 'abc123'

// Imports the Networkconnectivity library
const {HubServiceClient} = require('@google-cloud/network-connectivity').v1;

// Instantiates a client
const networkconnectivityClient = new HubServiceClient();

async function callCreateSpoke() {
// Construct request
const request = {
parent,
spokeId,
spoke,
};

// Run request
const [operation] = await networkconnectivityClient.createSpoke(request);
const [response] = await operation.promise();
console.log(response);
}

callCreateSpoke();
// [END networkconnectivity_v1_generated_HubService_CreateSpoke_async]
}

process.on('unhandledRejection', err => {
console.error(err.message);
process.exitCode = 1;
});
main(...process.argv.slice(2));
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
// Copyright 2021 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

'use strict';

function main(name) {
// [START networkconnectivity_v1_generated_HubService_DeleteHub_async]
/**
* TODO(developer): Uncomment these variables before running the sample.
*/
/**
* Required. The name of the hub to delete.
*/
// const name = 'abc123'
/**
* Optional. A unique request ID (optional). If you specify this ID, you can use it
* in cases when you need to retry your request. When you need to retry, this
* ID lets the server know that it can ignore the request if it has already
* been completed. The server guarantees that for at least 60 minutes after
* the first request.
* For example, consider a situation where you make an initial request and
* the request times out. If you make the request again with the same request
* ID, the server can check to see whether the original operation
* was received. If it was, the server ignores the second request. This
* behavior prevents clients from mistakenly creating duplicate commitments.
* The request ID must be a valid UUID, with the exception that zero UUID is
* not supported (00000000-0000-0000-0000-000000000000).
*/
// const requestId = 'abc123'

// Imports the Networkconnectivity library
const {HubServiceClient} = require('@google-cloud/network-connectivity').v1;

// Instantiates a client
const networkconnectivityClient = new HubServiceClient();

async function callDeleteHub() {
// Construct request
const request = {
name,
};

// Run request
const [operation] = await networkconnectivityClient.deleteHub(request);
const [response] = await operation.promise();
console.log(response);
}

callDeleteHub();
// [END networkconnectivity_v1_generated_HubService_DeleteHub_async]
}

process.on('unhandledRejection', err => {
console.error(err.message);
process.exitCode = 1;
});
main(...process.argv.slice(2));
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
// Copyright 2021 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

'use strict';

function main(name) {
// [START networkconnectivity_v1_generated_HubService_DeleteSpoke_async]
/**
* TODO(developer): Uncomment these variables before running the sample.
*/
/**
* Required. The name of the spoke to delete.
*/
// const name = 'abc123'
/**
* Optional. A unique request ID (optional). If you specify this ID, you can use it
* in cases when you need to retry your request. When you need to retry, this
* ID lets the server know that it can ignore the request if it has already
* been completed. The server guarantees that for at least 60 minutes after
* the first request.
* For example, consider a situation where you make an initial request and
* the request times out. If you make the request again with the same request
* ID, the server can check to see whether the original operation
* was received. If it was, the server ignores the second request. This
* behavior prevents clients from mistakenly creating duplicate commitments.
* The request ID must be a valid UUID, with the exception that zero UUID is
* not supported (00000000-0000-0000-0000-000000000000).
*/
// const requestId = 'abc123'

// Imports the Networkconnectivity library
const {HubServiceClient} = require('@google-cloud/network-connectivity').v1;

// Instantiates a client
const networkconnectivityClient = new HubServiceClient();

async function callDeleteSpoke() {
// Construct request
const request = {
name,
};

// Run request
const [operation] = await networkconnectivityClient.deleteSpoke(request);
const [response] = await operation.promise();
console.log(response);
}

callDeleteSpoke();
// [END networkconnectivity_v1_generated_HubService_DeleteSpoke_async]
}

process.on('unhandledRejection', err => {
console.error(err.message);
process.exitCode = 1;
});
main(...process.argv.slice(2));
Loading

0 comments on commit e487bb0

Please sign in to comment.