Skip to content

Commit

Permalink
docs: Clarified that event_time can also be considered as the "update…
Browse files Browse the repository at this point in the history
… time" for a Finding. It also captures when a Finding was updated. The previous wording could've been interpreted as only the creation time. (#321)

PiperOrigin-RevId: 327292977

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Aug 18 13:17:43 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 623a1aa03ae7a031b50be54df78263da2f22e981
Source-Link: googleapis/googleapis@623a1aa
  • Loading branch information
yoshi-automation authored Aug 20, 2020
1 parent 9c88718 commit f87834b
Show file tree
Hide file tree
Showing 4 changed files with 126 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,11 @@ message Finding {
// to the finding.
SecurityMarks security_marks = 8 [(google.api.field_behavior) = OUTPUT_ONLY];

// The time at which the event took place. For example, if the finding
// represents an open firewall it would capture the time the detector believes
// the firewall became open. The accuracy is determined by the detector.
// The time at which the event took place, or when an update to the finding
// occurred. For example, if the finding represents an open firewall it would
// capture the time the detector believes the firewall became open. The
// accuracy is determined by the detector. If the finding were to be resolved
// afterward, this time would reflect when the finding was resolved.
google.protobuf.Timestamp event_time = 9;

// The time at which the finding was created in Security Command Center.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ syntax = "proto3";

package google.cloud.securitycenter.v1beta1;

import "google/api/annotations.proto";
import "google/api/field_behavior.proto";
import "google/api/resource.proto";
import "google/cloud/securitycenter/v1beta1/security_marks.proto";
import "google/protobuf/struct.proto";
import "google/protobuf/timestamp.proto";
import "google/api/annotations.proto";

option go_package = "google.golang.org/genproto/googleapis/cloud/securitycenter/v1beta1;securitycenter";
option java_multiple_files = true;
Expand Down Expand Up @@ -58,7 +58,8 @@ message Finding {
// "organizations/{organization_id}/sources/{source_id}/findings/{finding_id}"
string name = 1;

// Immutable. The relative resource name of the source the finding belongs to. See:
// Immutable. The relative resource name of the source the finding belongs to.
// See:
// https://cloud.google.com/apis/design/resource_names#relative_resource_name
// This field is immutable after creation time.
// For example:
Expand Down Expand Up @@ -97,9 +98,11 @@ message Finding {
// to the finding.
SecurityMarks security_marks = 8 [(google.api.field_behavior) = OUTPUT_ONLY];

// The time at which the event took place. For example, if the finding
// represents an open firewall it would capture the time the detector believes
// the firewall became open. The accuracy is determined by the detector.
// The time at which the event took place, or when an update to the finding
// occurred. For example, if the finding represents an open firewall it would
// capture the time the detector believes the firewall became open. The
// accuracy is determined by the detector. If the finding were to be resolved
// afterward, this time would reflect when the finding was resolved.
google.protobuf.Timestamp event_time = 9;

// The time at which the finding was created in Security Command Center.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,11 @@ message Finding {
// to the finding.
SecurityMarks security_marks = 8 [(google.api.field_behavior) = OUTPUT_ONLY];

// The time at which the event took place. For example, if the finding
// represents an open firewall it would capture the time the detector believes
// the firewall became open. The accuracy is determined by the detector.
// The time at which the event took place, or when an update to the finding
// occurred. For example, if the finding represents an open firewall it would
// capture the time the detector believes the firewall became open. The
// accuracy is determined by the detector. If the finding were to be resolved
// afterward, this time would reflect when the finding was resolved.
google.protobuf.Timestamp event_time = 9;

// The time at which the finding was created in Security Command Center.
Expand Down
111 changes: 108 additions & 3 deletions packages/google-cloud-securitycenter/synth.metadata
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
"git": {
"name": ".",
"remote": "https://github.com/googleapis/nodejs-security-center.git",
"sha": "fa72ab5a4bab1aa8add1f685d131005a866b5789"
"sha": "2de177d75b5e40a323b8ce2b8bbe3f839cc7c68b"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "5ad09e867a8f1faa19fbd674e51fa9c3f5fe2770",
"internalRef": "326514554"
"sha": "623a1aa03ae7a031b50be54df78263da2f22e981",
"internalRef": "327292977"
}
},
{
Expand Down Expand Up @@ -51,5 +51,110 @@
"generator": "bazel"
}
}
],
"generatedFiles": [
".eslintignore",
".eslintrc.json",
".gitattributes",
".github/ISSUE_TEMPLATE/bug_report.md",
".github/ISSUE_TEMPLATE/feature_request.md",
".github/ISSUE_TEMPLATE/support_request.md",
".github/PULL_REQUEST_TEMPLATE.md",
".github/publish.yml",
".github/release-please.yml",
".github/workflows/ci.yaml",
".gitignore",
".jsdoc.js",
".kokoro/.gitattributes",
".kokoro/common.cfg",
".kokoro/continuous/node10/common.cfg",
".kokoro/continuous/node10/docs.cfg",
".kokoro/continuous/node10/lint.cfg",
".kokoro/continuous/node10/samples-test.cfg",
".kokoro/continuous/node10/system-test.cfg",
".kokoro/continuous/node10/test.cfg",
".kokoro/continuous/node12/common.cfg",
".kokoro/continuous/node12/test.cfg",
".kokoro/docs.sh",
".kokoro/lint.sh",
".kokoro/populate-secrets.sh",
".kokoro/presubmit/node10/common.cfg",
".kokoro/presubmit/node10/samples-test.cfg",
".kokoro/presubmit/node10/system-test.cfg",
".kokoro/presubmit/node12/common.cfg",
".kokoro/presubmit/node12/test.cfg",
".kokoro/publish.sh",
".kokoro/release/docs-devsite.cfg",
".kokoro/release/docs-devsite.sh",
".kokoro/release/docs.cfg",
".kokoro/release/docs.sh",
".kokoro/release/publish.cfg",
".kokoro/system-test.sh",
".kokoro/test.bat",
".kokoro/test.sh",
".kokoro/trampoline.sh",
".mocharc.js",
".nycrc",
".prettierignore",
".prettierrc.js",
"CODE_OF_CONDUCT.md",
"CONTRIBUTING.md",
"LICENSE",
"README.md",
"api-extractor.json",
"linkinator.config.json",
"protos/google/cloud/securitycenter/v1/asset.proto",
"protos/google/cloud/securitycenter/v1/finding.proto",
"protos/google/cloud/securitycenter/v1/notification_config.proto",
"protos/google/cloud/securitycenter/v1/notification_message.proto",
"protos/google/cloud/securitycenter/v1/organization_settings.proto",
"protos/google/cloud/securitycenter/v1/resource.proto",
"protos/google/cloud/securitycenter/v1/run_asset_discovery_response.proto",
"protos/google/cloud/securitycenter/v1/security_marks.proto",
"protos/google/cloud/securitycenter/v1/securitycenter_service.proto",
"protos/google/cloud/securitycenter/v1/source.proto",
"protos/google/cloud/securitycenter/v1beta1/asset.proto",
"protos/google/cloud/securitycenter/v1beta1/finding.proto",
"protos/google/cloud/securitycenter/v1beta1/organization_settings.proto",
"protos/google/cloud/securitycenter/v1beta1/run_asset_discovery_response.proto",
"protos/google/cloud/securitycenter/v1beta1/security_marks.proto",
"protos/google/cloud/securitycenter/v1beta1/securitycenter_service.proto",
"protos/google/cloud/securitycenter/v1beta1/source.proto",
"protos/google/cloud/securitycenter/v1p1beta1/asset.proto",
"protos/google/cloud/securitycenter/v1p1beta1/finding.proto",
"protos/google/cloud/securitycenter/v1p1beta1/notification_config.proto",
"protos/google/cloud/securitycenter/v1p1beta1/notification_message.proto",
"protos/google/cloud/securitycenter/v1p1beta1/organization_settings.proto",
"protos/google/cloud/securitycenter/v1p1beta1/resource.proto",
"protos/google/cloud/securitycenter/v1p1beta1/run_asset_discovery_response.proto",
"protos/google/cloud/securitycenter/v1p1beta1/security_marks.proto",
"protos/google/cloud/securitycenter/v1p1beta1/securitycenter_service.proto",
"protos/google/cloud/securitycenter/v1p1beta1/source.proto",
"protos/protos.d.ts",
"protos/protos.js",
"protos/protos.json",
"renovate.json",
"samples/README.md",
"src/index.ts",
"src/v1/index.ts",
"src/v1/security_center_client.ts",
"src/v1/security_center_client_config.json",
"src/v1/security_center_proto_list.json",
"src/v1beta1/index.ts",
"src/v1beta1/security_center_client.ts",
"src/v1beta1/security_center_client_config.json",
"src/v1beta1/security_center_proto_list.json",
"src/v1p1beta1/index.ts",
"src/v1p1beta1/security_center_client.ts",
"src/v1p1beta1/security_center_client_config.json",
"src/v1p1beta1/security_center_proto_list.json",
"system-test/fixtures/sample/src/index.js",
"system-test/fixtures/sample/src/index.ts",
"system-test/install.ts",
"test/gapic_security_center_v1.ts",
"test/gapic_security_center_v1beta1.ts",
"test/gapic_security_center_v1p1beta1.ts",
"tsconfig.json",
"webpack.config.js"
]
}

0 comments on commit f87834b

Please sign in to comment.