Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it worth adding an adaptor to make SocketCluster client work with PubSub? #703

Closed
jgeewax opened this issue Jul 6, 2015 · 8 comments
Closed
Assignees
Labels
api: pubsub Issues related to the Pub/Sub API. type: question Request for information or clarification. Not an issue.

Comments

@jgeewax
Copy link
Contributor

jgeewax commented Jul 6, 2015

Docs: http://socketcluster.io/#!/docs/middleware-and-authorization

@jgeewax jgeewax added type: question Request for information or clarification. Not an issue. api: pubsub Issues related to the Pub/Sub API. labels Jul 6, 2015
@stephenplusplus
Copy link
Contributor

Definitely 👍 I'll try to play with this soon, probably after getting us on v1 of PubSub (#699).

@stephenplusplus stephenplusplus self-assigned this Jul 6, 2015
@stephenplusplus stephenplusplus removed their assignment Aug 14, 2015
@stephenplusplus
Copy link
Contributor

@callmehiphop did some playing around with this and got further than I did. Do you have any examples of what the integration looks like or questions, issues, etc?

@callmehiphop
Copy link
Contributor

I haven't played with it for too long, but integration doesn't look to be very difficult. Socketcluster emits events allowing you subscribe, unsubscribe and publish respectively.

My questions mostly revolve around PubSub because of my lack of familiarity with it -- I'm not sure if I should be creating topics/subscriptions or if those should have been created previously via dev console, etc.

Here is a (bad) example of how you would integrate a backend service with Socketcluster.

@stephenplusplus
Copy link
Contributor

@tmatsuo - can you help explain the basics of integrating with this library? (See @callmehiphop's questions above)

@stephenplusplus
Copy link
Contributor

Ping @tmatsuo. Is this an integration worth making?

@tmatsuo
Copy link
Contributor

tmatsuo commented Jan 26, 2016

Sorry I missed the comment above somehow. Honestly I'm not sure about your question without knowing sockercluster more.

@landrito landrito added priority: p2 Moderately-important priority. Fix may not be included in next release. Status: Acknowledged labels Mar 7, 2017
@stephenplusplus
Copy link
Contributor

@lukesneeringer This issue dates back a couple of years, when we were trying to find ways to show integrations with what we were building and other libraries that already existed in the same space. Things have changed since then, with cloud.google.com now showing integrations via tutorials and QuickStarts.

Should we look at this request in a modern light and consider including integrations as part of in-repo samples? Leave it to the docs writers to mention in cloud.google.com documentation? Drop the idea of integrations altogether?

@stephenplusplus
Copy link
Contributor

Please re-open if there's more to do here.

@stephenplusplus stephenplusplus removed the priority: p2 Moderately-important priority. Fix may not be included in next release. label Nov 27, 2017
sofisl pushed a commit that referenced this issue Sep 27, 2022
#703)

* build(node): add feat in node post-processor to add client library version number in snippet metadata

Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Source-Link: googleapis/synthtool@d337b88
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:d106724ad2a96daa1b8d88de101ba50bdb30b8df62ffa0aa2b451d93b4556641
sofisl pushed a commit that referenced this issue Nov 9, 2022
#703)

* build(node): add feat in node post-processor to add client library version number in snippet metadata

Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Source-Link: googleapis/synthtool@d337b88
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:d106724ad2a96daa1b8d88de101ba50bdb30b8df62ffa0aa2b451d93b4556641
sofisl pushed a commit that referenced this issue Jan 10, 2023
#703)

* build(node): add feat in node post-processor to add client library version number in snippet metadata

Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Source-Link: googleapis/synthtool@d337b88
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:d106724ad2a96daa1b8d88de101ba50bdb30b8df62ffa0aa2b451d93b4556641
sofisl pushed a commit that referenced this issue Sep 13, 2023
* chore(main): release 3.1.3

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

5 participants