Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated cluster links and option handling #1420

Merged
merged 2 commits into from
Jul 12, 2016
Merged

updated cluster links and option handling #1420

merged 2 commits into from
Jul 12, 2016

Conversation

callmehiphop
Copy link
Contributor

This fixes 2 things:

  1. The old documentation for creating clusters went missing, so updates were made to several links
  2. Certain options were not being preserved when not using default application credentials.

@callmehiphop callmehiphop added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: bigtable Issues related to the Bigtable API. labels Jul 12, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 12, 2016
@callmehiphop
Copy link
Contributor Author

@lesv we noticed that one can optionally provide an API key instead of a keyfile or default application creds. Is there a standard way of providing said key?

@stephenplusplus
Copy link
Contributor

Throwing a test on here would be good.

@coveralls
Copy link

coveralls commented Jul 12, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 2b31d15 on callmehiphop:bigtable-auth-fixes into 96eb260 on GoogleCloudPlatform:master.

callmehiphop
callmehiphop reviewed Jul 12, 2016
View reviewed changes
test/bigtable/index.js
@@ -110,6 +110,24 @@ describe('Bigtable', function() {
fakeUtil.normalizeArguments = normalizeArguments;
});

it('should leave the original options unaltered', function() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

coveralls commented Jul 12, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling ba265a8 on callmehiphop:bigtable-auth-fixes into 96eb260 on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit 3f01f61 into googleapis:master Jul 12, 2016
@stephenplusplus stephenplusplus mentioned this pull request Jul 12, 2016
Closed
This was referenced Jul 11, 2023
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stephenplusplus stephenplusplus

Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@callmehiphop @stephenplusplus @coveralls @googlebot