system tests (logging): increase consistency delay #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
stephenplusplus
added
testing
api: logging
|
We hit a small bump in our processing pipeline earlier today, probably that's why there were failures. |
stephenplusplus
force-pushed
the
spp--logging-test-rm-delay
branch
from
5e80899 to
0c438e4
Compare
stephenplusplus
changed the title
googlebot
added
the
cla: yes
|
Ah, okay. Thanks for the info. I've updated the tests to allow 60 seconds before validating the entries. |
This was referenced Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent push to master has introduced a new failed build (https://travis-ci.org/GoogleCloudPlatform/gcloud-node/jobs/145544257#L7638). We currently have two tests that will write log entries, then verify they were written properly by calling
getEntries. We have a "write consistency delay" of 15 seconds that has worked in the past, but after testing with up to 2 minutes now, the call togetEntriesstill pulls old data.This PR removes the delay, and simply checks that the "write entries" call doesn't fail.
@filipjs -- is there any reliable way to write a log entry, then pull it down from
getEntries({ orderBy: 'timestamp desc', pageSize: 1 })?