Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language: add promise support #1706

Merged
merged 1 commit into from
Oct 17, 2016
Merged

language: add promise support #1706

merged 1 commit into from
Oct 17, 2016

Conversation

callmehiphop
Copy link
Contributor

Breaking changes ahead! ⚠️

This adds Promise support for the @google-cloud/language module!

Summary of changes

Each callback accepting change has also been updated to return a Promise instance in the event that thecallback was omitted.

@callmehiphop callmehiphop added the api: language Issues related to the Cloud Natural Language API API. label Oct 17, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 17, 2016
@callmehiphop callmehiphop mentioned this pull request Oct 17, 2016
Closed
48 tasks
@stephenplusplus stephenplusplus merged commit 65a10e1 into googleapis:master Oct 17, 2016
sofisl pushed a commit that referenced this pull request Oct 11, 2022
@callmehiphop @stephenplusplus
language: add promise support (#1706)
75beffc
@sofisl sofisl mentioned this pull request Oct 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@callmehiphop @sofisl
language: add promise support (#1706)
d9a4160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stephenplusplus stephenplusplus

Labels
api: language Issues related to the Cloud Natural Language API API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@callmehiphop @stephenplusplus @googlebot