-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate existing GAPIC auto-generated files. #1721
Conversation
Thank you! I'm going to mark this PR as don't merge while I pull pieces from it and update our APIs one at a time. |
@jmuk -- I tried to run the Language system tests and got an error:
|
Wait, diving deeper gave me some more info: { Error: Exception occurred in retry method that was not classified as transient
at Object.callback (/Users/stephen/dev/gcloud-node/packages/language/node_modules/google-gax/lib/api_callable.js:147:19)
at /Users/stephen/dev/gcloud-node/packages/language/node_modules/grpc/src/node/src/client.js:420:14
cause:
{ Error: The document.type is not specified
at /Users/stephen/dev/gcloud-node/packages/language/node_modules/grpc/src/node/src/client.js:417:17 code: 3, metadata: Metadata { _internal_repr: [Object] } } } This is probably something simple, so assume everything's okay 👍 |
Yep, a simple fix, my mistake. However, instead of that error, I think it would be more helpful to return the message as the one that is buried currently, ie: // Before
{ Error: Exception occurred in retry method that was not classified as transient
at Object.callback (/Users/stephen/dev/gcloud-node/packages/language/node_modules/google-gax/lib/api_callable.js:147:19)
at /Users/stephen/dev/gcloud-node/packages/language/node_modules/grpc/src/node/src/client.js:420:14
cause:
{ Error: The document.type is not specified
at /Users/stephen/dev/gcloud-node/packages/language/node_modules/grpc/src/node/src/client.js:417:17 code: 3, metadata: Metadata { _internal_repr: [Object] } } }
// After
{ Error: The document.type is not specified
at /Users/stephen/dev/gcloud-node/packages/language/node_modules/grpc/src/node/src/client.js:417:17 code: 3, metadata: Metadata { _internal_repr: [Object] } } } Is that something can happen in the generated layer, or should we wrap it and return the |
Updated a new patchset to fix travis-ci failures. Regarding the |
Ah, okay. Thanks for the background. |
Removed |
Changes Unknown when pulling edc3aa3 on jmuk:regen into * on GoogleCloudPlatform:master*. |
Changes Unknown when pulling edc3aa3 on jmuk:regen into * on GoogleCloudPlatform:master*. |
Updates parameter passing style (now accepting an object) and return style (now returning a Promise)