Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate existing GAPIC auto-generated files. #1721

Closed
wants to merge 3 commits into from

Conversation

jmuk
Copy link
Contributor

@jmuk jmuk commented Oct 18, 2016

Updates parameter passing style (now accepting an object) and return style (now returning a Promise)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 18, 2016
@stephenplusplus
Copy link
Contributor

stephenplusplus commented Oct 19, 2016

Thank you! I'm going to mark this PR as don't merge while I pull pieces from it and update our APIs one at a time.

@stephenplusplus
Copy link
Contributor

@jmuk -- I tried to run the Language system tests and got an error:

  1) Language HTML inline annotation should work without creating a document:
     Uncaught Error: Exception occurred in retry method that was not classified as transient
      at Object.callback (node_modules/google-gax/lib/api_callable.js:147:19)
      at node_modules/grpc/src/node/src/client.js:420:14

@stephenplusplus
Copy link
Contributor

Wait, diving deeper gave me some more info:

{ Error: Exception occurred in retry method that was not classified as transient
    at Object.callback (/Users/stephen/dev/gcloud-node/packages/language/node_modules/google-gax/lib/api_callable.js:147:19)
    at /Users/stephen/dev/gcloud-node/packages/language/node_modules/grpc/src/node/src/client.js:420:14
  cause:
   { Error: The document.type is not specified
       at /Users/stephen/dev/gcloud-node/packages/language/node_modules/grpc/src/node/src/client.js:417:17 code: 3, metadata: Metadata { _internal_repr: [Object] } } }

This is probably something simple, so assume everything's okay 👍

@stephenplusplus
Copy link
Contributor

Yep, a simple fix, my mistake. However, instead of that error, I think it would be more helpful to return the message as the one that is buried currently, ie:

// Before
{ Error: Exception occurred in retry method that was not classified as transient
    at Object.callback (/Users/stephen/dev/gcloud-node/packages/language/node_modules/google-gax/lib/api_callable.js:147:19)
    at /Users/stephen/dev/gcloud-node/packages/language/node_modules/grpc/src/node/src/client.js:420:14
  cause:
   { Error: The document.type is not specified
       at /Users/stephen/dev/gcloud-node/packages/language/node_modules/grpc/src/node/src/client.js:417:17 code: 3, metadata: Metadata { _internal_repr: [Object] } } }

// After
{ Error: The document.type is not specified
    at /Users/stephen/dev/gcloud-node/packages/language/node_modules/grpc/src/node/src/client.js:417:17 code: 3, metadata: Metadata { _internal_repr: [Object] } } }

Is that something can happen in the generated layer, or should we wrap it and return the cause error to the user from our handwritten layer?

@jmuk
Copy link
Contributor Author

jmuk commented Oct 19, 2016

Updated a new patchset to fix travis-ci failures.

Regarding the error.cause -- that was embedded in gax-nodejs, and that was simply because I borrowed that from Python, and that design is actually beneficial in Python.
Filed as googleapis/gax-nodejs#56

@stephenplusplus
Copy link
Contributor

Ah, okay. Thanks for the background.

@jmuk
Copy link
Contributor Author

jmuk commented Oct 19, 2016

Removed cause -- it's gone when you update google-gax to 0.8.1.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling edc3aa3 on jmuk:regen into * on GoogleCloudPlatform:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling edc3aa3 on jmuk:regen into * on GoogleCloudPlatform:master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants