language: re-work encoding property #2054
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2018
encoding
andencodingType
are allowed.To Dos
@monattar could you please take a look?
#2018 explained that
encodingType
was not a value attached to a document. But, the "Document" object that we have in our API is just meant to cache content that will be used again for future analysis. So, since the "Document" holds the value, it seems like a fine place to set the encoding type (by the user or by us, using defaults). By not allowing users to set it at the time of Document creation, we are forcing them to set it each time they make a method call, even though the encodingType should be the same each time-- right?