Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language: Expose an apiVersion parameter #2203

Merged
merged 4 commits into from
Apr 11, 2017

Conversation

lukesneeringer
Copy link
Contributor

This commit adds an apiVersion parameter to the Language constructor to provide access to the v1beta2 GAPIC client.

Instantiation looks like:

var language = new Language({apiVersion: 'v1beta2'});

The default value is 'v1', and anything other than 'v1' or 'v1beta2' is an error.
Note that using the 'v1beta2' version will route all calls made to the object through that endpoint, and so existing methods will also get v1beta2 behavior.

@lukesneeringer lukesneeringer self-assigned this Apr 11, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 11, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1848364 on lukesneeringer:nl-v1beta2 into ** on GoogleCloudPlatform:master**.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Apr 11, 2017
@stephenplusplus
Copy link
Contributor

@lukesneeringer could you take a quick look at the changes? Feel free to merge if they look good 👍

@stephenplusplus stephenplusplus removed their request for review April 11, 2017 15:04
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling da82b12 on lukesneeringer:nl-v1beta2 into ** on GoogleCloudPlatform:master**.

@stephenplusplus stephenplusplus added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 11, 2017
@stephenplusplus stephenplusplus merged commit 03e6373 into googleapis:master Apr 11, 2017
@stephenplusplus stephenplusplus added the api: language Issues related to the Cloud Natural Language API API. label Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: language Issues related to the Cloud Natural Language API API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants