Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: Use standard URL to use path instead of subdomain for bucket #638

Merged
merged 2 commits into from
Jun 4, 2015

Conversation

phw
Copy link
Contributor

@phw phw commented Jun 4, 2015

Fixes the SSL certificate being invalid for buckets containing dots.

E.g. if you want to access the bucket mybucket.example.com without this patch this results in the URL https://mybucket.example.com.storage.googleapis.com/ for which the SSL certificate is not valid (the certificate captures direct subdomains only). This patch uses the equally generic URL https://storage.googleapis.com/mybucket.example.com/.

…cket.

Fixes the SSL certificate being invalid for buckets containing dots.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 4, 2015
@phw
Copy link
Contributor Author

phw commented Jun 4, 2015

For reference: This bugs was introduced in 93d7a12

@stephenplusplus
Copy link
Contributor

Cool, thanks. This should resolve #624 then as well, right?

@phw
Copy link
Contributor Author

phw commented Jun 4, 2015

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 4, 2015
@stephenplusplus
Copy link
Contributor

Do you want to fix the tests or have me worry about it?

@phw
Copy link
Contributor Author

phw commented Jun 4, 2015

I think that should fix #624 and it looks IMHO better than the fix provided there (seems a bit hacky). Will fix the unit test in a moment.

@phw
Copy link
Contributor Author

phw commented Jun 4, 2015

Done. Or do you prefer the commits squashed together?

@stephenplusplus
Copy link
Contributor

This is perfect, thanks very much!

stephenplusplus added a commit that referenced this pull request Jun 4, 2015
storage: Use standard URL to use path instead of subdomain for bucket
@stephenplusplus stephenplusplus merged commit 8e98bdf into googleapis:master Jun 4, 2015
@phw
Copy link
Contributor Author

phw commented Jun 4, 2015

Thank you very much, never got anything merged upstream that fast. Saves me some headaches for the deployment today :)

@phw phw deleted the storage-fix-generic-url branch June 4, 2015 13:51
@stephenplusplus
Copy link
Contributor

Great! Never fear submitting patches and ideas here, we'll always get back pretty quickly :)

sofisl pushed a commit that referenced this pull request Nov 10, 2022
We should be running `compile-protos` as part of prepare, do so.

Fixes #632
sofisl pushed a commit that referenced this pull request Nov 11, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [ts-loader](https://togithub.com/TypeStrong/ts-loader) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/ts-loader/7.0.5/8.0.0) |

---

### Release Notes

<details>
<summary>TypeStrong/ts-loader</summary>

### [`v8.0.0`](https://togithub.com/TypeStrong/ts-loader/blob/master/CHANGELOG.md#v800)

[Compare Source](https://togithub.com/TypeStrong/ts-loader/compare/v7.0.5...v8.0.0)

-   [Support for symlinks in project references](https://togithub.com/TypeStrong/ts-loader/pull/1136) - thanks [@&#8203;sheetalkamat](https://togithub.com/sheetalkamat)!
-   `ts-loader` now supports TypeScript 3.6 and greater **BREAKING CHANGE**

</details>

---

### Renovate configuration

:date: **Schedule**: "after 9am and before 3pm" (UTC).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-dialogflow).
sofisl pushed a commit that referenced this pull request Nov 17, 2022
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^14.17.3` -> `^16.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/14.17.32/16.11.6) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/compatibility-slim/14.17.32)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/confidence-slim/14.17.32)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-compute).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants