Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX(storage): throw Error if bucket name is not passed to bucket constru... #68

Merged
merged 1 commit into from
Jul 30, 2014
Merged

FIX(storage): throw Error if bucket name is not passed to bucket constru... #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/storage/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,9 @@ ReadStream.prototype.pipe = function(dest, opts) {
* create a bucket.
*/
function Bucket(opts) {
if (!opts.bucketName) {
throw Error('A bucket name is needed to use Google Cloud Storage');
}
this.bucketName = opts.bucketName;
this.conn = new conn.Connection({
keyFilename: opts.keyFilename,
Expand Down
4 changes: 4 additions & 0 deletions test/storage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ function createBucket() {

describe('Bucket', function() {

it('should throw if a bucket name is not passed', function() {
assert.throws(function() { var bucket = new storage.Bucket(); }, Error);
})

it('should list without a query', function(done) {
var bucket = createBucket();
bucket.makeReq = function(method, path, q, body, callback) {
Expand Down